[7/7] arm64: defconfig: Enable IPQ9574 SoC base configs

Message ID 20230110121316.24892-8-quic_devipriy@quicinc.com
State New
Headers
Series Add minimal boot support for IPQ9574 |

Commit Message

Devi Priya Jan. 10, 2023, 12:13 p.m. UTC
  Enables clk & pinctrl related configs

Co-developed-by: Anusha Rao <quic_anusha@quicinc.com>
Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
Signed-off-by: devi priya <quic_devipriy@quicinc.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Kathiravan Thirumoorthy Jan. 11, 2023, 2:48 p.m. UTC | #1
On 1/10/2023 5:43 PM, devi priya wrote:
> Enables clk & pinctrl related configs
>
> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com>
> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
> Signed-off-by: devi priya <quic_devipriy@quicinc.com>
> ---
>   arch/arm64/configs/defconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 851e8f9be06d..e0ae0996d5ad 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -545,6 +545,7 @@ CONFIG_PINCTRL_IMX93=y
>   CONFIG_PINCTRL_MSM=y
>   CONFIG_PINCTRL_IPQ8074=y
>   CONFIG_PINCTRL_IPQ6018=y
> +CONFIG_PINCTRL_IPQ9574=y
Please move this after IPQ8074, to keep it in ascending order. We can 
move the IPQ6018 config before IPQ8074.
>   CONFIG_PINCTRL_MSM8916=y
>   CONFIG_PINCTRL_MSM8953=y
>   CONFIG_PINCTRL_MSM8976=y
> @@ -1093,6 +1094,7 @@ CONFIG_QCOM_CLK_SMD_RPM=y
>   CONFIG_QCOM_CLK_RPMH=y
>   CONFIG_IPQ_GCC_6018=y
>   CONFIG_IPQ_GCC_8074=y
> +CONFIG_IPQ_GCC_9574=y
>   CONFIG_MSM_GCC_8916=y
>   CONFIG_MSM_GCC_8994=y
>   CONFIG_MSM_MMCC_8996=y
  
Krzysztof Kozlowski Jan. 11, 2023, 3:03 p.m. UTC | #2
On 11/01/2023 15:48, Kathiravan Thirumoorthy wrote:
> 
> On 1/10/2023 5:43 PM, devi priya wrote:
>> Enables clk & pinctrl related configs
>>
>> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com>
>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
>> Signed-off-by: devi priya <quic_devipriy@quicinc.com>
>> ---
>>   arch/arm64/configs/defconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 851e8f9be06d..e0ae0996d5ad 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -545,6 +545,7 @@ CONFIG_PINCTRL_IMX93=y
>>   CONFIG_PINCTRL_MSM=y
>>   CONFIG_PINCTRL_IPQ8074=y
>>   CONFIG_PINCTRL_IPQ6018=y
>> +CONFIG_PINCTRL_IPQ9574=y
> Please move this after IPQ8074, to keep it in ascending order. We can 
> move the IPQ6018 config before IPQ8074.

This must match savedefconfig order, not alphabetical.

Best regards,
Krzysztof
  
Devi Priya Jan. 13, 2023, 1:27 p.m. UTC | #3
On 1/11/2023 8:33 PM, Krzysztof Kozlowski wrote:
> On 11/01/2023 15:48, Kathiravan Thirumoorthy wrote:
>>
>> On 1/10/2023 5:43 PM, devi priya wrote:
>>> Enables clk & pinctrl related configs
>>>
>>> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com>
>>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
>>> Signed-off-by: devi priya <quic_devipriy@quicinc.com>
>>> ---
>>>    arch/arm64/configs/defconfig | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 851e8f9be06d..e0ae0996d5ad 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -545,6 +545,7 @@ CONFIG_PINCTRL_IMX93=y
>>>    CONFIG_PINCTRL_MSM=y
>>>    CONFIG_PINCTRL_IPQ8074=y
>>>    CONFIG_PINCTRL_IPQ6018=y
>>> +CONFIG_PINCTRL_IPQ9574=y
>> Please move this after IPQ8074, to keep it in ascending order. We can
>> move the IPQ6018 config before IPQ8074.
> 
> This must match savedefconfig order, not alphabetical.
Understood!
> 
> Best regards,
> Krzysztof
> 
Best Regards,
Devi Priya
  

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 851e8f9be06d..e0ae0996d5ad 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -545,6 +545,7 @@  CONFIG_PINCTRL_IMX93=y
 CONFIG_PINCTRL_MSM=y
 CONFIG_PINCTRL_IPQ8074=y
 CONFIG_PINCTRL_IPQ6018=y
+CONFIG_PINCTRL_IPQ9574=y
 CONFIG_PINCTRL_MSM8916=y
 CONFIG_PINCTRL_MSM8953=y
 CONFIG_PINCTRL_MSM8976=y
@@ -1093,6 +1094,7 @@  CONFIG_QCOM_CLK_SMD_RPM=y
 CONFIG_QCOM_CLK_RPMH=y
 CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
+CONFIG_IPQ_GCC_9574=y
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_GCC_8994=y
 CONFIG_MSM_MMCC_8996=y