From patchwork Tue Jan 10 12:02:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 41429 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2705453wrt; Tue, 10 Jan 2023 04:05:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXtIOJpIIWrwG1OeVFoZxFEWCyseUkOnCTSWC5nqXGClEQ3c93NlNFsYMeuaNrOu/U0WkEYi X-Received: by 2002:a17:902:9a0b:b0:185:441f:709c with SMTP id v11-20020a1709029a0b00b00185441f709cmr76284945plp.33.1673352354558; Tue, 10 Jan 2023 04:05:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673352354; cv=none; d=google.com; s=arc-20160816; b=baHy4wqlJiFKMvUs2CAHnbTR1DEWMgnXcbe4m84dzr+XbcahGwDh/sFRP4cjUcT7Ks 5EWTE54Ta2YhMWFIm60CcmVZzkYrUmEujJkSAER4NZGZnK6VgpQl3C46yUIz8Lca4tAx KyONR9ZpQy28/Sv6Bd9pLsSVFSa8+Ml+Zkfh7xQuJKTtoCpZiiXGZXuhqW7IazZ7+gTR 9zDukboe4uFqHtn2rFlEdMG3V/0VWRJBFlOFfjvVskl6PZUrGeTQ1lVZY9HbAWyN0PjB vWi3qbmAuSFj2gdLIXKuP2g94ZPlIH3xF+p+6F6DVEX5zKhYcd4xXf+cMifpX0iDAymu FjVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Svga7SsiFsN5UXzPSuWC3QCdzpcdEqH2j+9/f+MZ4Lk=; b=slimFFVJgZsZhVlw04Ekq7M3LiYr5Rnkbiw5QINjNR9KT1ToQlbhKYxypRaFAmTny9 4U4RoJrTWyDh5h25FG6Ju+Ozg8mDCNgkWYpykDjduzQd53o2dPfJJXnAXYbo0ilD2bPk 4nUOfb/95yHtbgVuT2sABkuoC3HgCWLIYe5pBdOjSd+/gKzpGURBqUkrUYrz/evKnqPf /XCD3iXa1031TmQxLS4noF1us87ufvMEkXoMTtC6vNptmR+CxvFUkxXx0mPyRwh2vLKc ClYBBWcZg7/zrV1XYubRNht/O3gNfOJqoy4jx5gaXZfJwziv/4n8cQppokA7rvFXD07Z uh9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cHkLED3x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d14-20020a170903230e00b0017808c0aa8bsi11698810plh.115.2023.01.10.04.05.39; Tue, 10 Jan 2023 04:05:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cHkLED3x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238380AbjAJMEA (ORCPT + 99 others); Tue, 10 Jan 2023 07:04:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238160AbjAJMDV (ORCPT ); Tue, 10 Jan 2023 07:03:21 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3A8958F81; Tue, 10 Jan 2023 04:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673352196; x=1704888196; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0aHYPToS/jABucyxHBUjjp3ckI/iQBTA/kh5jyn5eAU=; b=cHkLED3xkaW8bBvZiskCbthBT1UVTDW//xIAlwPYerflWbeQv5XZKjcJ ZjP3zwrUCrt0kZWuvYInrlBgVIqjDSa4LEWK5/6sniP++G4ByRASAN/Ag NL23V49UnAXAhYixlKwXIhVRH26Ho+XSf0LC4uNPOPUHr92VinnefrUvF EKocW4vr+ay0S42whP8oolg/kKrjl0Ac4WHUWk1t127dFRy7kaFwmtUM2 4KOzoKfXCnkW4Ob3db6v6H2HseBA/Van/GJ5qL8yLT9F9lZZ3mE21BD4r 80DOAQALEU4Pbt583TSQqrWrtDp+5rNraYDpa7lW5EWMMZ73Wb6X8RaST g==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="350350042" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="350350042" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 04:03:16 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="799406815" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="799406815" Received: from gbocanex-mobl.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.249.44.115]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 04:03:14 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , =?utf-8?q?Samuel_Iglesias_Gons=C3=A1lvez?= , Rodolfo Giometti , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH v2 04/13] tty: moxa: Make local var storing tty_port_initialized() bool Date: Tue, 10 Jan 2023 14:02:17 +0200 Message-Id: <20230110120226.14972-5-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230110120226.14972-1-ilpo.jarvinen@linux.intel.com> References: <20230110120226.14972-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754637118298164361?= X-GMAIL-MSGID: =?utf-8?q?1754637118298164361?= Return type of tty_port_initialized() is bool, use matching type for the local variable. Also reorder the local vars to reverse-xmas-tree while at it. Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen --- drivers/tty/moxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c index bc474f3c3f8f..2d9635e14ded 100644 --- a/drivers/tty/moxa.c +++ b/drivers/tty/moxa.c @@ -1664,8 +1664,8 @@ static int moxa_poll_port(struct moxa_port *p, unsigned int handle, u16 __iomem *ip) { struct tty_struct *tty = tty_port_tty_get(&p->port); + bool inited = tty_port_initialized(&p->port); void __iomem *ofsAddr; - unsigned int inited = tty_port_initialized(&p->port); u16 intr; if (tty) {