[v2] net: wan: Add checks for NULL. If uhdlc_priv_tsa != 1 then utdm is not initialized. And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced. Same if dev == NULL.
Commit Message
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Esina Ekaterina <eesina@astralinux.ru>
v2: Add check for NULL for unmap_si_regs
---
drivers/net/wan/fsl_ucc_hdlc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Comments
On Tue, 10 Jan 2023 14:47:45 +0300 Esina Ekaterina wrote:
> Subject: [PATCH v2] net: wan: Add checks for NULL. If uhdlc_priv_tsa != 1 then utdm is not initialized. And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced. Same if dev == NULL.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Esina Ekaterina <eesina@astralinux.ru>
>
> v2: Add check for NULL for unmap_si_regs
> ---
The format of your commit is wrong. You should make the commit message
look like this in git:
net: wan: Add checks for NULL
If uhdlc_priv_tsa != 1 then utdm is not initialized.
And if ret != NULL then goto undo_uhdlc_init, where
utdm is dereferenced. Same if dev == NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Esina Ekaterina <eesina@astralinux.ru>
---
v2: Add check for NULL for unmap_si_regs
But the first line (subject) is still not specific enough.
Refer to the bug that's being fixed, not how it's fixed.
Also no braces needed around single-line if blocks.
@@ -1243,9 +1243,13 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
free_dev:
free_netdev(dev);
undo_uhdlc_init:
- iounmap(utdm->siram);
+ if (utdm != NULL) {
+ iounmap(utdm->siram);
+ }
unmap_si_regs:
- iounmap(utdm->si_regs);
+ if (utdm != NULL) {
+ iounmap(utdm->si_regs);
+ }
free_utdm:
if (uhdlc_priv->tsa)
kfree(utdm);