From patchwork Mon Jan 9 21:28:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 41160 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2391912wrt; Mon, 9 Jan 2023 13:34:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXsE/wOl4/OetRBkiWuaogpcY3LfqQ/tvVEqNXVh9WzQbf2zQwKb1XfucFQclwI1yA92arsc X-Received: by 2002:a17:907:2c6c:b0:828:7581:f01f with SMTP id ib12-20020a1709072c6c00b008287581f01fmr49892845ejc.23.1673300062354; Mon, 09 Jan 2023 13:34:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673300062; cv=none; d=google.com; s=arc-20160816; b=PLWbqSseqxRbYydzxBJFcDe1DjZUKjtitpcuScUg2Y+IwWdGd6NW6wZQ93TP6+l6hi 2/b3bSjqeDNUQezlUgViif4V1nfTI1KnJFvlhAOdbNGTl+2G9/3LyswBo4dgRERf+QN8 KczSziDfUJlDxyQl2nlAGXKKbiCmF4JWrQ6KzOaqrHXugTtHGCFSlUkDm7BPxQHW/aLO kbeYhrqS7q/s1F1Rn9kUah8pmcg1LGbW3bgzl5nNlbDvoKaspGvV2FbyPjQKX1eJRsZc E9HUWGkZBYPsT59LTf7imNThKYbCzu39G9WAZursqNS4hqZelZ0VfHNdWADsMb+bfaHB bFng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cMJ3ceXvxgPdEbPMxQqDRLI8Ognh9U7d/fpuwhuSCfE=; b=P5o7ew2mHs7G2z6UlPf7Hjt4qCa7p9QfHuMPax5XEfAZ8aEHNBBtHpP4rs3M6V5Zag BD61l03PeTf+tvx4rbCpSsJuzSZoSQ2djR7V0Xn065Ra5EHYRUHp3A9KNEUw4z5pQbpi d4qEIDW4X0oMK4+p23/8OfxnBWhKfxfQkktwS+iupKJ+E1go1UL2mI/0xyZp6qEt/E77 k4o01GDi53BvtWgBiJVUylWTssiwaboZlaK8x5WQz30LXHCm1jHBiHtwcA480m3LpNrm mKiwYFRz6RDTSWVBklWfViATt1s+NwlR82bxRRYDbK3kAUj+U0HxtiX6R1HOVrChZSAm fG8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb8-20020a170907160800b0084d459379a1si4326118ejc.381.2023.01.09.13.33.57; Mon, 09 Jan 2023 13:34:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235145AbjAIVaB (ORCPT + 99 others); Mon, 9 Jan 2023 16:30:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbjAIV3X (ORCPT ); Mon, 9 Jan 2023 16:29:23 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 763C26258 for ; Mon, 9 Jan 2023 13:29:16 -0800 (PST) Received: from dslb-188-096-147-178.188.096.pools.vodafone-ip.de ([188.96.147.178] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pEzhe-0007iD-8q; Mon, 09 Jan 2023 22:29:10 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 08/12] staging: r8188eu: txirp_cnt is write-only Date: Mon, 9 Jan 2023 22:28:48 +0100 Message-Id: <20230109212852.75612-9-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230109212852.75612-1-martin@kaiser.cx> References: <20230108185738.597105-1-martin@kaiser.cx> <20230109212852.75612-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754482531399476094?= X-GMAIL-MSGID: =?utf-8?q?1754582286548734525?= txirp_cnt in struct xmit_priv is initialised but never read. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 2 -- drivers/staging/r8188eu/include/rtw_xmit.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index 8211b858573f..1cd560630de3 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -192,8 +192,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) for (i = 0; i < 4; i++) pxmitpriv->wmm_para_seq[i] = i; - pxmitpriv->txirp_cnt = 1; - pxmitpriv->ack_tx = false; mutex_init(&pxmitpriv->ack_tx_mutex); rtw_sctx_init(&pxmitpriv->ack_tx_ops, 0); diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h index 7e6cf745d913..50d9311d3e40 100644 --- a/drivers/staging/r8188eu/include/rtw_xmit.h +++ b/drivers/staging/r8188eu/include/rtw_xmit.h @@ -279,7 +279,6 @@ struct xmit_priv { u8 wmm_para_seq[4];/* sequence for wmm ac parameter strength * from large to small. it's value is 0->vo, * 1->vi, 2->be, 3->bk. */ - u8 txirp_cnt;/* */ struct tasklet_struct xmit_tasklet; struct __queue free_xmitbuf_queue; struct __queue pending_xmitbuf_queue;