From patchwork Mon Jan 9 17:27:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 41012 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2283106wrt; Mon, 9 Jan 2023 09:33:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXtTLuhfMDmrEp+upEZew8rLl2lX+VTvyHoRQrovaT3JQEoSb43WB9pA/N6Po8qjTypzq+eg X-Received: by 2002:aa7:99cf:0:b0:581:c741:f908 with SMTP id v15-20020aa799cf000000b00581c741f908mr40028525pfi.33.1673285637681; Mon, 09 Jan 2023 09:33:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673285637; cv=none; d=google.com; s=arc-20160816; b=w3ShlWjkpZUR1G1GH4UzNQx6C3YaOz5RwJ8QRIhEIkigJNq6fWCJeHd7SVXBtPdjno 4E8qJIBsxoZul2ir0hadfcGaJ5l75b43kyvsyMK8cs5XsVKkQAGCqaBJiwfWESb3JbGK 7w7I5znJn3SXkIuI1a4sJthuVhjM0hTJQpfrtwTK99deNGXoJLn/TsKuqEcaqFJUj3vk Gn6aLxXDdDRNMsbmxXbyC8162BXrdcb+wK3ZcDKffFjE1IJ0HIepGVl84eaaB5zvUk5q do3SAEM3UwJvh0ltUYo1EUMMskpnPctT8bD6Lqu8MkBOrTlR0mNITcMeNoxcQ5M1sAT8 Hb3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+8jt9KObevzStGgbzoTc3cape+WRJnmipepQAwnbtJ4=; b=qvpg4uxSTIYCJGsrIJ+VjGUVTMmr5r7zuaCnVPm9ZMjJiD5GIDl/UEqYjWAkRSMUfE XSfJ60P+IBkOjKOln9rGxJNX+OuovzT1LKNM+YZCCLYTTyj09b3KABCqoNXSqSkyjzOL AnkYXdtsNM2OtMSOqy1HB4gn6FivadSUHW+A7KM+7kkJfmdo4BXp+Qs1+mji5MiLCbsb 3r0nwoirrJ2EteePKNIY+F4I5KGhoSH2JZ7TsHWtaYlTF9HmfBYo+4gKvTklockd7asK ubji+n8QFLdTnh+M7D8VOAsaRZZdPwO8UbbX2QX4t1W1698IoXKkp/xwvK96/UMAJPst /gNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=cFOGHhCt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a056a0015c900b00582a8f20674si10405900pfu.213.2023.01.09.09.33.45; Mon, 09 Jan 2023 09:33:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=cFOGHhCt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237433AbjAIR2a (ORCPT + 99 others); Mon, 9 Jan 2023 12:28:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237300AbjAIR1d (ORCPT ); Mon, 9 Jan 2023 12:27:33 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA3ADDF21; Mon, 9 Jan 2023 09:27:31 -0800 (PST) Received: from jupiter.universe (dyndsl-037-138-188-006.ewe-ip-backbone.de [37.138.188.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id D68926602D7B; Mon, 9 Jan 2023 17:27:28 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1673285249; bh=TNmTI9LRk0yhLmS5JTsTApyWD6mKPxT3umkyxpXaAjI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cFOGHhCt/udQ9k20u7fu8alipxPIfMvMw9LefZArUzZQG32gkSmCKaNLlAuL4YRqX JM3APR+yYSpmQoEdqbG/TuEb9DDn+PJkcRXLGtZpb5hZDFqaC0bLBi2jWAA9/57i4Y CMcNZL8cA0q5szkcWCWqFZpBnoUA7Yz3Gv+tLLJgwNNDs7LmaDIhRvIge9FMRbzL5W gC62Tm+7+fzoYzkGxzsEERMO3qXrSW+XcqC6ivgxEdQK1X/lNWSCLpN3LVxD0oaZPp yTHLiHQmFTrNzh++uPsK/nj/buP+bzTE3zaHUjd85FtHMTmrOOBoPI1rEfTDkFxXh0 kS66mmTvlrVsw== Received: by jupiter.universe (Postfix, from userid 1000) id 67FC6480121; Mon, 9 Jan 2023 18:27:24 +0100 (CET) From: Sebastian Reichel To: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Lee Jones Cc: Michael Turquette , Stephen Boyd , Linus Walleij , Mark Brown , Liam Girdwood , Alexandre Belloni , Alessandro Zummo , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCHv5 09/10] regulator: expose regulator_find_closest_bigger Date: Mon, 9 Jan 2023 18:27:22 +0100 Message-Id: <20230109172723.60304-10-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230109172723.60304-1-sebastian.reichel@collabora.com> References: <20230109172723.60304-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754567160923840177?= X-GMAIL-MSGID: =?utf-8?q?1754567160923840177?= Expose and document the table lookup logic used by regulator_set_ramp_delay_regmap, so that it can be reused for devices that cannot be configured via regulator_set_ramp_delay_regmap. Signed-off-by: Sebastian Reichel --- drivers/regulator/helpers.c | 22 ++++++++++++++++++---- include/linux/regulator/driver.h | 2 ++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index ad2237a95572..586f42e378ee 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -902,8 +902,21 @@ bool regulator_is_equal(struct regulator *reg1, struct regulator *reg2) } EXPORT_SYMBOL_GPL(regulator_is_equal); -static int find_closest_bigger(unsigned int target, const unsigned int *table, - unsigned int num_sel, unsigned int *sel) +/** + * regulator_find_closest_bigger - helper to find offset in ramp delay table + * + * @target: targeted ramp_delay + * @table: table with supported ramp delays + * @num_sel: number of entries in the table + * @sel: Pointer to store table offset + * + * This is the internal helper used by regulator_set_ramp_delay_regmap to + * map ramp delay to register value. It should only be used directly if + * regulator_set_ramp_delay_regmap cannot handle a specific device setup + * (e.g. because the value is split over multiple registers). + */ +int regulator_find_closest_bigger(unsigned int target, const unsigned int *table, + unsigned int num_sel, unsigned int *sel) { unsigned int s, tmp, max, maxsel = 0; bool found = false; @@ -933,6 +946,7 @@ static int find_closest_bigger(unsigned int target, const unsigned int *table, return 0; } +EXPORT_SYMBOL_GPL(regulator_find_closest_bigger); /** * regulator_set_ramp_delay_regmap - set_ramp_delay() helper @@ -951,8 +965,8 @@ int regulator_set_ramp_delay_regmap(struct regulator_dev *rdev, int ramp_delay) if (WARN_ON(!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table)) return -EINVAL; - ret = find_closest_bigger(ramp_delay, rdev->desc->ramp_delay_table, - rdev->desc->n_ramp_values, &sel); + ret = regulator_find_closest_bigger(ramp_delay, rdev->desc->ramp_delay_table, + rdev->desc->n_ramp_values, &sel); if (ret) { dev_warn(rdev_get_dev(rdev), diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h index d3b4a3d4514a..c6ef7d68eb9a 100644 --- a/include/linux/regulator/driver.h +++ b/include/linux/regulator/driver.h @@ -758,6 +758,8 @@ int regulator_set_current_limit_regmap(struct regulator_dev *rdev, int min_uA, int max_uA); int regulator_get_current_limit_regmap(struct regulator_dev *rdev); void *regulator_get_init_drvdata(struct regulator_init_data *reg_init_data); +int regulator_find_closest_bigger(unsigned int target, const unsigned int *table, + unsigned int num_sel, unsigned int *sel); int regulator_set_ramp_delay_regmap(struct regulator_dev *rdev, int ramp_delay); int regulator_sync_voltage_rdev(struct regulator_dev *rdev);