From patchwork Mon Jan 9 15:09:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 40916 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2210113wrt; Mon, 9 Jan 2023 07:12:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXvMGj5y1uZeGYqgZAJCE9tkCxVvPL8agNAn+mF9wMYexp2aIB6Xw/uMIP0eJqerF5bXADrX X-Received: by 2002:a17:90a:4503:b0:226:cf55:913f with SMTP id u3-20020a17090a450300b00226cf55913fmr15728658pjg.29.1673277161654; Mon, 09 Jan 2023 07:12:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673277161; cv=none; d=google.com; s=arc-20160816; b=w7a4tpUpV69Df02XmGRnfiTdV3QGbgi+w2Q9cEtdAn5zrAf3IzORmjW8do2hik+GWb exu5xWRd+p6CylimnWDsVblWPR0XbqzwGB64EMXvnDHm0bX8OkZvipTmr8BH4tAZMvMx 2PDj8zQDq/1F3Yd3lxiBmHDJ1p7cxx0qAk/OUYr9jr5WpKOxRpujdTDyH7WHq70InmDU nNyuSRj3Ol1wLI7BWOXnSpMh9IyGll3zTlP/ycvbrOSCu8w96N0E2ELZDLWcUqtYtbvS 6qjbovf0fF47c1undcOuqHZBin04tFsKeMhowN7wEps73ZqE4ONd1vNbZnh11ouNEQtW dOQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bvld8zPnYDTnQIG1YqFCYb/KZpQyo3ITt9siNGCo5AU=; b=vCRsITx7QNx5LAFOa9jiCb5FGbgZhP0DoIJeL3lbanidSu2Gy83m+a1JAS8WpxnYcJ IHClYuYaOw69ee/8m7FGNh73ScUtVelozrTGcPT1+EWSAi8zV3WdO3JhlkvefmnyiFGg xgEOC6rSLTL4wmWtKBIG2NkvFZjVDqhh0nokXbxReQVnlMxfHW7aQfWmJ9ryhopXMuIo QmtIS5GdTPv5I0mb1wgF7Zeoe/+DgOGJb47mL1vv66rUtxvBmfUniUjKeYSG8Smie5je E4AajbAVU6RBp4IVe4IQ9CxCVq15tSaWd7qMUIzAHAoPa5URNZcCKFBQ/yjhouC7A2hy jsMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=vFJ4c9PD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pg18-20020a17090b1e1200b002262476fc44si10625085pjb.178.2023.01.09.07.12.28; Mon, 09 Jan 2023 07:12:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=vFJ4c9PD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234055AbjAIPJp (ORCPT + 99 others); Mon, 9 Jan 2023 10:09:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235536AbjAIPJ0 (ORCPT ); Mon, 9 Jan 2023 10:09:26 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 586B32DD4 for ; Mon, 9 Jan 2023 07:09:25 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BF9EF34300; Mon, 9 Jan 2023 15:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673276963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=bvld8zPnYDTnQIG1YqFCYb/KZpQyo3ITt9siNGCo5AU=; b=vFJ4c9PD8hUN1mARIMwxWF3d/NZ/pc8pC3MQlSRQRs0Sikg/ojs58lhAE4+cVRT9SEL5Lt UqCOuBfA+OZ0KtIVPDjs94DZnYPv5X6A8k7wQ1G8tbRh3i+f1FV1MsMlcHcXUyFptlc1T+ M4AJqrOad/ZUJ+3AhGSlF0oacbYL6LM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 788C2134AD; Mon, 9 Jan 2023 15:09:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id diIQHCMuvGORRQAAMHmgww (envelope-from ); Mon, 09 Jan 2023 15:09:23 +0000 From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: xen-devel@lists.xenproject.org, Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH] x86/mm: fix poking_init() for Xen PV guests Date: Mon, 9 Jan 2023 16:09:22 +0100 Message-Id: <20230109150922.10578-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754558272956461860?= X-GMAIL-MSGID: =?utf-8?q?1754558272956461860?= Commit 3f4c8211d982 ("x86/mm: Use mm_alloc() in poking_init()") broke the kernel for running as Xen PV guest. It seems as if the new address space is never activated before being used, resulting in Xen rejecting to accept the new CR3 value (the PGD isn't pinned). Fix that by adding the now missing call of paravirt_arch_dup_mmap() to poking_init(). That call was previously done by dup_mm()->dup_mmap() and it is a NOP for all cases but for Xen PV, where it is just doing the pinning of the PGD. Fixes: 3f4c8211d982 ("x86/mm: Use mm_alloc() in poking_init()") Signed-off-by: Juergen Gross --- arch/x86/mm/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index d3987359d441..5f8ba537d9d3 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -804,6 +804,9 @@ void __init poking_init(void) poking_mm = mm_alloc(); BUG_ON(!poking_mm); + /* Xen PV guests need the PGD to be pinned. */ + paravirt_arch_dup_mmap(NULL, poking_mm); + /* * Randomize the poking address, but make sure that the following page * will be mapped at the same PMD. We need 2 pages, so find space for 3,