From patchwork Mon Jan 9 12:30:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 40825 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2130005wrt; Mon, 9 Jan 2023 04:35:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXut1bdszKxql7wXYTE/Z0e+NuZHlndhED+W2SH60SKh+rtB/j1efafd3SfiO2xryiXhcMYr X-Received: by 2002:a17:907:a588:b0:84d:43e4:3633 with SMTP id vs8-20020a170907a58800b0084d43e43633mr3807930ejc.36.1673267752906; Mon, 09 Jan 2023 04:35:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673267752; cv=none; d=google.com; s=arc-20160816; b=RRWf3Q6kdY72NUzesl2KtQ2W9nB6XGEQ5QNOG/5cZXT1huHaReY//ax0Be9xxuhEyR piTuqQUKcTtblW1nTGra+0bKPXvox5L8Q49iuFY1FoMr4bLd4l4ZhHOc2+cT9aViUKEa oH26JCNuGGryWA+EDtN9XztoC0OixwJf0Ec9wTGo/06CkN42dFfIgafOdimt3tY1GISY 1AVDclxfDCINvPR5m7nZEiTrkSAFinsRajAUHtQaz0lFqtDazp/z1Pl6pk33Rqgz77Yj 4lwQT1SWevyOU+RqHUOfbQhD0xnACPJrzt3/RAuTqaIGlQIMsv5WXQsM4MVJf0n2pmow IkhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=08E5qi8vxqr6+TC+1BFlozXvA3KflPEceb13Px12www=; b=W2P0ZMIaBF5U8idB0R+hofbQ5BIXNFXS11T6zAkcq99FS2Um8jJNcqUe7x/OxVeraX aocZpa8Oua2V4VW27CeKQlTg6R+5O/IpyG9JtxujnFAZmOKpLIZRK4ap5HZ+8+1DIRu9 DwxJcE9cB+1IlRxAqrU5UOow6UBLXijdiniE1yI7f0LPn5KdEVEfopBiZDBQPGKMSfIg LGt0xZAtqWLm2TFlZy1W+fFVJf4+A/f6IjPz3bT9m3kB08NYJxyr4FumI0+XL+TWREso upwOWd8ytng5XkFSv2l1w9oRZlDuFo7loWflSr7sA2qQuidTpXtTYZO+ADqXNGKECcf5 TCcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=dOKdBQ8u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020a056402358600b0046aa4908162si11018987edc.46.2023.01.09.04.35.29; Mon, 09 Jan 2023 04:35:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=dOKdBQ8u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237212AbjAIMbP (ORCPT + 99 others); Mon, 9 Jan 2023 07:31:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237279AbjAIMa1 (ORCPT ); Mon, 9 Jan 2023 07:30:27 -0500 Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 702F11BE9C; Mon, 9 Jan 2023 04:30:24 -0800 (PST) Received: from mwalle01.kontron.local. (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 8C27216AB; Mon, 9 Jan 2023 13:30:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1673267422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=08E5qi8vxqr6+TC+1BFlozXvA3KflPEceb13Px12www=; b=dOKdBQ8uqyyE6MBH9TUYo+iQ0CRxnYEg0ja4lXvoXxM77ndF1zyiCeiRMzeWAzt1/8LkiP iClmXZfFVWzDP+xAIQ/H2g9OMYPEQKzVng1NF/F1jWIBnlfgtUiDkXAC4fLVEBQbC2bwLZ SqV4qdP6XbcJ6ZBPYfAYIUuc9N7582EIW3di8KxxpvzJqlMq9NQMKZO/YA1aB+ucjdunu0 lA6SL1hn2Ljz3YXTTSfMrW954MjrpDAky4QjBGEH6ZuIQDeujX3mw7g9TQUlkrc6zgtpTJ UITrnQSr366XXiF7uhXE9LtQzTsp1W5NjMvkAM/loHXBWJzyGNVtZwPdHTJHSA== From: Michael Walle To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Walle Subject: [PATCH net-next v3 4/4] net: phy: mxl-gpy: disable interrupts on GPY215 by default Date: Mon, 9 Jan 2023 13:30:13 +0100 Message-Id: <20230109123013.3094144-5-michael@walle.cc> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230109123013.3094144-1-michael@walle.cc> References: <20230109123013.3094144-1-michael@walle.cc> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754548406887405788?= X-GMAIL-MSGID: =?utf-8?q?1754548406887405788?= The interrupts on the GPY215B and GPY215C are broken and the only viable fix is to disable them altogether. There is still the possibilty to opt-in via the device tree. Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn --- drivers/net/phy/mxl-gpy.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c index 147d7a5a9b35..e5972b4ef6e8 100644 --- a/drivers/net/phy/mxl-gpy.c +++ b/drivers/net/phy/mxl-gpy.c @@ -12,6 +12,7 @@ #include #include #include +#include #include /* PHY ID */ @@ -292,6 +293,10 @@ static int gpy_probe(struct phy_device *phydev) phydev->priv = priv; mutex_init(&priv->mbox_lock); + if (gpy_has_broken_mdint(phydev) && + !device_property_present(dev, "maxlinear,use-broken-interrupts")) + phydev->dev_flags |= PHY_F_NO_IRQ; + fw_version = phy_read(phydev, PHY_FWV); if (fw_version < 0) return fw_version;