From patchwork Sun Jan 8 18:57:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 40535 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1816781wrt; Sun, 8 Jan 2023 11:03:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXvPaeKGVWYtZ16tJxwFo1LP/Q2gApGdGHvyri8op2HN21ractT8N8taGCCiKidpd818CcCg X-Received: by 2002:a17:906:9709:b0:7c0:af5d:c54c with SMTP id k9-20020a170906970900b007c0af5dc54cmr47468916ejx.77.1673204584927; Sun, 08 Jan 2023 11:03:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673204584; cv=none; d=google.com; s=arc-20160816; b=NneIdR7FG0QiLosrSSiTddq4HR5Dlyn+CF2lRly8OVRg28LPjNUVm3FR3yCNaLsGfQ YLyJdB/l3kYUmJhaeyehxxFRi2tRYDv75K8tX8Pl+WqdV4AGVNr1YNdys4B3agGFFiRD 83SsAMrdXIe+I4jU3spiHyvBdTNDN+o9nNS6+9SVsKOkXqy6JpK3uGbsFy/2DBWmj4Ir yO6WtnFdRelT14irSnmQdzJfDOovuV+cvSwKWIVkC/iCpbxwlT88YJ0iEVy0qAUK17cK nNWVeqUJ76hXnQTacaXl8hadUcfjO4L1plTaBZXlyvbGeujV2TEhtunYNy51QJuB1rpP K8fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CfPgYeYZAjB7Ggs1AxFI9UPI632K5V++hia1F6y2Pm4=; b=wxzznyiEtWMDUaOK1G/plUV2xXw29T9aICnfJQCPK9cEsIYulbqn6GYjhhgKflzuKs 3LOnWWgXfO8ItBQQgfGplp2a8Zh9Z65K6DRjgYsCUhQE7zsCCgg5D9PxUgdQtj4xFu6Q ELiV9q+S+a6qzmY3DT8f9j++uarDH2OeQ0V4G82tmqJawlfFZx+OabjrNT9R+v6rB8mX mxbeeID3CyWE2Cb0An2v0TC/ECqhDoE19nLOUwtuTawuFzAa3Mh6AufRSPwVkNeow7dV dvV+EA1qeg3yjy2byWS6ylT0Tcyq6nC7ndXx+tXNhluoPOb0KEyxLZ0WpjMiE6lEMfhV OhBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr5-20020a170907720500b007c12e19ba40si7539426ejc.666.2023.01.08.11.02.42; Sun, 08 Jan 2023 11:03:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236320AbjAHS6M (ORCPT + 99 others); Sun, 8 Jan 2023 13:58:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234698AbjAHS57 (ORCPT ); Sun, 8 Jan 2023 13:57:59 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78FB3E017 for ; Sun, 8 Jan 2023 10:57:57 -0800 (PST) Received: from dslb-188-096-147-053.188.096.pools.vodafone-ip.de ([188.96.147.53] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pEarg-0003b8-Ij; Sun, 08 Jan 2023 19:57:52 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 03/13] staging: r8188eu: viq_cnt is write-only Date: Sun, 8 Jan 2023 19:57:28 +0100 Message-Id: <20230108185738.597105-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230108185738.597105-1-martin@kaiser.cx> References: <20230108185738.597105-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754482170514263874?= X-GMAIL-MSGID: =?utf-8?q?1754482170514263874?= viq_cnt in struct xmit_priv is initialised, incremented and decremented but never read. Remove viq_cnt and resulting dead code. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 1 - drivers/staging/r8188eu/include/rtw_xmit.h | 1 - drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 4 ---- 3 files changed, 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index 875675656d11..1319a7fce8b3 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -195,7 +195,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->txirp_cnt = 1; /* per AC pending irp */ - pxmitpriv->viq_cnt = 0; pxmitpriv->voq_cnt = 0; pxmitpriv->ack_tx = false; diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h index 3d56c3afaf7d..71a7fb33b0d0 100644 --- a/drivers/staging/r8188eu/include/rtw_xmit.h +++ b/drivers/staging/r8188eu/include/rtw_xmit.h @@ -282,7 +282,6 @@ struct xmit_priv { u8 txirp_cnt;/* */ struct tasklet_struct xmit_tasklet; /* per AC pending irp */ - int viq_cnt; int voq_cnt; struct __queue free_xmitbuf_queue; struct __queue pending_xmitbuf_queue; diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c index 5ae09edf9174..7929b7d5e89e 100644 --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c @@ -45,9 +45,6 @@ static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs) case VO_QUEUE_INX: pxmitpriv->voq_cnt--; break; - case VI_QUEUE_INX: - pxmitpriv->viq_cnt--; - break; case HIGH_QUEUE_INX: rtw_chk_hi_queue_cmd(padapter); break; @@ -113,7 +110,6 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) pxmitbuf->flags = VO_QUEUE_INX; break; case VI_QUEUE_INX: - pxmitpriv->viq_cnt++; pxmitbuf->flags = VI_QUEUE_INX; break; case BE_QUEUE_INX: