From patchwork Sun Jan 8 18:57:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 40537 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1817176wrt; Sun, 8 Jan 2023 11:03:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXunm2xmTd/yE2QRwQKqV3lK1fco3jN6Jns54qcl00lg3JCMTqHP90kC7IrdsB8Y81LKynWF X-Received: by 2002:a62:e814:0:b0:582:c408:3ed1 with SMTP id c20-20020a62e814000000b00582c4083ed1mr19196220pfi.32.1673204633742; Sun, 08 Jan 2023 11:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673204633; cv=none; d=google.com; s=arc-20160816; b=GvATZZKq7qRlLNLIbFzoP8X+0x9KjkbH3PN8KVqxWD0oWYMhcoUz1WjW65EDDv+L0p XSlUiB1pF/rj7C7zrCtjlNQhHIvf4p4e3rquPAKov5lIf2YfXIpXVJfLpzuRk3mn/fbH kdt7wKn0xLIzlRNAs42RTbe1BMXHw9xkYzSpGlqMtRbKMDQzvqsXFQ2zPaIM5TlhaYkL /D3vmisatuQChZbstEXyXCnXNzuJCPGmcgJaRweBiMfMbu3mjWV/T7bVg4D/HlhePDHz 4E9TmLyBQGOy0NIFVm+/crVbaeuxebC/ntcZX/mZJ1MaBrqUvhX6zgQ9fwuvCB+JaPSJ KWtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3VHIN37mdx1O10AoFulxGo7ZZaU4463DGS8VGSbOa80=; b=Ua/wPucapAsn9O1NKpWAEqkPTLrSlTeeJE5ea8SPgZlkU2xMubQpfCcLPlId4DM4Un S2xTzbBefHXj7oftVE5LvQQO/EOkHDlW1YnOEJUk+jP1wHk8qQa4aSMOTAfLe5aY7lUQ GnnOQ9etsR8GL3zu7Z3j0lO1u6PDmYoXAmJn8Fq8wGdtD8ooTqTuBcFb/nAVe8uUATBO m1wLpwrFBrsS+SZEDnpokHhtV+imrs5j6jJNqzlyrwMHKJNG4f641cVT0Dx35UzStWIk /1/YyZb2G1VFXn8Hm1iXkOpaLOXAiginlsLX6JbPoH8blehK4mbHk8LI6xnlU+zeHmdZ +UUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h15-20020a056a001a4f00b0053e9c7939basi7581504pfv.188.2023.01.08.11.03.41; Sun, 08 Jan 2023 11:03:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236166AbjAHS6H (ORCPT + 99 others); Sun, 8 Jan 2023 13:58:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233641AbjAHS56 (ORCPT ); Sun, 8 Jan 2023 13:57:58 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92947E00D for ; Sun, 8 Jan 2023 10:57:57 -0800 (PST) Received: from dslb-188-096-147-053.188.096.pools.vodafone-ip.de ([188.96.147.53] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pEarf-0003b8-PP; Sun, 08 Jan 2023 19:57:51 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 02/13] staging: r8188eu: bkq_cnt is write-only Date: Sun, 8 Jan 2023 19:57:27 +0100 Message-Id: <20230108185738.597105-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230108185738.597105-1-martin@kaiser.cx> References: <20230108185738.597105-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754482221899707259?= X-GMAIL-MSGID: =?utf-8?q?1754482221899707259?= bkq_cnt in struct xmit_priv is initialised, incremented and decremented but never read. Remove bkq_cnt and resulting dead code. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 1 - drivers/staging/r8188eu/include/rtw_xmit.h | 1 - drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 4 ---- 3 files changed, 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index e5ac49441337..875675656d11 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -195,7 +195,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->txirp_cnt = 1; /* per AC pending irp */ - pxmitpriv->bkq_cnt = 0; pxmitpriv->viq_cnt = 0; pxmitpriv->voq_cnt = 0; diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h index c84f73f2cc59..3d56c3afaf7d 100644 --- a/drivers/staging/r8188eu/include/rtw_xmit.h +++ b/drivers/staging/r8188eu/include/rtw_xmit.h @@ -282,7 +282,6 @@ struct xmit_priv { u8 txirp_cnt;/* */ struct tasklet_struct xmit_tasklet; /* per AC pending irp */ - int bkq_cnt; int viq_cnt; int voq_cnt; struct __queue free_xmitbuf_queue; diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c index 067b7def2bde..5ae09edf9174 100644 --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c @@ -48,9 +48,6 @@ static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs) case VI_QUEUE_INX: pxmitpriv->viq_cnt--; break; - case BK_QUEUE_INX: - pxmitpriv->bkq_cnt--; - break; case HIGH_QUEUE_INX: rtw_chk_hi_queue_cmd(padapter); break; @@ -123,7 +120,6 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) pxmitbuf->flags = BE_QUEUE_INX; break; case BK_QUEUE_INX: - pxmitpriv->bkq_cnt++; pxmitbuf->flags = BK_QUEUE_INX; break; case HIGH_QUEUE_INX: