From patchwork Sun Jan 8 18:57:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 40546 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1818969wrt; Sun, 8 Jan 2023 11:08:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXvwziDBilzZG+IkOrLDItIAAt9OYif3gjekGQTXf0Y62erUmZEweEaAYA2QmEa0OYSLw9Ky X-Received: by 2002:a17:90a:2b0d:b0:226:e59a:f86a with SMTP id x13-20020a17090a2b0d00b00226e59af86amr8485372pjc.10.1673204928732; Sun, 08 Jan 2023 11:08:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673204928; cv=none; d=google.com; s=arc-20160816; b=GGJeRzdx8jD/tSH8JcjVGgYaTsjNsX6CKRNa/LYZGCIRcEI5O62HtpRTbBJpR70rOH A+FoolScsoTA46roxTu9qGLzNm89gh1Z13rYjnuGLjntJllhr12VuZyVjrSEEUd46Len 3mCAniH4dz8SacNkphV357c+pHGgEhCU8l8zfQIKO/Q9T3Kdt9jR9Z0m2F93tiuE/y+i /nwquZTMOYp00cNzGO5gJPh5u5C5G5AdIyQ+Ovv/MF91Jts/HKD/jRrQ5MgBa/dwFocU fLI2YeF8tus6zCdX8I11EQghuuV5UrLab/I/9a9eAj7w9z4GVVT0uRpFUPe+Pu55/Tto I2ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cMJ3ceXvxgPdEbPMxQqDRLI8Ognh9U7d/fpuwhuSCfE=; b=Tg95bM9gSjDL0MGoegi/IRwNX/J33Tgtt8nk9Y+QHc5NZxdosCXai0ThYRhnHJQdTX LZqUJLal4RvA+E2GDt9WZRcAzrgkpP3eiC1f7yorexBg/i0Q4NYQd3AfmLVRbrh5pOmg I+lb02XC2fcENmQl9DkwfRFzu1A/5zhUX8zklXQirDihyvqE0kdj6u7t7fslAkHpPj+U njd+ZG8vCaAxg7Ya/Yo4tnz5T7vNyZcMFdth75DvXCw2hUSzTpYaf91k7SrhyoE1z7M5 F5I7PVBlmNnMDezkZFRhUJ2j3PH6+AClI4vos1x6oHv60cwh6JVuu5K/4sMac38vSuNv PZEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a63ea4c000000b00477810a445asi8249419pgk.589.2023.01.08.11.08.36; Sun, 08 Jan 2023 11:08:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236534AbjAHS62 (ORCPT + 99 others); Sun, 8 Jan 2023 13:58:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236095AbjAHS6D (ORCPT ); Sun, 8 Jan 2023 13:58:03 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CFACE00F for ; Sun, 8 Jan 2023 10:58:02 -0800 (PST) Received: from dslb-188-096-147-053.188.096.pools.vodafone-ip.de ([188.96.147.53] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pEarl-0003b8-JN; Sun, 08 Jan 2023 19:57:57 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 09/13] staging: r8188eu: txirp_cnt is write-only Date: Sun, 8 Jan 2023 19:57:34 +0100 Message-Id: <20230108185738.597105-10-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230108185738.597105-1-martin@kaiser.cx> References: <20230108185738.597105-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754482531399476094?= X-GMAIL-MSGID: =?utf-8?q?1754482531399476094?= txirp_cnt in struct xmit_priv is initialised but never read. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 2 -- drivers/staging/r8188eu/include/rtw_xmit.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index 8211b858573f..1cd560630de3 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -192,8 +192,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) for (i = 0; i < 4; i++) pxmitpriv->wmm_para_seq[i] = i; - pxmitpriv->txirp_cnt = 1; - pxmitpriv->ack_tx = false; mutex_init(&pxmitpriv->ack_tx_mutex); rtw_sctx_init(&pxmitpriv->ack_tx_ops, 0); diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h index 7e6cf745d913..50d9311d3e40 100644 --- a/drivers/staging/r8188eu/include/rtw_xmit.h +++ b/drivers/staging/r8188eu/include/rtw_xmit.h @@ -279,7 +279,6 @@ struct xmit_priv { u8 wmm_para_seq[4];/* sequence for wmm ac parameter strength * from large to small. it's value is 0->vo, * 1->vi, 2->be, 3->bk. */ - u8 txirp_cnt;/* */ struct tasklet_struct xmit_tasklet; struct __queue free_xmitbuf_queue; struct __queue pending_xmitbuf_queue;