From patchwork Sun Jan 8 09:48:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Schultz X-Patchwork-Id: 40485 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1638930wrt; Sun, 8 Jan 2023 01:52:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/OGdFUJQhP/sQlZdXUZbxNMsFnRHl2YMIhvh5oGv9ezPpwWhweA1YkHaFMyowF3m2KCqp X-Received: by 2002:a17:90a:f309:b0:225:c112:c871 with SMTP id ca9-20020a17090af30900b00225c112c871mr60902381pjb.12.1673171549811; Sun, 08 Jan 2023 01:52:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673171549; cv=none; d=google.com; s=arc-20160816; b=NRLgg0HGuoZGx1p/i+rSannkIR6orCAeutEdIfqs4cc6dRBL3hq/T8UOSa06D2IOtR 1ZMq1b1y61cK7nrXIYcYrGhlVsD7jmZYMkE4Kvdb9IlOwufB63v4pmjB+pGKmBLBhC9i 8t2DnwJdSYOBdHXpeeczgwwdzOy+IvL4cRN4onkEJ+XXBlt9I/SUfFQkXHQGca5P/4A1 gONbVWpt93EFnvuBhnNoNp4D72vAVK58/UeIVJUZpOOLiMReJrT7tvGi5W4VwFRxQZD3 gC/u2klJCauct7o4XeuP2qih4MBZJmLle5cJxkiAxWlXsyjvq2VuC1Vk+EazdfbaUtcD 3OOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=oGq6OXFvjRyvuRYGpXxmtrKV5gE2UHHEN7gbSY0FEEA=; b=H/EM9ve95jiQVFHaFiFMyPnXGPsjVa0Pbs0RecgK3uz9xjG0iWN/ZxZ+E8FbLbSOiq 5CO//Rd5O7KLJirw4ohtXbO2dTbxCpvfgUb2cyib4f9ArbUfVtYMyNnxxeKKsHNe9rn5 Pm4qYFwKPwYlvLF5xYxrvKmiwns8p3jm6ppVeLgFvKlS7c3fSgCdQiijWEKmrdHj36/I 1kYwj9S4ffIl5AL9xKdZx2VgNO8wdkF6tygTe7++zXbsbeX75FYA7b6MWR38q/nbUN3F +fUM5Rkm1tkS9dBfqByYPt75ALVusEbCjv3vbtWai74jPd1cx48kBctHvmNCxYZJB6MZ CHDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p20-20020a631e54000000b00478b57ca9e9si6723134pgm.537.2023.01.08.01.52.16; Sun, 08 Jan 2023 01:52:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232902AbjAHJuf (ORCPT + 99 others); Sun, 8 Jan 2023 04:50:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232841AbjAHJuc (ORCPT ); Sun, 8 Jan 2023 04:50:32 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFBD4183B3; Sun, 8 Jan 2023 01:50:29 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 3A1E318839BC; Sun, 8 Jan 2023 09:50:27 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 213EC250007B; Sun, 8 Jan 2023 09:50:27 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 16F399EC000B; Sun, 8 Jan 2023 09:50:27 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 Received: from fujitsu.vestervang (2-104-116-184-cable.dk.customer.tdc.net [2.104.116.184]) by smtp.gigahost.dk (Postfix) with ESMTPSA id AF71E91201E4; Sun, 8 Jan 2023 09:50:26 +0000 (UTC) From: "Hans J. Schultz" To: davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, "Hans J. Schultz" , Vladimir Oltean , Andrew Lunn , Florian Fainelli , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 net-next 1/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags Date: Sun, 8 Jan 2023 10:48:47 +0100 Message-Id: <20230108094849.1789162-2-netdev@kapio-technology.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230108094849.1789162-1-netdev@kapio-technology.com> References: <20230108094849.1789162-1-netdev@kapio-technology.com> MIME-Version: 1.0 Organization: Westermo Network Technologies AB X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754447531080615296?= X-GMAIL-MSGID: =?utf-8?q?1754447531080615296?= The default return value -EOPNOTSUPP of mv88e6xxx_port_bridge_flags() came from the return value of the DSA method port_egress_floods() in commit 4f85901f0063 ("net: dsa: mv88e6xxx: add support for bridge flags"), but the DSA API was changed in commit a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags"), resulting in the return value -EOPNOTSUPP not being valid anymore, and sections for new flags will not need to set the return value to zero on success, as with the new mab flag added in a following patch. Signed-off-by: Hans J. Schultz Reviewed-by: Vladimir Oltean --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 242b8b325504..29d4ff8e1181 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -6545,7 +6545,7 @@ static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port, struct netlink_ext_ack *extack) { struct mv88e6xxx_chip *chip = ds->priv; - int err = -EOPNOTSUPP; + int err = 0; mv88e6xxx_reg_lock(chip);