Message ID | 20230107144149.5743-1-klaus.kudielka@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1329240wrt; Sat, 7 Jan 2023 06:49:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXtyhtE65EJwWZcz1H3yAbJyWjFBmrT6OQj7r0N1l4BVY540tczc6FvV90zLiYhubQnLj0pI X-Received: by 2002:a05:6402:d78:b0:494:4fde:f501 with SMTP id ec56-20020a0564020d7800b004944fdef501mr7067391edb.25.1673102947793; Sat, 07 Jan 2023 06:49:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673102947; cv=none; d=google.com; s=arc-20160816; b=iTBpsuS1SIjo6WeKiKkc7CIsxyNPT0vTGMBgc7xcPU1S4Bi/3lNpsUKnw1vPey6PZF CD8Vqr9cmeOvygTr1POmid9aTed7hWOdjcYFyOExmEc+br3XfxgkXom/xgQ7UDawlov7 Y45OAdNQ4RpFaSJwiXlm8uJAhYUdbjhF8+FnfNUhvCrwKwJnHDJwq8A1GrmKKpYJ73+K grsTpYaEBNr5tzfk7ueLJspmG5pM5i5VG6ApaTyE26sUT/75Lgn/BNtSTmVd0J9C+Apt IrsJVaC0KDfbaTGdodkc3iNhCPdCkKjsvtGQwfsyfPqKpvMlNETsg2JznOksbIbru7ih VhlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=i3d+gOAD88oLabVtrIfzPXu7o2OZ8RNw65o7EHr8oIk=; b=og3mAa0NdZjjAOgm2vZXl9HZVYTclKE12OreqJTqWY/X3vG0VRU+P2tN8kujCjsQLC 2mHiuOYdCWmAYZkJ4L7Y6ZxDQJLTVcSzG7fIB8bVfxhp0PtPwxgDAq2VWVCkVNmxpNlG eJR07D+jyOMBEFgz7ZEB4vI+xQlC89ol3FyULaFsRwkCo/fywZPqxQGNJje+GHRhcoNF oEFkq9Y9LS4ONpCzHiBNIj4W9CYty4COgun+QFaoGq6Uk013phdpJKO1vqThanxAqx/b 7gWzs2pGLR+Ijjd54/av+vXPNhffDThwL2zyQ3RJq8mCCL1NXVVJEV/1WNVJLhcTr6gg z2iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PBWCnhEA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11-20020a056402084b00b0046721c5b7e0si5398694edz.511.2023.01.07.06.48.43; Sat, 07 Jan 2023 06:49:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PBWCnhEA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231615AbjAGOn3 (ORCPT <rfc822;dolce.eric@gmail.com> + 99 others); Sat, 7 Jan 2023 09:43:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231422AbjAGOn0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 7 Jan 2023 09:43:26 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2E5A58FAB; Sat, 7 Jan 2023 06:43:24 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id z8-20020a05600c220800b003d33b0bda11so5081662wml.0; Sat, 07 Jan 2023 06:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i3d+gOAD88oLabVtrIfzPXu7o2OZ8RNw65o7EHr8oIk=; b=PBWCnhEA0udMeH0tYHbUBalF84o9wZ5bM+etdc+3pGDNTYq5mI+4ECgwElxr7EHe4S cSY4QWGUJwJRUE/vuoEq9NEFfUqp6bIIu5bvwbPiOl+GCoDq6zuM7VQy1bRIiCzeqpSF 1szcdZgeInDIZMHVAYx3TQQv5vzcunM7SUjDbRc3SPPk2rAuYi4Dan0TXRPhcQYMac3Z z9dNnfVqRhxYal6wXMGjGokXlGDHWYFcv6bLlH+BFVGASL91bEfeuF7zVaUUQ/wcfAwV wAAi2nuCQCTpUqWJFDr9Uhz4pyX4UU63xUuzZlDhaPV2Uu2jTTnV4ZUJGtD0ANVwIif+ 7Gaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i3d+gOAD88oLabVtrIfzPXu7o2OZ8RNw65o7EHr8oIk=; b=ZuSKoezdMZ7bEgejKlKZvkAV8oKP80lErPLEcj5HniKNnq9GnvXrdDScU/HVI3RINH dliXBc0F/qI7dpsIEB6vyoIucnDtUBHKU1+ILcn/HVPi+xWPjglPrjsgeDyVaxRtDX9M lX802nme6Thf/2IYiHQi4gQ6PQ6q/g4ln/hZE9IBzdbCDcqcACbO/2ER6CV3syvN5bDI GpxQ+XGY0Rmrns9Uhdk8xD9bSPb2noRADI+yWF2it2mEiGh3LmxDWjthXAF1931bonfH l4OqaE4C+TQNmv/pHy+IyY4+q4irUHg3ZSrCy1vmWyrB2DAd5lvwH3CvuWoB/8MA+/+r Cykg== X-Gm-Message-State: AFqh2kq4go7exAzAJK5lzYIiZR+Aor4LqDrIPlBPrwjeeQ448aui7lz8 O7MxcLIMjE2tm534ageI+Xg= X-Received: by 2002:a1c:7410:0:b0:3cf:8957:806e with SMTP id p16-20020a1c7410000000b003cf8957806emr42935386wmc.5.1673102603226; Sat, 07 Jan 2023 06:43:23 -0800 (PST) Received: from mars.. ([2a02:168:6806:0:40f6:41b6:8914:e80b]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b003d9a86a13bfsm6056106wmq.28.2023.01.07.06.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 06:43:22 -0800 (PST) From: Klaus Kudielka <klaus.kudielka@gmail.com> To: "Andrew Lunn" <andrew@lunn.ch>, "Gregory Clement" <gregory.clement@bootlin.com>, "Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, =?utf-8?q?Pali_R?= =?utf-8?q?oh=C3=A1r?= <pali@kernel.org>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Chris Packham <chris.packham@alliedtelesis.co.nz>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Klaus Kudielka <klaus.kudielka@gmail.com> Subject: [PATCH v2 1/2] Revert "ARM: dts: armada-38x: Fix compatible string for gpios" Date: Sat, 7 Jan 2023 15:41:48 +0100 Message-Id: <20230107144149.5743-1-klaus.kudielka@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754375596466188717?= X-GMAIL-MSGID: =?utf-8?q?1754375596466188717?= |
Series |
[v2,1/2] Revert "ARM: dts: armada-38x: Fix compatible string for gpios"
|
|
Commit Message
Klaus Kudielka
Jan. 7, 2023, 2:41 p.m. UTC
This reverts commit c4de4667f15d04ef5920bacf41e514ec7d1ef03d, which causes
a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work,
ending up in the DSA switch being non-functional.
The blamed commit is incorrect in the first place:
If compatible = "marvell,armadaxp-gpio", the second (address, size) pair
of the reg property must to point to the per-CPU interrupt registers
<0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers
<0x181c0 0x08> / <0x181c8 0x08>.
But even fixing that leaves the GPIO interrupts broken on the Omnia.
Furthermore:
Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not
work reliably with per-CPU interrupts.
Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this
reason.
Fixes: c4de4667f15d ("ARM: dts: armada-38x: Fix compatible string for gpios")
Reported-by: Klaus Kudielka <klaus.kudielka@gmail.com>
Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@gmail.com/
Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com>
---
v1->v2: Be more explicit about the regression, and about the reg property.
arch/arm/boot/dts/armada-38x.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Sat, Jan 07, 2023 at 03:41:48PM +0100, Klaus Kudielka wrote: > This reverts commit c4de4667f15d04ef5920bacf41e514ec7d1ef03d, which causes > a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work, > ending up in the DSA switch being non-functional. > > The blamed commit is incorrect in the first place: > If compatible = "marvell,armadaxp-gpio", the second (address, size) pair > of the reg property must to point to the per-CPU interrupt registers > <0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers > <0x181c0 0x08> / <0x181c8 0x08>. > > But even fixing that leaves the GPIO interrupts broken on the Omnia. > > Furthermore: > Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not > work reliably with per-CPU interrupts. > Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this > reason. > > Fixes: c4de4667f15d ("ARM: dts: armada-38x: Fix compatible string for gpios") > Reported-by: Klaus Kudielka <klaus.kudielka@gmail.com> > Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@gmail.com/ > > Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com> Hi Klaus I was hoping Pali would comment, maybe fix it. But i think enough time has passed, we should accept your reverts. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Saturday 07 January 2023 18:18:24 Andrew Lunn wrote: > On Sat, Jan 07, 2023 at 03:41:48PM +0100, Klaus Kudielka wrote: > > This reverts commit c4de4667f15d04ef5920bacf41e514ec7d1ef03d, which causes > > a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work, > > ending up in the DSA switch being non-functional. > > > > The blamed commit is incorrect in the first place: > > If compatible = "marvell,armadaxp-gpio", the second (address, size) pair > > of the reg property must to point to the per-CPU interrupt registers > > <0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers > > <0x181c0 0x08> / <0x181c8 0x08>. > > > > But even fixing that leaves the GPIO interrupts broken on the Omnia. > > > > Furthermore: > > Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not > > work reliably with per-CPU interrupts. > > Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this > > reason. > > > > Fixes: c4de4667f15d ("ARM: dts: armada-38x: Fix compatible string for gpios") > > Reported-by: Klaus Kudielka <klaus.kudielka@gmail.com> > > Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@gmail.com/ > > > > Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com> > > Hi Klaus > > I was hoping Pali would comment, maybe fix it. But i think enough time > has passed, we should accept your reverts. Well, enough time for sure has not passed as I'm waiting for other reviews and comments for more than half of year, reminding them, and there is no input. So why should I react quickly in few days? And why should fix it? Just prepare another patch and wait another year until somebody notice it and merge it? I really do not have motivation here. I have already spent too much time on this stuff, sent lot of changes for which nobody cares. > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Andrew
diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi index 12933eff41..446861b6b1 100644 --- a/arch/arm/boot/dts/armada-38x.dtsi +++ b/arch/arm/boot/dts/armada-38x.dtsi @@ -304,7 +304,7 @@ spdif_pins: spdif-pins { }; gpio0: gpio@18100 { - compatible = "marvell,armadaxp-gpio", + compatible = "marvell,armada-370-gpio", "marvell,orion-gpio"; reg = <0x18100 0x40>, <0x181c0 0x08>; reg-names = "gpio", "pwm"; @@ -323,7 +323,7 @@ gpio0: gpio@18100 { }; gpio1: gpio@18140 { - compatible = "marvell,armadaxp-gpio", + compatible = "marvell,armada-370-gpio", "marvell,orion-gpio"; reg = <0x18140 0x40>, <0x181c8 0x08>; reg-names = "gpio", "pwm";