diff mbox series

[v2,2/3] dt-bindings: remoteproc: qcom,sm8150-pas: Add SM6375 CDSP

Message ID 20230107120623.1903056-2-konrad.dybcio@linaro.org
State New
Headers
Series [v2,1/3] dt-bindings: remoteproc: qcom,sm6350-pas: Add SM6375 ADSP |

Commit Message

Konrad Dybcio Jan. 7, 2023, 12:06 p.m. UTC 
  Add entries for SM6375 CDSP, as it's essentially identical to the one
on SM8150.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
- Rebase on top of recent changes, move to 8150 pas yaml

 .../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml        | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Jan. 7, 2023, 2:05 p.m. UTC | #1 
On 07/01/2023 13:06, Konrad Dybcio wrote:
> Add entries for SM6375 CDSP, as it's essentially identical to the one
> on SM8150.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> v1 -> v2:
> - Rebase on top of recent changes, move to 8150 pas yaml
> 
>  .../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> index b934252cf02b..082ae70a3fcb 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> @@ -16,6 +16,7 @@ description:
>  properties:
>    compatible:
>      enum:
> +      - qcom,sm6375-cdsp-pas
>        - qcom,sm8150-adsp-pas
>        - qcom,sm8150-cdsp-pas
>        - qcom,sm8150-mpss-pas

I don't think it is maintainable to keep sm6375 once here and once in
sm6350 file. If it does not fit one family, then probably it deserves
its own file.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
index b934252cf02b..082ae70a3fcb 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
@@ -16,6 +16,7 @@  description:
 properties:
   compatible:
     enum:
+      - qcom,sm6375-cdsp-pas
       - qcom,sm8150-adsp-pas
       - qcom,sm8150-cdsp-pas
       - qcom,sm8150-mpss-pas
@@ -51,6 +52,7 @@  allOf:
       properties:
         compatible:
           enum:
+            - qcom,sm6375-cdsp-pas
             - qcom,sm8150-adsp-pas
             - qcom,sm8150-cdsp-pas
             - qcom,sm8150-slpi-pas
@@ -74,6 +76,7 @@  allOf:
       properties:
         compatible:
           enum:
+            - qcom,sm6375-cdsp-pas
             - qcom,sm8150-adsp-pas
             - qcom,sm8150-cdsp-pas
             - qcom,sm8250-cdsp-pas