From patchwork Fri Jan 6 20:07:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Zhang X-Patchwork-Id: 40264 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1011054wrt; Fri, 6 Jan 2023 12:24:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXuGX5GVAAv+ocnEk7VnXJE5tOOtMwvL9lGnktGb1ku/GKZrojyyVNIZogPHu/IXlLcPrH0D X-Received: by 2002:a05:6402:26d5:b0:495:d3fb:a244 with SMTP id x21-20020a05640226d500b00495d3fba244mr5319537edd.3.1673036698755; Fri, 06 Jan 2023 12:24:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673036698; cv=none; d=google.com; s=arc-20160816; b=SDXVam96Yy9uBWmYD0h3ntpZX853I6G5kJ+NfgVDhNEyJiinmuuNnIGgc+L3rCyv+I uti/mMvytuvmj1N3ug3TUpRnIhY+/6sUU2/un3Y0Fh6mwtABM2qM4cFqlcIV/qOTeFTy I6S0yZ7f4uEXMKbUUsH1BDmAlpT6pHD1NFLNIIr636ljr/tuElYgkfMvxY4JMZibBltF x9wPOGiC74JXzN6K55LMPQ2w7sFpBc9Pg5ZdW4QTUW/A4TqpqSWAH8oZjM/+2aEZbPJW itWlRyGPAY4VSzXyQ3GWzsHfIe19LgHZs1U+YCuzuvNdf9PBKCmOg54AE9wxVicpdGzK JdVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=rO1bnHmghKKN88ytEnN24PPw9mEgSbgPWcKyj3A1PDI=; b=O4nH82Y5lWn/SxYco+4Kz51D3y+jfxemrGlsdokpDnGWXLQ3zDG7I2BzTeYIA3oNNJ G19nF4Nw3NY+mwtfVe2fW8/llmoquoSCqh0c2GufmKGWYMCCnjsfopnEAMiFXwrgjpxm D293ULzjZGeDcImeRru48se0b+lekAxaSuxbJflHF2tUsojP8NjhtFZdrKvksRNXWHEt +rWubb2V8OLo4OVYCoZ2E2QOgmBnjjOEfTTPTYH5KaElSO7L1NHq8JvPkENqIrEno7Vc gp8w0AAd3Nq420wrG2B5E7/mVCloGXHUxAYNdZk3oDRFpdBnMJCbPZlI1ioy+G7XHFG3 Soew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=ZjnHv1LE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a17-20020aa7d751000000b0047ed405b4a7si2282722eds.224.2023.01.06.12.24.34; Fri, 06 Jan 2023 12:24:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=ZjnHv1LE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229817AbjAFUVZ (ORCPT + 99 others); Fri, 6 Jan 2023 15:21:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235773AbjAFUUz (ORCPT ); Fri, 6 Jan 2023 15:20:55 -0500 Received: from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com [192.19.166.228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9345684620; Fri, 6 Jan 2023 12:19:53 -0800 (PST) Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.75.146.107]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id D5160C0000E2; Fri, 6 Jan 2023 12:09:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com D5160C0000E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1673035794; bh=SvLodN4cQ6TEbn+PEQP+YZBLKZOuvyU97FI3sOksrF0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZjnHv1LEV8rVFlAGo9JwQxczlOuvzW/ybD7ZQ4by8uCkQham3Dj2vxv8adXm/aLVF ENZVCXrYP9pkTLNTxH3GlqKsir4ma60M+VBn4CWpSe4Bm6nuQk7qSU1NU8I0sqscoS giOhM1c7Ok/bFO4wn5ohRe6WVDhV0HAbdSrurcl8= Received: from bcacpedev-irv-3.lvn.broadcom.net (bcacpedev-irv-3.lvn.broadcom.net [10.75.138.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPS id D32F618041CAC6; Fri, 6 Jan 2023 12:09:54 -0800 (PST) Received: by bcacpedev-irv-3.lvn.broadcom.net (Postfix, from userid 28376) id 2C07C101B33; Fri, 6 Jan 2023 12:09:48 -0800 (PST) From: William Zhang To: Linux SPI List , Broadcom Kernel List Cc: anand.gore@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, joel.peshkin@broadcom.com, f.fainelli@gmail.com, jonas.gorski@gmail.com, kursad.oney@broadcom.com, dregan@mail.com, William Zhang , Mark Brown , linux-kernel@vger.kernel.org Subject: [PATCH 06/16] spi: bcm63xx-hsspi: Endianness fix for ARM based SoC Date: Fri, 6 Jan 2023 12:07:58 -0800 Message-Id: <20230106200809.330769-7-william.zhang@broadcom.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20230106200809.330769-1-william.zhang@broadcom.com> References: <20230106200809.330769-1-william.zhang@broadcom.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754306129635774304?= X-GMAIL-MSGID: =?utf-8?q?1754306129635774304?= HSSPI controller uses big endian for the opcode in the message to the controller ping pong buffer. Use cpu_to_be16 to properly handle the endianness for both big and little endian host. Fixes: 142168eba9dc ("spi: bcm63xx-hsspi: add bcm63xx HSSPI driver") Signed-off-by: Kursad Oney Signed-off-by: William Zhang --- drivers/spi/spi-bcm63xx-hsspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c index b871fd810d80..63682c8ff955 100644 --- a/drivers/spi/spi-bcm63xx-hsspi.c +++ b/drivers/spi/spi-bcm63xx-hsspi.c @@ -194,7 +194,7 @@ static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t) tx += curr_step; } - __raw_writew(opcode | curr_step, bs->fifo); + __raw_writew(cpu_to_be16(opcode | curr_step), bs->fifo); /* enable interrupt */ __raw_writel(HSSPI_PINGx_CMD_DONE(0),