From patchwork Fri Jan 6 16:48:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Kitt X-Patchwork-Id: 40203 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp922831wrt; Fri, 6 Jan 2023 09:00:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXsLzm0czT2NRpaM2ykLqHJDyf4/JAVc5QgjDtDjHUwX5QJOv1br8k7kwU6IkAn23mAXTwXl X-Received: by 2002:a17:906:eda2:b0:7c0:cee0:2f55 with SMTP id sa2-20020a170906eda200b007c0cee02f55mr50248993ejb.28.1673024421640; Fri, 06 Jan 2023 09:00:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673024421; cv=none; d=google.com; s=arc-20160816; b=E3LvHkbaAntvlZQC3THPg1R8LnMnRsnMKkMmRsG8bSoT9/FymcbrOPCfc3OrEIp0Fw F2pO6qLSSMa29BmHDHsG+SKeVsaLE33W35yt76/ctHk4hZ0Qf8Pzv9aFxEh/h/7gtNvK +Dn2CkgNDrm9wDGg4CXD8QrNyetcrbb7HQWopJAksl3k6gKJ6dU28U/wuTrzFLCvDlyT 4HEb5MA3fQI53+D+UV5+iE5MLU90lWJWODrI8vDBn4urrScq2nDHSSBeea1x9Zk32t57 muv3Bp6l83Z/n5o6snd0/Z/iuMH2iLmQ07wCaB7ZcNMv1wntI6guLKLDXeO+UHq+zT0b aTnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=8u7YHe7l+BOEFV6VazqEy5E870w7Bqa7fqDPDtu4vvU=; b=a4HbG3kWYM9rNwYeexE10mS7AwbQKoVyip9f+uAx7cA+NKFQLOPz89pi1+3CN2vkV3 yC+Inc0tF7U7HgQoEHJ2FN7m/UO7P+Yff7RqsRo5HmjB/LC7JSGG3JSh8jKAnVbHlSzo n8wCfcHOks5xAYfNssiSsjWZqrCby1p9m4E91fO1qMWXsST8Fn8jONraqalCjAxIHDMT jfgw7gbdC0fU0MVHN/c1pbFH6W1cxZzxLOuQTQip2AmhXyvfUIWyX9xhMiyGWB+E2C30 Z0fBkuXaSSOQ6EsBZ+EgW59l2JMlTQyU/rHwxzUevXrQgucxsT0RPWcR2CnaPqB5cAfB mOhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc18-20020a1709078a1200b007acbac0871csi1892014ejc.420.2023.01.06.08.59.56; Fri, 06 Jan 2023 09:00:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234279AbjAFQ5S (ORCPT + 99 others); Fri, 6 Jan 2023 11:57:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233967AbjAFQ5Q (ORCPT ); Fri, 6 Jan 2023 11:57:16 -0500 X-Greylist: delayed 7777 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 06 Jan 2023 08:57:14 PST Received: from 7.mo575.mail-out.ovh.net (7.mo575.mail-out.ovh.net [46.105.63.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E510B7A38F for ; Fri, 6 Jan 2023 08:57:14 -0800 (PST) Received: from director9.ghost.mail-out.ovh.net (unknown [10.108.20.16]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id D0A07259FB for ; Fri, 6 Jan 2023 16:50:00 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-dkv5l (unknown [10.110.171.46]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 130501FEBF; Fri, 6 Jan 2023 16:50:00 +0000 (UTC) Received: from sk2.org ([37.59.142.107]) by ghost-submission-6684bf9d7b-dkv5l with ESMTPSA id 6P5cAjhRuGOnAQEAwhnnFg (envelope-from ); Fri, 06 Jan 2023 16:50:00 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S0011a1aef4d-84f6-4e9b-be06-f9755663a738, 9FE29456621203A27B372E1E0503D45BE0167874) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 From: Stephen Kitt To: Lee Jones , Daniel Thompson , Jingoo Han Cc: Sam Ravnborg , Stephen Kitt , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Date: Fri, 6 Jan 2023 17:48:54 +0100 Message-Id: <20230106164856.1453819-4-steve@sk2.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Ovh-Tracer-Id: 5852427716709222107 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedtgdelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeelgeetueejffejfeejvefhtddufeejgfetleegtddukeelieelvddvteduveejtdenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehsthgvvhgvsehskhdvrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheejhedpmhhouggvpehsmhhtphhouhht X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754293255842931328?= X-GMAIL-MSGID: =?utf-8?q?1754293255842931328?= Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt Reviewed-by: Sam Ravnborg Reviewed-by: Daniel Thompson --- drivers/video/backlight/ipaq_micro_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c index 85b16cc82878..f595b8c8cbb2 100644 --- a/drivers/video/backlight/ipaq_micro_bl.c +++ b/drivers/video/backlight/ipaq_micro_bl.c @@ -16,17 +16,12 @@ static int micro_bl_update_status(struct backlight_device *bd) { struct ipaq_micro *micro = dev_get_drvdata(&bd->dev); - int intensity = bd->props.brightness; + int intensity = backlight_get_brightness(bd); struct ipaq_micro_msg msg = { .id = MSG_BACKLIGHT, .tx_len = 3, }; - if (bd->props.power != FB_BLANK_UNBLANK) - intensity = 0; - if (bd->props.state & (BL_CORE_FBBLANK | BL_CORE_SUSPENDED)) - intensity = 0; - /* * Message format: * Byte 0: backlight instance (usually 1)