From patchwork Fri Jan 6 16:05:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Schultz X-Patchwork-Id: 40186 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp900170wrt; Fri, 6 Jan 2023 08:08:46 -0800 (PST) X-Google-Smtp-Source: AMrXdXv4T7235tmrF48/Ssts03NEFwIMhbq/uVSACLenRgrhnwuLmckoeVfWrd5uF6cqc+SyGOgw X-Received: by 2002:a17:906:2ccc:b0:7c0:e23d:12c4 with SMTP id r12-20020a1709062ccc00b007c0e23d12c4mr43092498ejr.63.1673021325872; Fri, 06 Jan 2023 08:08:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673021325; cv=none; d=google.com; s=arc-20160816; b=Ee/gdy4+l60pDbceFRqsaQmzjjPpInWmdcezwtM4TD85jyjatZdILVWZ3415FvNg3S 2IZzqM4rUFeMqj0bsnsPiaRbocSN2wGnj3dJvm38jitlpfeINlaKxbGExzslBPkxsg+2 bVL6d6rNrM5OzOgMntvc9rHET5V/sbFhwMjrCDxfSNp5PJSwtreHPsqvltvK8WSX1C/4 I+RyoP/wU4bUHjQZZMeII8a38xbIcLsCNXkl9fTJVOfEVK+M08xpwZwtyuE3SmtdSeQ4 /lQSAEuIna6/kCiTAkGpoFULr8QGgZ3ELVa7P4DjANw2OqbD1Dv2RjTNXAbBjJaIGeFX 0N1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=s89Ns5oJxHVrxnKHlTdugN5rRZQgbhHf6jZVr2xAK4U=; b=Kyd868Wt5IELfaNNo4+gr4ucwqJL+isJ01ClMFcRv+GFROTlB9NQaRRzDjwsjgET2M /9tw1NQLGsePqafyt7hr6gjKyUWCVjbjSa3ZQjLU1d73tr4iM+yGdhD2o6nGEpUOfPwm i3kf0GuizE/2VnHwXOt0pPmB4+aWudLmczLM/JqQJJCmIm45+2MlZxk7w4URuCtbateH vRUMd2j99Y+vyMN+80pE80oJdPdBImAPnWMzIJ1A+o97B6HF0l2F735JvyomuhusXd+P TyasT2CK+n0CAFWqAIIyEztDqHsxp3x8ODSCM5L9c9zO+3lGr0SoRV9DxscyqKiPkapr h3JQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp39-20020a1709073e2700b0083b22b31cc2si1356851ejc.370.2023.01.06.08.08.21; Fri, 06 Jan 2023 08:08:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234754AbjAFQH3 (ORCPT + 99 others); Fri, 6 Jan 2023 11:07:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbjAFQHR (ORCPT ); Fri, 6 Jan 2023 11:07:17 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36CD6398; Fri, 6 Jan 2023 08:07:14 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 99BB2188467E; Fri, 6 Jan 2023 16:07:11 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 86BFA2503B65; Fri, 6 Jan 2023 16:07:11 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 81BF291201E4; Fri, 6 Jan 2023 16:07:11 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 Received: from fujitsu.vestervang (2-104-116-184-cable.dk.customer.tdc.net [2.104.116.184]) by smtp.gigahost.dk (Postfix) with ESMTPSA id 2C6D09EC000C; Fri, 6 Jan 2023 16:07:11 +0000 (UTC) From: "Hans J. Schultz" To: davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, "Hans J. Schultz" , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 net-next 1/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags Date: Fri, 6 Jan 2023 17:05:27 +0100 Message-Id: <20230106160529.1668452-2-netdev@kapio-technology.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230106160529.1668452-1-netdev@kapio-technology.com> References: <20230106160529.1668452-1-netdev@kapio-technology.com> MIME-Version: 1.0 Organization: Westermo Network Technologies AB X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754290009870763205?= X-GMAIL-MSGID: =?utf-8?q?1754290009870763205?= The default return value -EOPNOTSUPP of mv88e6xxx_port_bridge_flags() came from the return value of the DSA method port_egress_floods() in commit 4f85901f0063 ("net: dsa: mv88e6xxx: add support for bridge flags"), but the DSA API was changed in commit a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags"), resulting in the return value -EOPNOTSUPP not being valid anymore, and sections for new flags will not need to set the return value to zero on success, as with the new mab flag added in a following patch. Signed-off-by: Hans J. Schultz Reviewed-by: Vladimir Oltean --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 242b8b325504..29d4ff8e1181 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -6545,7 +6545,7 @@ static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port, struct netlink_ext_ack *extack) { struct mv88e6xxx_chip *chip = ds->priv; - int err = -EOPNOTSUPP; + int err = 0; mv88e6xxx_reg_lock(chip);