From patchwork Fri Jan 6 12:10:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MD Danish Anwar X-Patchwork-Id: 40105 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp788946wrt; Fri, 6 Jan 2023 04:13:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXviw8kNhjW+LDU6z1TvzxjlJUUuTzIX/4yfRLS0PTj+0D3Sb0zpxQDNy6N+S6F2dZF/u7Th X-Received: by 2002:a05:6a21:3294:b0:9d:efbe:a122 with SMTP id yt20-20020a056a21329400b0009defbea122mr84685364pzb.50.1673007200328; Fri, 06 Jan 2023 04:13:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673007200; cv=none; d=google.com; s=arc-20160816; b=aa5SbAuXYtuDIuQr5sSq+xnBWa4EyI4Qr/9Z3Ug3j/7rlJwfdPrJ2zRUHvejsB4mJ8 ybXlOB4X3Pf1pLbPveeBYPdtQITg8+CTqOQUJ3i3ktE/Y3Vs9wUf0js+R1qpNS3LVr7n +LBgcLHQlmayn6fO4d6ZzhbKZUxqrte8dp6kl0tL6kWYJdasj4qsKniyE/R3dnXNigDZ 3WuYAU4h5mARZ2fTawBRW8LKp0GcZh9uw7HoiqGV7dZHRlEBFZVwBtqYmsbgzah9k7hp gWE4u4+4B1MZslOy4nrrmIDoBN2M5I6d61g7qBlpDePesR1E+mW/lgCJCPK919fN0WsM 0v0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nfQx8l/CZDGe5fseL6BugjP9ZU7esGK81kOQzHFYf38=; b=fQqMpbFZzncF6KiHTMFWccRKjTWpQFeArWFX9b0mXE9HZHNcTrabzRg7zhROXuAbVC WQMbRQopPF7n2K9Tbfrj10nAeklHhQksNYYHZoewHdSrZfq/aFYVV+SqILqPQ7o3vzLn 8LCHVH8LQUqHRC+zYM2BBPreEW6MbzOezdW1lM5UHU7H+jBjHJjPhPV+RM7R5UbuS8bc 0ThsaqLq6w8uJ1Mtfv07Skv1UHCLhS71qJvzmgYP9bVqZlBEhv4Ra00Xu5aa40pOgAZa 18PpIml8eDgz86FD4kXvTJ0hRqjvl0goRBvQ+MRBMKhbjD5RvNqJAgjYEsXnAbx459qp 3f8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=a7J36rxN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 142-20020a630394000000b004774a855372si1275642pgd.694.2023.01.06.04.13.07; Fri, 06 Jan 2023 04:13:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=a7J36rxN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233697AbjAFMLe (ORCPT + 99 others); Fri, 6 Jan 2023 07:11:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232784AbjAFMLO (ORCPT ); Fri, 6 Jan 2023 07:11:14 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DF2D736C8; Fri, 6 Jan 2023 04:11:11 -0800 (PST) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 306CAxZA099602; Fri, 6 Jan 2023 06:10:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1673007059; bh=nfQx8l/CZDGe5fseL6BugjP9ZU7esGK81kOQzHFYf38=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=a7J36rxNaTJI26FNNhvWQ3q78sm+erReqsTUBNDBdKQd7DO+Aq9blEwpIQHPpk30K JJ4ICFIU29sY3v45/1BtciLu7IZajQXOyhIIyZGbdW7f6q7YjJ0agmVHrGRfkBuKvC Qfwk/jREjFz7vXCgjvze/BXXz3D8nx3texGU47OE= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 306CAx8I089056 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Jan 2023 06:10:59 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 6 Jan 2023 06:10:58 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 6 Jan 2023 06:10:58 -0600 Received: from fllv0122.itg.ti.com (fllv0122.itg.ti.com [10.247.120.72]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 306CAwGP097078; Fri, 6 Jan 2023 06:10:58 -0600 Received: from localhost (a0501179-pc.dhcp.ti.com [10.24.69.114]) by fllv0122.itg.ti.com (8.14.7/8.14.7) with ESMTP id 306CAvmj028616; Fri, 6 Jan 2023 06:10:58 -0600 From: MD Danish Anwar To: Mathieu Poirier , Krzysztof Kozlowski , Rob Herring CC: Suman Anna , Roger Quadros , "Andrew F . Davis" , , , , , , , , MD Danish Anwar Subject: [PATCH v14 4/6] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots Date: Fri, 6 Jan 2023 17:40:44 +0530 Message-ID: <20230106121046.886863-5-danishanwar@ti.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230106121046.886863-1-danishanwar@ti.com> References: <20230106121046.886863-1-danishanwar@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754275198217937129?= X-GMAIL-MSGID: =?utf-8?q?1754275198217937129?= From: Suman Anna The PRU remoteproc driver is not configured for 'auto-boot' by default, and allows to be booted either by in-kernel PRU client drivers or by userspace using the generic remoteproc sysfs interfaces. The sysfs interfaces should not be permitted to change the remoteproc firmwares or states when a PRU is being managed by an in-kernel client driver. Use the newly introduced remoteproc generic 'sysfs_read_only' flag to provide these restrictions by setting and clearing it appropriately during the PRU acquire and release steps. Signed-off-by: Suman Anna Signed-off-by: Grzegorz Jaszczyk Signed-off-by: MD Danish Anwar Reviewed-by: Roger Quadros --- drivers/remoteproc/pru_rproc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c index 1036bfd446b6..c16242e2d435 100644 --- a/drivers/remoteproc/pru_rproc.c +++ b/drivers/remoteproc/pru_rproc.c @@ -223,6 +223,7 @@ struct rproc *pru_rproc_get(struct device_node *np, int index, } pru->client_np = np; + rproc->sysfs_read_only = true; mutex_unlock(&pru->lock); @@ -261,6 +262,7 @@ void pru_rproc_put(struct rproc *rproc) } pru->client_np = NULL; + rproc->sysfs_read_only = false; mutex_unlock(&pru->lock); rproc_put(rproc);