From patchwork Fri Jan 6 01:12:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 39864 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp577045wrt; Thu, 5 Jan 2023 17:16:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXtcz8tXDGUQTCkrAYIlVcJGgV591OaNY+7vB1T19amiqVz10RVq3sUH+ofpHYZRaU5Dle65 X-Received: by 2002:a05:6402:2890:b0:47e:eaae:9a56 with SMTP id eg16-20020a056402289000b0047eeaae9a56mr54094984edb.5.1672967774732; Thu, 05 Jan 2023 17:16:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672967774; cv=none; d=google.com; s=arc-20160816; b=FGCKzT/oWOZABgJ0lS6uZ9rha2tzQCs98s2CgOYd1YCZXufBsaqFLgZwrOboc+u7V6 ysFiDKxxI/25a31v8lj+v/eAjD1/pYvbNnhC/Or1Mw2DQ9YWjGSAKilljeSwjjg0ej+f dyVy1keorJPtyEhg90tgas2HhG/wKEPRQRCkGkPXQNIVnO2CVFC22ACz7Ei2zRy2XpQy JgtezGUfffjrMl0PCbv6/xJ0Yaefd8dxpkeoUm7q3AFpGoOCkFsJFu8vnI1e7kJHxMon C/SrDNg5nurgqMfDqvZWOEGl8vmNrgYQbHQzznU240dfKe/MR1TxqUx746rv+o0lJY8C xpXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=CYYJmfZ9mNFDGGWa3J2yKpONItWzTZPphAVz+Kbcn3U=; b=CmvLWruIDjUtDbQx6UWoSZoidJMdlvUl+KebV5OkZ/WXYhEmZIdHuGMmIE5x5Yl13D G9J8NhEQu3UFin1fak5fHDta1TXBi5v48K/TZUtBdOamfVwhjLBN12GXrAM88c33TOaY FzvEbYHsW72pnRgna779FJEE09NLpZu+SQdw0y6iL+gqUMLslWu+CMhA2AU1gCYMrJ15 UJnlvSC4xFJQA7TcjExjWLg7jNecQuoC8GWyn+3ED5GTOm0k5JoF2DkSX/riiy8u0RGU YExjgEgxxdfggliYqiDV3f3mFFqr8fPhQsNQiA/ZvZ7g7xXFuc5oTWpaorT8vv07zvgF jAzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=KX8XYL9r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j19-20020a05640211d300b004700047ef96si41686196edw.289.2023.01.05.17.15.50; Thu, 05 Jan 2023 17:16:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=KX8XYL9r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236685AbjAFBNx (ORCPT + 99 others); Thu, 5 Jan 2023 20:13:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236762AbjAFBNX (ORCPT ); Thu, 5 Jan 2023 20:13:23 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A80271FC2 for ; Thu, 5 Jan 2023 17:13:22 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id a11-20020a17090acb8b00b00226d4edae5dso50530pju.2 for ; Thu, 05 Jan 2023 17:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=CYYJmfZ9mNFDGGWa3J2yKpONItWzTZPphAVz+Kbcn3U=; b=KX8XYL9rvgWNlKIscy8mzK0MqUP7L1Eptt11dNZ8Y2gjLSZ2roViegLOvfCmQkXRpm tml1DSPvp1xePvkNESZNRVZ+J0GMlShsFDneY4BlLYyDCUG7XQ5iL1F274CUEEJ1tgKa V8Bmg8gNqLoK/+hlNaN6q/SnxniCnTNq0p+Jzh4HM0ZtHbTvl0U7KvUjA+LpZaAMvbN9 KL/0k8zHeUTiHCcLolVAs7suPaPLUxTiylIKf+h45lufC9nHXuCUKBe9dKVFeUb2gCMK /5yjguwvs7UF6e3mk61i5V/mB5cMIaUnGPfbiZ0dtfjJbOjkt38R2pXpIRo8BAsY9uSA Pe5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CYYJmfZ9mNFDGGWa3J2yKpONItWzTZPphAVz+Kbcn3U=; b=miVRCUfDAEXE5Wu7IyRwZGHJGBh3f37opFJzp40W/4N3ZH9+CHDPvk9fdakyE/d01f D8CVU4HlFfIwwaqCpVjUUm1KDpk9TZfaUizmfpDTcVsG5Qa52r8s4TkGHQe83clSSa1A P5dTNaooPvnOnOsSKP321IQIbfu3pvTYoa4ms9rpKAkizL8qB3dfhNDQl0LXGqUIZYmB ywJJD7e8ukMa3/6YG7xKnXkZmRgxzPH5ZoKem3SHAHCUSqe15gLCcLDiQNiQ+xMHiuCH Kg58YcIQ21JAdmHhApgdf1zxNNMkDw76w0zxWjuiJRoPB/lL0hn6WUwgjI8YEPUYWtH1 NHkw== X-Gm-Message-State: AFqh2krmCYt0ma6DliLROj8+uPSzDIkvuYI7mRbwCH979KK+ZuvVtyzD XJI/UudbyrF4nr9AhUQhT0rlHUTbXPU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:b207:b0:189:5ba2:4907 with SMTP id t7-20020a170902b20700b001895ba24907mr3964708plr.113.1672967602066; Thu, 05 Jan 2023 17:13:22 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 6 Jan 2023 01:12:37 +0000 In-Reply-To: <20230106011306.85230-1-seanjc@google.com> Mime-Version: 1.0 References: <20230106011306.85230-1-seanjc@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230106011306.85230-5-seanjc@google.com> Subject: [PATCH v5 04/33] KVM: SVM: Process ICR on AVIC IPI delivery failure due to invalid target From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alejandro Jimenez , Maxim Levitsky , Suravee Suthikulpanit , Li RongQing , Greg Edwards X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754233857250923867?= X-GMAIL-MSGID: =?utf-8?q?1754233857250923867?= Emulate ICR writes on AVIC IPI failures due to invalid targets using the same logic as failures due to invalid types. AVIC acceleration fails if _any_ of the targets are invalid, and crucially VM-Exits before sending IPIs to targets that _are_ valid. In logical mode, the destination is a bitmap, i.e. a single IPI can target multiple logical IDs. Doing nothing causes KVM to drop IPIs if at least one target is valid and at least one target is invalid. Fixes: 18f40c53e10f ("svm: Add VMEXIT handlers for AVIC") Cc: stable@vger.kernel.org Reviewed-by: Paolo Bonzini Reviewed-by: Maxim Levitsky Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/avic.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index 712330b80891..3b2c88b168ba 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -502,14 +502,18 @@ int avic_incomplete_ipi_interception(struct kvm_vcpu *vcpu) trace_kvm_avic_incomplete_ipi(vcpu->vcpu_id, icrh, icrl, id, index); switch (id) { + case AVIC_IPI_FAILURE_INVALID_TARGET: case AVIC_IPI_FAILURE_INVALID_INT_TYPE: /* * Emulate IPIs that are not handled by AVIC hardware, which - * only virtualizes Fixed, Edge-Triggered INTRs. The exit is - * a trap, e.g. ICR holds the correct value and RIP has been - * advanced, KVM is responsible only for emulating the IPI. - * Sadly, hardware may sometimes leave the BUSY flag set, in - * which case KVM needs to emulate the ICR write as well in + * only virtualizes Fixed, Edge-Triggered INTRs, and falls over + * if _any_ targets are invalid, e.g. if the logical mode mask + * is a superset of running vCPUs. + * + * The exit is a trap, e.g. ICR holds the correct value and RIP + * has been advanced, KVM is responsible only for emulating the + * IPI. Sadly, hardware may sometimes leave the BUSY flag set, + * in which case KVM needs to emulate the ICR write as well in * order to clear the BUSY flag. */ if (icrl & APIC_ICR_BUSY) @@ -525,8 +529,6 @@ int avic_incomplete_ipi_interception(struct kvm_vcpu *vcpu) */ avic_kick_target_vcpus(vcpu->kvm, apic, icrl, icrh, index); break; - case AVIC_IPI_FAILURE_INVALID_TARGET: - break; case AVIC_IPI_FAILURE_INVALID_BACKING_PAGE: WARN_ONCE(1, "Invalid backing page\n"); break;