From patchwork Fri Jan 6 01:13:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 39886 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp578381wrt; Thu, 5 Jan 2023 17:19:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXvSCf1BpbCc3lj6VsGhOfHIHXG2mmS0FKA02jQGyO/o1ZKlcvxrmsY13MJ1WI8+oKajztAV X-Received: by 2002:a05:6402:2146:b0:46c:7035:2f6d with SMTP id bq6-20020a056402214600b0046c70352f6dmr49158940edb.38.1672967997358; Thu, 05 Jan 2023 17:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672967997; cv=none; d=google.com; s=arc-20160816; b=t5pBHjVklDMdnok4AOHSkIOWj2gPxFGTv0r+sqdg7dbzGDGn4DtQkuwIpkR/X4BnfG w4jVXzG91CH0ZSOVCKfkYt6eE1XIfVb4t//Hec3xloFnXccQdnlYn2DQ/sqekkc1MgRo mhItNDBzgaDTDTn9PvCZ7ueK2rT9iFirrP+375ba1WKnVgxWTAKDyGG6DTlL/poID0/w 6Wqdl7cH3xpMjZRdMguNYmamP2AYCrm+HW3dQ+Kl9Xpx387pjoQJeeFJOk9s26ZyX1qd LrI0ul2v2z3uNLx0xdZLQbMbzV7Z2kNoCbeVLzmt8ivvE0t2SLQHUydts9MWpWmPilwf Wugg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=0PXIy8RA30k82n5MqadBULMYpw3jcQQNxAI0MLkfm2o=; b=SpeFxUtYWeObmiKyD/p3r2LQI4HCMXN7wa/qbdNSKwHa8U5imcZ5zMzifbKbRL0q59 SSOqJS/NZqjGOncYZPe72qUlJrKsQKEm/k8cOk0PkHE2ARzr2b1FLcE8L8RQxviOxYXx qCQ5pjQIySesnyrN7o9r6YTTaWIf1BN9TMbA/XgGSNOxqvhOor7uePR0ZEZXL5YSd14m 99eLP1kNTrMVUVP7WhEVM+JkCzdqXHPRWaVgqcky8qqw+8bURITSUA2o30muvWc2EBpE kNqZ64vo8ia4B6y4zudXNHxVbdwXliREAf3N/CUw1WfNXqMfhBw0i9m6ybDX+/T32JNu 3GYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ARYzhqPu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd12-20020a1709069b8c00b0082b7e633997si38506012ejc.434.2023.01.05.17.19.33; Thu, 05 Jan 2023 17:19:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ARYzhqPu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233812AbjAFBRa (ORCPT + 99 others); Thu, 5 Jan 2023 20:17:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232814AbjAFBQa (ORCPT ); Thu, 5 Jan 2023 20:16:30 -0500 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF8C765AF2 for ; Thu, 5 Jan 2023 17:14:22 -0800 (PST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-47ede4426e1so3120787b3.7 for ; Thu, 05 Jan 2023 17:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=0PXIy8RA30k82n5MqadBULMYpw3jcQQNxAI0MLkfm2o=; b=ARYzhqPubKAcUMlq5dSBX0xvRbkdMD3Z7If0ag7prbjxIne2GkJ8lAhHrtaEOpMtq7 wIIAhYz1/Ajx9d5Cslo0C4NAiwSy8WApA2ndyhaXFs6IngyBWHUw8/RvgrKmAvHUhpkO cyOgu6KCI3mBFPHHb5Py5lPdjDvIYKL4PgTbXDJoeb9G5AmvTkBPp7JhJ96D5XJeOmNF H71WGUwe4Z9AK+ykt/tiEyDRK2He33wLTdGnjX2xFBC78IVPGeo7k2WIXLG0DcCUuoTc xxOGpURmrBMBR/Kj4dorDzcHumIWTMXaSANO4lHr0MkNbDkcual08RTxiy0tgP3OCVKT 4hUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0PXIy8RA30k82n5MqadBULMYpw3jcQQNxAI0MLkfm2o=; b=vCoZhtwVQpHeNmymXkVIXtq6YTrS0tyIqlCkjrrekGFFl53Rtoo3B1N/KlycD2Fb0R inpI0m8i+kQw3MpObC4qQyIMz2Z1tIy5TpDvlq3RBl+ADVXQmmDIiVydzl5NpJSIcYC1 KeAmaW4VC+/MBpGuaoiM95H5IKgLGj1zOP++vrXLeqgbJhFR6fPUlX+Ku/6+lBFYxgXJ lm1U0x90ROO8J+IgZqj0aVpHo+R5ap1QOr2Fq2ed15qFZn3/3KusB1PYZzfi5PfxHEzZ OXmZ/wkJ3LIbGCIAf0kUFXzDbFERG2DswQ3sXIj4uNgRUFyi+AnO+DCh80zn/CXdCOIR SP2w== X-Gm-Message-State: AFqh2kr8f4nPYGfjD/IgnOS9KPZ1FxuK/9XcxtQj0dhPoWcoF2mw21WL W3J3z0QJhvMYIQEO6Q0U3DrYEUr0Zo8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:d095:0:b0:7b6:daae:ad50 with SMTP id h143-20020a25d095000000b007b6daaead50mr235713ybg.89.1672967643231; Thu, 05 Jan 2023 17:14:03 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 6 Jan 2023 01:13:02 +0000 In-Reply-To: <20230106011306.85230-1-seanjc@google.com> Mime-Version: 1.0 References: <20230106011306.85230-1-seanjc@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230106011306.85230-30-seanjc@google.com> Subject: [PATCH v5 29/33] KVM: SVM: Ignore writes to Remote Read Data on AVIC write traps From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alejandro Jimenez , Maxim Levitsky , Suravee Suthikulpanit , Li RongQing , Greg Edwards X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754234090761218022?= X-GMAIL-MSGID: =?utf-8?q?1754234090761218022?= Drop writes to APIC_RRR, a.k.a. Remote Read Data Register, on AVIC unaccelerated write traps. The register is read-only and isn't emulated by KVM. Sending the register through kvm_apic_write_nodecode() will result in screaming when x2APIC is enabled due to the unexpected failure to retrieve the MSR (KVM expects that only "legal" accesses will trap). Fixes: 4d1d7942e36a ("KVM: SVM: Introduce logic to (de)activate x2AVIC mode") Signed-off-by: Sean Christopherson Reviewed-by: Maxim Levitsky --- arch/x86/kvm/svm/avic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index 2c6737f72bd4..ff08732469cb 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -628,6 +628,9 @@ static int avic_unaccel_trap_write(struct kvm_vcpu *vcpu) case APIC_DFR: avic_handle_dfr_update(vcpu); break; + case APIC_RRR: + /* Ignore writes to Read Remote Data, it's read-only. */ + return 1; default: break; }