diff mbox series

[1/3] dt-bindings: nvmem: u-boot,env: add MAC's #nvmem-cell-cells

Message ID 20230105171038.13649-1-zajec5@gmail.com
State New
Headers
Series [1/3] dt-bindings: nvmem: u-boot,env: add MAC's #nvmem-cell-cells |

Commit Message

Rafał Miłecki Jan. 5, 2023, 5:10 p.m. UTC 
  From: Rafał Miłecki <rafal@milecki.pl>

U-Boot's "ethaddr" environment variable is very often used to store
*base* MAC address. It's used as a base for calculating addresses for
multiple interfaces. It's done by adding proper values. Actual offsets
are picked by manufacturers and vary across devices.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Rob Herring Jan. 8, 2023, 10:17 p.m. UTC | #1 
On Thu, Jan 05, 2023 at 06:10:36PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> U-Boot's "ethaddr" environment variable is very often used to store
> *base* MAC address. It's used as a base for calculating addresses for
> multiple interfaces. It's done by adding proper values. Actual offsets
> are picked by manufacturers and vary across devices.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
> index cbc5c69fd405..1c139bd689ea 100644
> --- a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
> @@ -50,7 +50,11 @@ properties:
>  
>    ethaddr:
>      type: object
> -    description: Ethernet interface's MAC address
> +    description:
> +      Ethernet interfaces base MAC address. The first argument is an offset.

The 2nd sentence belongs in the '#nvmem-cell-cells' description.

> +    properties:
> +      "#nvmem-cell-cells":
> +        const: 1
>  
>  additionalProperties: false
>  
> @@ -72,6 +76,7 @@ examples:
>              reg = <0x40000 0x10000>;
>  
>              mac: ethaddr {
> +                #nvmem-cell-cells = <1>;
>              };
>          };
>      };
> -- 
> 2.34.1
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
index cbc5c69fd405..1c139bd689ea 100644
--- a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
+++ b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
@@ -50,7 +50,11 @@  properties:
 
   ethaddr:
     type: object
-    description: Ethernet interface's MAC address
+    description:
+      Ethernet interfaces base MAC address. The first argument is an offset.
+    properties:
+      "#nvmem-cell-cells":
+        const: 1
 
 additionalProperties: false
 
@@ -72,6 +76,7 @@  examples:
             reg = <0x40000 0x10000>;
 
             mac: ethaddr {
+                #nvmem-cell-cells = <1>;
             };
         };
     };