From patchwork Thu Jan 5 14:51:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kajetan Puchalski X-Patchwork-Id: 39637 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp337817wrt; Thu, 5 Jan 2023 06:54:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXuFABixtO5kj9TE7g+Yi3N2C3HWwAcvwnAfddqKZDtnexvnp2T8XPw62r6i7GZf3JsDs9Oz X-Received: by 2002:a50:cc4c:0:b0:479:8313:2fdd with SMTP id n12-20020a50cc4c000000b0047983132fddmr47327851edi.10.1672930461289; Thu, 05 Jan 2023 06:54:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672930461; cv=none; d=google.com; s=arc-20160816; b=Q03hFVzwja8G9CBwnrJIRe0gYq3k3RMNgapIrqxtEhqFL/4MU6A0J4+avmo1IY08Ix ZAwsvG8eEZGrgj/e0cj8pSe9pZiORfpq2qwP1faMXu0Rc0VdZ8sTbsZzWD8/fRHJRBwc jn9C5urgwO27aZ1mqseVWiaXBQfIEWtM9deCmtie26f3IvHFEzdneMNQZ+DdVZg16D3i Gvj9dvwbd6xS8unDHFKaEnES8fe7pz7Dhxv83AYCU8WFTv8Zg/Y5Ser5RUvIsfv5byWA 43FIVJMA5FHR2nvYBa7Y9naK9YuFDTyXXVcl4/btVn31FfT5FkcMAe+B4YvutJyLTsYk /kWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=anVv06K4voEx8glJ2FPNjL9SygdM/whii5BW5GdM7ks=; b=l8n3tXpYBvkj/DGsDYxbNPfqpY2xbrytNteiTuhOjg7JECHGu95v0GlI4mXRzqL084 yi7qV2S8NVKkHiLskySE5h8TU96vD7Htamq1BtSTu4Y/qrbYKCgUpst9JFJ7yGW9oxxz 6F5PsZ2RR+zaAzhaDK5JPFIZgqlPwws6kQDG+Q7B0hXvbj4l4xyKvAfCxTtOuPpqPh5B iBljEXh2voOFn+xtJbQ27wKcXcWQWKYcsQpGdGmduSb8EUlpz/GlWjESVG3DVxz4YY+y uHM/XAaFUl7QSO19SDFq5+Df+no/BoxpBEb2Mul/uCfflPov87ZaQugkZo+cwr9n8XJ2 VE8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020a50fb0a000000b0047deaeaeb4fsi28218252edq.97.2023.01.05.06.53.57; Thu, 05 Jan 2023 06:54:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233803AbjAEOwW (ORCPT + 99 others); Thu, 5 Jan 2023 09:52:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234258AbjAEOwU (ORCPT ); Thu, 5 Jan 2023 09:52:20 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 772C0E50; Thu, 5 Jan 2023 06:52:19 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A92A16F2; Thu, 5 Jan 2023 06:53:01 -0800 (PST) Received: from e126311.arm.com (unknown [10.57.76.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D7FCB3F71A; Thu, 5 Jan 2023 06:52:17 -0800 (PST) From: Kajetan Puchalski To: rafael@kernel.org Cc: daniel.lezcano@linaro.org, lukasz.luba@arm.com, Dietmar.Eggemann@arm.com, dsmythies@telus.net, yu.chen.surf@gmail.com, kajetan.puchalski@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 1/2] cpuidle: teo: Optionally skip polling states in teo_find_shallower_state() Date: Thu, 5 Jan 2023 14:51:58 +0000 Message-Id: <20230105145159.1089531-2-kajetan.puchalski@arm.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230105145159.1089531-1-kajetan.puchalski@arm.com> References: <20230105145159.1089531-1-kajetan.puchalski@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754194731431250746?= X-GMAIL-MSGID: =?utf-8?q?1754194731431250746?= Add a no_poll flag to teo_find_shallower_state() that will let the function optionally not consider polling states. This allows the caller to guard against the function inadvertently resulting in TEO putting the CPU in a polling state when that behaviour is undesirable. Signed-off-by: Kajetan Puchalski --- drivers/cpuidle/governors/teo.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c index d9262db79cae..e2864474a98d 100644 --- a/drivers/cpuidle/governors/teo.c +++ b/drivers/cpuidle/governors/teo.c @@ -258,15 +258,17 @@ static s64 teo_middle_of_bin(int idx, struct cpuidle_driver *drv) * @dev: Target CPU. * @state_idx: Index of the capping idle state. * @duration_ns: Idle duration value to match. + * @no_poll: Don't consider polling states. */ static int teo_find_shallower_state(struct cpuidle_driver *drv, struct cpuidle_device *dev, int state_idx, - s64 duration_ns) + s64 duration_ns, bool no_poll) { int i; for (i = state_idx - 1; i >= 0; i--) { - if (dev->states_usage[i].disable) + if (dev->states_usage[i].disable || + (no_poll && drv->states[i].flags & CPUIDLE_FLAG_POLLING)) continue; state_idx = i; @@ -469,7 +471,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, */ if (idx > idx0 && drv->states[idx].target_residency_ns > delta_tick) - idx = teo_find_shallower_state(drv, dev, idx, delta_tick); + idx = teo_find_shallower_state(drv, dev, idx, delta_tick, false); } return idx;