From patchwork Thu Jan 5 12:41:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 39505 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp282455wrt; Thu, 5 Jan 2023 04:46:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXsiK2DOB39F+CSR/djuRF0SGfXFIOnErXiiJYudpgEjg8SYzjEyFOa+V1NdxuZpKPYMb1nn X-Received: by 2002:a17:902:d546:b0:192:607b:f69b with SMTP id z6-20020a170902d54600b00192607bf69bmr49888527plf.28.1672922805138; Thu, 05 Jan 2023 04:46:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672922805; cv=none; d=google.com; s=arc-20160816; b=IsdjERnnRsd31HjeyaQUCpjeKeQc+v+HJEYtp41MmsC2VfBmrGMKjCgWSWpR/+EBqe KAM3NAQkszM268ZD5MWCyoJszad74EmqUEsNY1elmoMVR3embFkS7NJak59/CPH0ySqN BDineq9ExwxAyO1AJEEn/sPALi7QMDIhcZOhKmPPnG6wBip3RWD0MxjMvKouKa7dqUGy jGcFSPad6ni28YO5nvzT5k2XfDN73XYvQoHbOaHF2C9XuX2pd7ZrnZTwyXpWpLx8ddJ6 eCa/eJMX/UThkGLkumryqfR3cq9Vz6m2Y8y2htPBiPHytCWCkMwcH31ovIrpYPnhseHd 3fmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8mYBOZhut1McL5t8U9bUpMD48gPtdONvdoyZEUsQo0o=; b=cuv5e79mkri/8QR2VYQXy0sBDbrk7Az25IMn8upSP8EYIvzviVNsXtwCthzUm4nXbL ZgwsFacoX2YwV+0Lxc6j2/iKVRIHe69dN9ZYtwd61EFVTO2BO/ys+lqm57/9d9O+8/RI IZky8wcnZZ3EifrOnKdrL7I275R5CoEONaaawUdcEkOjdISCtCxFIUQOn6qeUucom51J tWHfWoeWKWaalLdH28g8H2dHnIHSc8reLn7OQQA6BEBMm+BaKD/nuk8nAESi5mXE4F7Q Kew5p+KR2zIJzJSYwBa9kEzNdYex27vDWkwCR417A8Ty0MM8DmfFgNSpBzviRuZ1oMwI 5JlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=Dlp6rSdd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a170902690800b0018980446328si35486161plk.485.2023.01.05.04.46.33; Thu, 05 Jan 2023 04:46:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=Dlp6rSdd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232575AbjAEMld (ORCPT + 99 others); Thu, 5 Jan 2023 07:41:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232294AbjAEMlM (ORCPT ); Thu, 5 Jan 2023 07:41:12 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 281A532E8F for ; Thu, 5 Jan 2023 04:41:09 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so1210669wma.1 for ; Thu, 05 Jan 2023 04:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8mYBOZhut1McL5t8U9bUpMD48gPtdONvdoyZEUsQo0o=; b=Dlp6rSddGlTIAmt3GjVdQUjqvXqHbbIQ0Z6RpA/KuOjU8qPQC7bM+7h/KMe5zPJUqJ 9YM8XL/y6FGIAwWXjo+1x12QcywGZ2U4GotPozZ+GshXAFQjeWdGZmGFqRnLjaxgTKgL MxKtflXIebEXsjwadfP3APnkiJSyzJfZqfpMKXk+F4IiJ1wAWM17yrH/39EW3u5OJGMp UIGV2bJ7JrG+QgMkE+D5hS4FBxjagbznbfry/SG8c0cNLhMBy3JUC/TFHC+73g3SsVei m0R68KIaUbYhb+xTfIw/Y6rFGKYJ+WheQewYrxPEqhkli4qCMK0nq+hFy4lzXaHushal NisQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8mYBOZhut1McL5t8U9bUpMD48gPtdONvdoyZEUsQo0o=; b=pPbl9L7z/JbUJywks8UfQLuPwnDdx+Tr1TuVycK7Q8SBw49qqsdlDqos91nCZH/dXF DY64IwfA/m8/bpkP/v+Z4SqB5ZJHWscOnEx0V1ND1/7vruvuDU3hqiNYr6BytjRijc+k f5TbmVbc79UxPeqPakKjkKQenbKZsbofrOlt3ApIG/ndkvd9zsmiwDQ+hhvAA0rg9rIH YP8Gouv1eHUVzYySTYoYHHbJwy682G+4JweWAIFZp2tZRLAPryGGGOD9KOBQFQ3HOgMm 9+iJzTT1Xc5Vrw56TYy5cBAEFufLbuMsadLoK2/g1Fwz+u91/zFeqg0qPXCYjEzw3gMo ZC9g== X-Gm-Message-State: AFqh2kqw6Cada9Ehn3EI1AQeLDapSZW+tB6HYi5OITsHDf1Dzhs4NdiQ GR7P2jRMD+hbQgWvIy3zjZ1UIFLhuDZR3xmW X-Received: by 2002:a05:600c:a4d:b0:3cf:6e78:e2ca with SMTP id c13-20020a05600c0a4d00b003cf6e78e2camr39888024wmq.5.1672922467613; Thu, 05 Jan 2023 04:41:07 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:101:3196:3a40:6416]) by smtp.gmail.com with ESMTPSA id m6-20020a1c2606000000b003b47e75b401sm2338153wmm.37.2023.01.05.04.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:41:07 -0800 (PST) From: Bartosz Golaszewski To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 2/2] spi: spidev: remove debug messages that access spidev->spi without locking Date: Thu, 5 Jan 2023 13:41:00 +0100 Message-Id: <20230105124100.185542-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230105124100.185542-1-brgl@bgdev.pl> References: <20230105124100.185542-1-brgl@bgdev.pl> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754186703166712632?= X-GMAIL-MSGID: =?utf-8?q?1754186703166712632?= From: Bartosz Golaszewski The two debug messages in spidev_open() dereference spidev->spi without taking the semaphore and without checking if it's not null. This can lead to a crash. Drop the messages as they're not needed - the user-space will get informed about ENOMEM with the syscall return value. Signed-off-by: Bartosz Golaszewski --- drivers/spi/spidev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index b71620f64ec9..29c6344ee8e8 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -604,7 +604,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->tx_buffer) { spidev->tx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->tx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_find_dev; } @@ -613,7 +612,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->rx_buffer) { spidev->rx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->rx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_alloc_rx_buf; }