From patchwork Thu Jan 5 11:42:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 39487 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp250440wrt; Thu, 5 Jan 2023 03:25:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXuC0HK9EedUdVl+P9hE2w6xXp7PczroGUCSOEEnth82HaGCxK2ruQcNkZ1cpd7ifzEik8CO X-Received: by 2002:a17:906:2ccc:b0:7c0:e23d:12c4 with SMTP id r12-20020a1709062ccc00b007c0e23d12c4mr39395498ejr.63.1672917923645; Thu, 05 Jan 2023 03:25:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672917923; cv=none; d=google.com; s=arc-20160816; b=LD37qWej1tofVtJLAsnef7aSXs6h2M/HqGeWy3DrTPXnSDoqT6mEfjrytkEjnY4Q3C QxPkaebDeS0Ujhl9q4l+55oeGDfCWVotfCvnpt0+/j/afrTSCmk3TkLAJJEo3gvSxL7B 9eN4mL7RVGlocpbPpg0oJ60jPxuqq80FmnFfZClGBJLA5z9xm3PHXN5n3nwpWxg+ocCw /Qzkzu+x1DeDrabay7OofTxGp0jZWMr4rWqciikizGlxraGOuwoO/46O2lBAOemRVHwI sdwDb5o3rYmUlEs5TeegX6Jw94/C8A1aLr1trmazPCB+yiy5lhvIxj8JmDXFZa9BZDBx vUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=pQldI9Tuyyua3djeGXXKPEJWq5MXNWHAIp4IAdAo2ss=; b=KMiXNHWIKDSUgCDOk9jgMa7+2cmQIwhKV0f3P6UTS/08FXFJPEkDq9RfEb/jHzRN6M JECpKeVOcQTrTSnkz2ULSaOTtx88XOw/IJxl3ExHcGIFRwm9+AQEE2YHa2p/bi3j517/ CsqtJV1RoTjDbpLit9ic+/n3Q1ePG4L6gyiwUob56WWQqVTVjv3wtumbevw9zuPjTqyP 4u3CcupXNSge4jd0I6QW3OXdt4O3YUD1m+l7RTo17MSBdGGdG0f/NXkY6n970UoYWe1V lHP30EkcMP/WLK+0gFu3oHkdCSFhRl1hgF1VGCWAmOUkZAffHTNpBLaCKWPaQJpdJfRw f9vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp14-20020a1709073e0e00b007ae24f7774bsi15231310ejc.168.2023.01.05.03.25.00; Thu, 05 Jan 2023 03:25:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232854AbjAELYC (ORCPT + 99 others); Thu, 5 Jan 2023 06:24:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232558AbjAELXw (ORCPT ); Thu, 5 Jan 2023 06:23:52 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ED4C50154; Thu, 5 Jan 2023 03:23:51 -0800 (PST) Received: from dggpemm100007.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NnkZt6CxzzRqnk; Thu, 5 Jan 2023 19:22:14 +0800 (CST) Received: from huawei.com (10.175.103.91) by dggpemm100007.china.huawei.com (7.185.36.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 5 Jan 2023 19:23:47 +0800 From: Yang Yingliang To: , CC: , , , Subject: [PATCH -next] net/mlx5: fix missing mutex_unlock in mlx5_fw_fatal_reporter_err_work() Date: Thu, 5 Jan 2023 19:42:20 +0800 Message-ID: <20230105114220.466631-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100007.china.huawei.com (7.185.36.116) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754181584591568485?= X-GMAIL-MSGID: =?utf-8?q?1754181584591568485?= Add missing mutex_unlock() before returning from mlx5_fw_fatal_reporter_err_work(). Fixes: 9078e843efec ("net/mlx5: Avoid recovery in probe flows") Signed-off-by: Yang Yingliang --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c index 96417c5feed7..879555ba847d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -677,6 +677,7 @@ static void mlx5_fw_fatal_reporter_err_work(struct work_struct *work) mutex_lock(&dev->intf_state_mutex); if (test_bit(MLX5_DROP_NEW_HEALTH_WORK, &health->flags)) { mlx5_core_err(dev, "health works are not permitted at this stage\n"); + mutex_unlock(&dev->intf_state_mutex); return; } mutex_unlock(&dev->intf_state_mutex);