From patchwork Thu Jan 5 15:53:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 39657 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp366824wrt; Thu, 5 Jan 2023 07:57:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXvwtvQOvUjskfBR6/iNVv0XIDGnmLhRN0CsBVMtayT+vTBn+f8sF2ZqArRNgekGK08YQzUf X-Received: by 2002:a17:907:72d3:b0:7c0:fd1e:972e with SMTP id du19-20020a17090772d300b007c0fd1e972emr57273891ejc.46.1672934223669; Thu, 05 Jan 2023 07:57:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672934223; cv=none; d=google.com; s=arc-20160816; b=DeEn5hV8OpzVnPshwm/qTQYmnff0SrTEdnJqkJ4iN0QB1DaIz7CAc4A7nC/SYUTjDH CLcv28tqg8RECNupDxtkHrw5mU3mhADpZuiSaj88lPVBJIctwpKjkvpWxAZt2lSGLzY1 g55c91Ub0jznCtOIpnLTZsLfNzljNwR4ni9s2RAX/vJAbKCqNi31oLsXPQqO3QhTu2xn yZNmjtDf/cw1QNEnbwPy5hRYp6zzRV3j6vXYDX8MJhlW/U01TY+z+/g79X6f0hXKFHxm /rJ1C1sH9Pz/xA/cG1sJkIOEUKxy/luACg7oq2DIFkLqS/DOn6Kpkaw4WsI/h/yMRXNN 55Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=URlEtcsl1ea5/XXOjOY4NXU7ukX5ZWRYX3nL9EnZRz8=; b=k3rFBz7z1FLFcQuqECOWaNWNY4JRpLq9q0IeIuEvbqFgIAj6A+9kvt9PqlBjm78r7H Zg31bO6bkoRnYsn+vK5Guv7A0TWKeTU4bH/KPuwc6dlUgQcwUoozdzniCGBOYQdJ6W6c Q3Qj6ewWm9+w1IndM4wzmXvOVk1o/fA27JPMP3z8SSizCQeDnvWfXmKoi2zpjTRCYnxT mXtzufMOIkpJ/xAQyBzo6sEetYj9PQi9/EiA0SqevlrKZfKIuMCsyzc5Ir8HB6qhbQsx rGCUFLUdoNbFmQ89k7lJozd/WEqtteW/n1bFC7WmpMISsWF3ek/w7iEHhb4e7CtmlGRl n2LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EaRmeDs9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq40-20020a1709073f2800b007ae86742c37si34574963ejc.60.2023.01.05.07.56.40; Thu, 05 Jan 2023 07:57:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EaRmeDs9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234608AbjAEPyC (ORCPT + 99 others); Thu, 5 Jan 2023 10:54:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234945AbjAEPxj (ORCPT ); Thu, 5 Jan 2023 10:53:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED78113F58 for ; Thu, 5 Jan 2023 07:53:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8162361AF9 for ; Thu, 5 Jan 2023 15:53:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72696C433EF; Thu, 5 Jan 2023 15:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672934017; bh=vHZs9OjJ6KXg+S9h06OTafkkgxBlrbQRQXCR8C8oFts=; h=From:Date:Subject:To:Cc:From; b=EaRmeDs94KgukTL3nj7VhltrGLOj5INt3wMoL9fll6WRAybCmCwkBrdrJLi/YMAOi G38A/xeGwXHS48/pb0wJ0aABHaE4g0CVNok4NTd+TUixmGFbhlyHUjnTCE9Jp8MEqX UUJyy1YEV6GPjEiTqDcVd/tICh8IjxlNNqFEL00O51pqRUSR27N72hH1Ti+v43aQ+7 uRrPTEyhv1rba5cfIott1kTA0DQZtYlM2/hE3euHrkwJvCgMgtmpnHVDI4fmFrm9MV k1f9ernVSQ4yZknxLab+uP6u68l1p3ug6jH+9Wr8wGiL/BGVQEni0uZWiL8EkeBXH1 lYAZFnOrhwlww== From: Nathan Chancellor Date: Thu, 05 Jan 2023 08:53:32 -0700 Subject: [PATCH] ASoC: amd: ps: Fix uninitialized ret in create_acp64_platform_devs() MIME-Version: 1.0 Message-Id: <20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959@kernel.org> X-B4-Tracking: v=1; b=H4sIAHzytmMC/x2NSQoCMRAAvzL02YYsRMGviIcsrdNgMiEdFxzm7 2Y8FgVVKwg1JoHztEKjFwsvZYA+TBBnX+6EnAaDUcYqrRy+ZcnUOZPgs3Dhzv7BX0pYI2MVjGiD OxkXj5SshtEJXghD8yXOeyl76dR2URvd+POfX67b9gN/dwFjjAAAAA== To: lgirdwood@gmail.com, broonie@kernel.org Cc: Vijendar.Mukunda@amd.com, Syed.SabaKareem@amd.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor X-Mailer: b4 0.11.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1438; i=nathan@kernel.org; h=from:subject:message-id; bh=vHZs9OjJ6KXg+S9h06OTafkkgxBlrbQRQXCR8C8oFts=; b=owGbwMvMwCEmm602sfCA1DTG02pJDMnbPjU6rCu0ly2bHu2wMyhmn4Li2T8xM3YKSjq/td54xUcq sFWqo5SFQYyDQVZMkaX6sepxQ8M5ZxlvnJoEM4eVCWQIAxenAEzkjSwjw9QHEZEczY8je97eenThk6 aeQyMrz4JNomHJfEeyF+kf4mVkWNOb1FfPFlP0om+uyEZFjV1i2zpKhW5NfcF/7+K9C/E/2QA= X-Developer-Key: i=nathan@kernel.org; a=openpgp; fpr=2437CB76E544CB6AB3D9DFD399739260CB6CB716 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754198676726595884?= X-GMAIL-MSGID: =?utf-8?q?1754198676726595884?= Clang warns: sound/soc/amd/ps/pci-ps.c:218:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] default: ^~~~~~~ sound/soc/amd/ps/pci-ps.c:239:9: note: uninitialized use occurs here return ret; ^~~ sound/soc/amd/ps/pci-ps.c:190:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 1 error generated. Return -ENODEV, which matches the debug message's description of this block. Fixes: 1d325cdaf7a2 ("ASoC: amd: ps: refactor platform device creation logic") Link: https://github.com/ClangBuiltLinux/linux/issues/1779 Signed-off-by: Nathan Chancellor --- sound/soc/amd/ps/pci-ps.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 03178b4f7e2c59ead102e5ab5acb82ce1eaefe46 change-id: 20230105-wsometimes-uninitialized-pci-ps-c-3b5725c6ed31 Best regards, diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c index 401cfd0036be..f54b9fd9c3ce 100644 --- a/sound/soc/amd/ps/pci-ps.c +++ b/sound/soc/amd/ps/pci-ps.c @@ -217,6 +217,7 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data break; default: dev_dbg(&pci->dev, "No PDM devices found\n"); + ret = -ENODEV; goto de_init; }