From patchwork Wed Jan 4 15:15:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 38968 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp5196775wrt; Wed, 4 Jan 2023 07:17:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXtlaG33TWjH0ZZhjZqe7f/dDGegMPjIlzOjEXho7ay8+vWXS00FpI0vhAvJZC1U48vmwZIP X-Received: by 2002:a17:906:fb9a:b0:7c0:996b:be7f with SMTP id lr26-20020a170906fb9a00b007c0996bbe7fmr36993378ejb.29.1672845420537; Wed, 04 Jan 2023 07:17:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672845420; cv=none; d=google.com; s=arc-20160816; b=PQOepiGcfE88kHRP/RaBPiiMM3xoaCUOSa+sey7w6b7VmtknqoGfM+yWhA0OmAel9U V4G9gt3fuPn6F0DhBnZnnlSYw61PLL7UOk27l24vO/eru9PiuXSqiSWRT2irTM4Ocfl+ Pn4O2zoILaVS7DijhXiPpkpvzfxTqJ8ia1PwzElMmd4h8F/qQtbbjRbhFA74t4/Y8yKl B2pFtu4gOdP1knC5iqfIbpYVQx3dOkEBHcJmU114s2u2gEsvkTg8g1ibkZiGNLt3dfxr 2wsC18El4dyOXKZXWXdnAfxidMSFKdlpRvHITk+bmWOXYPttvWwYqeJQNFz5/37zXO62 tjcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JYKvUsVUnluDWY7DxNBkzDldkgnE2g2IbFcSGdVYRLk=; b=bfPRNWDeW/cwxZUZZ3t/3TOVRz6YqK/lqqFPRdLAAQ+FX/T79bowbfBJerDlMRtUzo +xCijthHEn+xt2n+zfFiXy+wf4DLQsjeZTShlbixAf+qlUydOpFyiIGCiiS9w2FnPW37 0GHqu3aIvIuR++F4USXIpRv6aAopADzTQIyFf5OozwIf5BEdiQVtg7oe+XnosWq9uEOC 6bu54RNSExRFalhRF2hp7o1lnhYlRS2jUnCpolFGg5aaDwxS+kM3QonIIaPFKfR1Qa3b FIuyEpumkpljJiQAb97r/tCr2qHcmoWSwBwNUdnWKgtF5KqshGpV7+eEIGhekrwUt6ds PFng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lJooWq9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wy4-20020a170906fe0400b0078d770f363fsi29069614ejb.471.2023.01.04.07.16.36; Wed, 04 Jan 2023 07:17:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lJooWq9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239354AbjADPQQ (ORCPT + 99 others); Wed, 4 Jan 2023 10:16:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239119AbjADPQF (ORCPT ); Wed, 4 Jan 2023 10:16:05 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03BACE035; Wed, 4 Jan 2023 07:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672845359; x=1704381359; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WoYPJhgn0VzeKMK+DSthce4P36Cbw4uJWhaeJQ2MS28=; b=lJooWq9Jb5VoDjq6pTu81XBceMdGdCzNA9nOkW+je+3Rnm5xWL8aBYV0 x30BFqClq1WzG9yhYg/GZ7KuQ99DAL+r2Ml375HlS6a5PM1NxuxKgTEdV RqI5CVz4NoSQdggkEohTj4hJE2hnMV1hoTUQ4+vWZCuyOtozhd4qtDBlM lkJkZDAuzDOloDUdWRTErfneXbkPmC2kABJX2cOQ7X5T5ku0wevgYnNPA 9wj6nvTtCNT2g+KyTw+izapLLuUyBP/nSXfgZwQbDE9FrOR+tlr6HT/IE dAU1cJBUsy084DUUs5O6dShqds7/gGgQ0YFyf/7SUJeDZiRn5XRkWy6Yz g==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="301644338" X-IronPort-AV: E=Sophos;i="5.96,300,1665471600"; d="scan'208";a="301644338" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 07:15:58 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="762700754" X-IronPort-AV: E=Sophos;i="5.96,300,1665471600"; d="scan'208";a="762700754" Received: from msvoboda-mobl.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.252.48.119]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 07:15:56 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org Cc: Johan Hovold , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 04/10] tty: moxa: Make local var storing tty_port_initialized() bool Date: Wed, 4 Jan 2023 17:15:25 +0200 Message-Id: <20230104151531.73994-5-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230104151531.73994-1-ilpo.jarvinen@linux.intel.com> References: <20230104151531.73994-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754105559245832850?= X-GMAIL-MSGID: =?utf-8?q?1754105559245832850?= Return type of tty_port_initialized() is bool, use matching type for the local variable. Also reorder the local vars to reverse-xmas-tree while at it. Signed-off-by: Ilpo Järvinen Reviewed-by: Jiri Slaby --- drivers/tty/moxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c index bc474f3c3f8f..2d9635e14ded 100644 --- a/drivers/tty/moxa.c +++ b/drivers/tty/moxa.c @@ -1664,8 +1664,8 @@ static int moxa_poll_port(struct moxa_port *p, unsigned int handle, u16 __iomem *ip) { struct tty_struct *tty = tty_port_tty_get(&p->port); + bool inited = tty_port_initialized(&p->port); void __iomem *ofsAddr; - unsigned int inited = tty_port_initialized(&p->port); u16 intr; if (tty) {