diff mbox series

[v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART

Message ID 20230104150023.3115-1-sensor1010@163.com
State New
Headers
Series [v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART |

Commit Message

Lizhe Jan. 4, 2023, 3 p.m. UTC 
  in linflex_config_port() the member variable type will be
assigned again. see linflex_connfig_port()

Signed-off-by: lizhe <sensor1010@163.com>
Acked-by: Jiri Slaby <jslaby@suse.com>
Acked-by: Ilpo Järvinen<ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/all/20230103170948.3777-1-sensor1010@163.com/
---
 drivers/tty/serial/fsl_linflexuart.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ilpo Järvinen Jan. 4, 2023, 3:08 p.m. UTC | #1 
On Wed, 4 Jan 2023, lizhe wrote:

> in linflex_config_port() the member variable type will be
> assigned again. see linflex_connfig_port()
> 
> Signed-off-by: lizhe <sensor1010@163.com>

> Acked-by: Jiri Slaby <jslaby@suse.com>
> Acked-by: Ilpo Järvinen<ilpo.jarvinen@linux.intel.com>

Eh, you're not supposed to invent these Acked-by tags yourself. Don't add 
any tags besides your own unless somebody explicitly gives them to you in 
a reply!

And the subject was supposed to be (as per Jiri's recommendation):
serial: linflexuart: remove redundant uart type assignment

You also didn't include the history of what was changed in v3.

--
 i.
diff mbox series

Patch

diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 6fc21b6684e6..34400cc6ac7f 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -837,7 +837,6 @@  static int linflex_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->membase);
 
 	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
 	sport->iotype = UPIO_MEM;
 	sport->irq = platform_get_irq(pdev, 0);
 	sport->ops = &linflex_pops;