From patchwork Wed Jan 4 14:22:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 38760 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4994182wrt; Tue, 3 Jan 2023 22:25:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXvE1S6er43MvoIW7KKdOOVpkCxKlKfwlh7xnRpVHb0qwivM0yYECfk566xMC98O75Q0Dygu X-Received: by 2002:a17:902:b588:b0:189:dfb0:d380 with SMTP id a8-20020a170902b58800b00189dfb0d380mr52431234pls.33.1672813551719; Tue, 03 Jan 2023 22:25:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672813551; cv=none; d=google.com; s=arc-20160816; b=IL9BuT5jLd2PFKO5XqbiYwwLFh2vMhs45cUg+jk2QDHWBAscYPoj6K4YjRYBO84Piu 1a4OxWZFse1bSKRZwM7e9sKJlM04vC3OE4o0B6tTJLY0jivZaUvblnvVWzZlwOGIlDQB 7tHFHS0Mkt6vFQfkz6LqGQ5Gu2oyuAqUbGVN5atRH79Pku//PQ+JYxOuTg436DaWXx5+ 2ZcG7m+s59pP2nXvjrCJgR1V3V/5AF0ol8dwrEY/+dIZjouL2uNoC7xBprZC09WkkMLW LOw1kxSHAxo23kgKAr4moDSX0XFiGbx/7OHk0kebrg/PIUzs5AAYsAlRUvTKtZJHRWfl ANow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vG+p6Wr9gO8jRbgS3tHjZl0HMZcqzdEzM2TePRWKM94=; b=m9iGQkpCG6otDs8yOiv6z5KQdKanDB0itThwNHLKCsMcHT49sVNMXjM69Q297Uzxkx whqmC4F0H+yDIP0P49HNHKLxPazVnGCJ2j+/PT0T87NKDmlpJmjfctp0d4X98zOJ5ddZ imQ2XZrpbISyGTFw6a4qUwvhFAd5kb/q9LJ5i8U92e9MBbQr4p5kY1+nk72GoybT2t9a ckrr8FXnTismbMkymMm5XsyWwcb5PJ6lRafVOzUAS+FiU98nsC5qg7rVgLtyPnCWg5Rs 9mfZw1SX4NcyCIeGjf4dEOjPxnz1Ug8TBkjxeC3iSYSCBgDutSPopxS60gw6Xmh2Xqze tTmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f33-20020a635561000000b0046ef21af717si35223133pgm.683.2023.01.03.22.25.39; Tue, 03 Jan 2023 22:25:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231176AbjADGYb (ORCPT + 99 others); Wed, 4 Jan 2023 01:24:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbjADGYW (ORCPT ); Wed, 4 Jan 2023 01:24:22 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0AA17E1D; Tue, 3 Jan 2023 22:24:21 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Nn01W6vjGz4f3mWD; Wed, 4 Jan 2023 14:24:15 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDnnbGOG7Vju3lKBA--.23788S7; Wed, 04 Jan 2023 14:24:18 +0800 (CST) From: Kemeng Shi To: axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, john.garry@huawei.com, jack@suse.cz Subject: [PATCH v2 05/13] blk-mq: remove unnecessary list_empty check in blk_mq_try_issue_list_directly Date: Wed, 4 Jan 2023 22:22:51 +0800 Message-Id: <20230104142259.2673013-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230104142259.2673013-1-shikemeng@huaweicloud.com> References: <20230104142259.2673013-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDnnbGOG7Vju3lKBA--.23788S7 X-Coremail-Antispam: 1UD129KBjvdXoWrKr1xWry5Kw1Utw48Ww18uFg_yoWDJrX_uF y09wn7XayDGF17Ar4I93WIyFn8K34kGr1fXFyxtF98GFWfXFs8Was5KF4ruw4xCay3KasI 9r4rXF9Fyr10gjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbSxYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUIL05UUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754072142986780678?= X-GMAIL-MSGID: =?utf-8?q?1754072142986780678?= We only break the list walk if we get 'BLK_STS_*RESOURCE'. We also count errors for 'BLK_STS_*RESOURCE' error. If list is not empty, errors will always be non-zero. So we can remove unnecessary list_empty check. This will remove redundant list_empty check for case that error happened at sending last request in list. Signed-off-by: Kemeng Shi Reviewed-by: Christoph Hellwig --- block/blk-mq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 9c3a9b5e5b0c..d84ce1f758ce 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2833,8 +2833,7 @@ void blk_mq_try_issue_list_directly(struct blk_mq_hw_ctx *hctx, * the driver there was more coming, but that turned out to * be a lie. */ - if ((!list_empty(list) || errors) && - hctx->queue->mq_ops->commit_rqs && queued) + if (errors && hctx->queue->mq_ops->commit_rqs && queued) hctx->queue->mq_ops->commit_rqs(hctx); }