From patchwork Wed Jan 4 14:22:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 38754 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4994051wrt; Tue, 3 Jan 2023 22:25:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXuUfwqUa99gbduUagylm4cAMvcM3qD0yBmdrpeSTVTh0CfVbiuZhJ7bmnXLeJIyJ3TZO+a8 X-Received: by 2002:a17:902:ea02:b0:191:271f:477c with SMTP id s2-20020a170902ea0200b00191271f477cmr51459425plg.32.1672813518159; Tue, 03 Jan 2023 22:25:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672813518; cv=none; d=google.com; s=arc-20160816; b=tW4ug4eZ0LlqcNj0IHf2op058QP72PG9UqyAbC2Dn9vimPWAJmOd1maO7fbFPkrmNN WzL0ElWnpwEXWJS3X3QVSA2JTvZzE34Mo5HY1+f/dDOw3ToDjUK9Yjy08kUx2mWC4P8f kRZsCfGgRxI1/3T1lbOfyqwFLpmY11rhrlgav9TZLvHJm+HzYS1dSXkSfHvs6BsBPTuF acsFb8QEor2msJbYAsK9qWxPoWPCocDHM8u23pl8g9tAFaG4qG/x42DGHrjUOn9I2LOX 6M8Br/Jq5X1a90M2gnam9G1uh+XcPQAgkLD9hCWxvaNpcWu6o81rFHStM9IDnIBIxM+A A/DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=fpscdibgIixg9vx+uymZXH5TpQJCK1SqzssCNV3lxTI=; b=OvNsZF+uhQ6UYmO+GEUZHhkvCM090bEKsUSE5CLevPwtYACBWf9Qv3x7FRIaMnu6RG NyiUYFvbePhOg3hrx03ZKM/6+bOAFHuqxMYI06bpb4fbfZC9Gha6F8VAutelkzOTpNA3 mMbZuiRhiANgea50BrlDtBIL7vSH0hPVHUCBAGaDRElvGfLSM4EDtzxH1DGW4McLHrmH /IXDvpLVRsTZdV0MtB3dQzwnJsyagIBywoDPna2Zhr2Izcl+ukTILaBj5CMlrm4YYIHx 8cVirTD45hbWJ3aLhqyUYpksh9NCT73MRe3MgVf3AETlYDiJOftm/w56PclVKF/gW7IE Tspw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170903244600b00186a1c4e64dsi35801678pls.236.2023.01.03.22.25.05; Tue, 03 Jan 2023 22:25:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233121AbjADGY1 (ORCPT + 99 others); Wed, 4 Jan 2023 01:24:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjADGYW (ORCPT ); Wed, 4 Jan 2023 01:24:22 -0500 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4831317419; Tue, 3 Jan 2023 22:24:20 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4Nn01V4ZRCz4f3mJL; Wed, 4 Jan 2023 14:24:14 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDnnbGOG7Vju3lKBA--.23788S4; Wed, 04 Jan 2023 14:24:17 +0800 (CST) From: Kemeng Shi To: axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, john.garry@huawei.com, jack@suse.cz Subject: [PATCH v2 02/13] blk-mq: remove stale comment for blk_mq_sched_mark_restart_hctx Date: Wed, 4 Jan 2023 22:22:48 +0800 Message-Id: <20230104142259.2673013-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230104142259.2673013-1-shikemeng@huaweicloud.com> References: <20230104142259.2673013-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDnnbGOG7Vju3lKBA--.23788S4 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw18Ary5CF1UZw45KFyDKFg_yoWDZrX_Ww 15Crn7GFWDGwn0vrWakF4UZF4Ik34kJa4UCay5tr9Fyw10qa9xGr4UKr15XrZ8W3ZxGFW3 Jwn5XrykA3Za9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfxYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r15M28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jguciUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754072107575483711?= X-GMAIL-MSGID: =?utf-8?q?1754072107575483711?= Commit 97889f9ac24f8 ("blk-mq: remove synchronize_rcu() from blk_mq_del_queue_tag_set()") remove handle of TAG_SHARED in restart, then shared_hctx_restart counted for how many hardware queues are marked for restart is removed too. Remove the stale comment that we still count hardware queues need restart. Fixes: 97889f9ac24f ("blk-mq: remove synchronize_rcu() from blk_mq_del_queue_tag_set()") Signed-off-by: Kemeng Shi Reviewed-by: Christoph Hellwig --- block/blk-mq-sched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c index 23d1a90fec42..ae40cdb7a383 100644 --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -19,8 +19,7 @@ #include "blk-wbt.h" /* - * Mark a hardware queue as needing a restart. For shared queues, maintain - * a count of how many hardware queues are marked for restart. + * Mark a hardware queue as needing a restart. */ void blk_mq_sched_mark_restart_hctx(struct blk_mq_hw_ctx *hctx) {