From patchwork Wed Jan 4 13:06:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Schultz X-Patchwork-Id: 38919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp5139347wrt; Wed, 4 Jan 2023 05:20:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXuDLdBRpBwkuafd0VxDvS0qHPXWw7Iyua/cf5GJj4EkV5wj4rRP1sNomht7fes1FuorxmSy X-Received: by 2002:a17:906:6d47:b0:7c1:311f:3533 with SMTP id a7-20020a1709066d4700b007c1311f3533mr38378236ejt.60.1672838417925; Wed, 04 Jan 2023 05:20:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672838417; cv=none; d=google.com; s=arc-20160816; b=OQNkIShhRBwW0DA4ZNCAFPGG7I3SjJMCmvRWXXtPKEIyl2azTmlZOIbmAsgV8IZfgD 0Sr1aV+2dmDa0BoIF2RQI/dS/9lykplhu+VWxTE4OKWxT4t6SCMo3dPVA9DJMnS2Og2T eDPLZuQkqP7iBTg8wUsMhorzdOKmHH8vBeAClfl7wQTxd1I7/haFzXMzqUCZhZNzMeR8 MQgNjMxEyPaw0rHYCouaz20IBB8yWt82z/slBqx9ar2YF8KEGtSNXyDdSntH6cKK2+AH QuICF0CgIwItJyz75awrc1L8cxtRsn+uxwMrKiBtFQBRnz6OEUTlQeNRrSVGsA89VtQS i6Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=ugNcPMPFqJbl7gg9/gO1OK/MP2MmCPVKoAMXT6jWmmQ=; b=Jx/6zdEmU6rSmlcTsU28u7tGjuleLnIVuU+U6FHAMUXFmucR4MR/vnO0RxSPE+E+9b Xk9eSxp0kYqQXVLmDUIU+kgRKJsx5WsibmIoZYPITO2AL4ba92DKtXHO0WN9Dg8VlGFJ J3vV7cdZJshQMhLICiWxdbCIN2wT0thrRYrfCbEGBs2u74DBYTHrgtewToLJ1OfFW0HV HoIII2ECAewA+xL5rhrmkGtFY3TmDRyWOxUt2hO+Vg68slUUel1cGyezc9RkbUzzEfc7 17SMhM/tjgUhXsjMYbyujYRPWuYp5HofvqdQz/IWPAiSOv2Ulg0v+JnFS0ndwV7dbe4y jtsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fd16-20020a056402389000b0046ba3001425si27844950edb.60.2023.01.04.05.19.53; Wed, 04 Jan 2023 05:20:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239409AbjADNJc (ORCPT + 99 others); Wed, 4 Jan 2023 08:09:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239401AbjADNIn (ORCPT ); Wed, 4 Jan 2023 08:08:43 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1353A2626; Wed, 4 Jan 2023 05:07:40 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id E3719188371C; Wed, 4 Jan 2023 13:07:37 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id DD8D7250007B; Wed, 4 Jan 2023 13:07:37 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id BFE2D9EC000D; Wed, 4 Jan 2023 13:07:37 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 Received: from fujitsu.vestervang (2-104-116-184-cable.dk.customer.tdc.net [2.104.116.184]) by smtp.gigahost.dk (Postfix) with ESMTPSA id 5C0649EC000E; Wed, 4 Jan 2023 13:07:37 +0000 (UTC) From: "Hans J. Schultz" To: davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, "Hans J. Schultz" , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 net-next 1/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags Date: Wed, 4 Jan 2023 14:06:01 +0100 Message-Id: <20230104130603.1624945-2-netdev@kapio-technology.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230104130603.1624945-1-netdev@kapio-technology.com> References: <20230104130603.1624945-1-netdev@kapio-technology.com> MIME-Version: 1.0 Organization: Westermo Network Technologies AB X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754098216748975707?= X-GMAIL-MSGID: =?utf-8?q?1754098216748975707?= The default return value -EOPNOTSUPP of mv88e6xxx_port_bridge_flags() came from the return value of the DSA method port_egress_floods() in commit 4f85901f0063 ("net: dsa: mv88e6xxx: add support for bridge flags"), but the DSA API was changed in commit a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags"), resulting in the return value -EOPNOTSUPP not being valid anymore, and sections for new flags will not need to set the return value to zero on success, as with the new mab flag added in a following patch. Signed-off-by: Hans J. Schultz Reviewed-by: Vladimir Oltean --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index ba4fff8690aa..d5930b287db4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -6546,7 +6546,7 @@ static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port, struct netlink_ext_ack *extack) { struct mv88e6xxx_chip *chip = ds->priv; - int err = -EOPNOTSUPP; + int err = 0; mv88e6xxx_reg_lock(chip);