From patchwork Wed Jan 4 12:57:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolu Lu X-Patchwork-Id: 38907 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp5133890wrt; Wed, 4 Jan 2023 05:09:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXtNhkr0C6cQqIUvxUBTyy/Ja5ybfLKJEuLeSY8gbmFmVSfAq3/5ymkyG59sZ0AWR/hzpVOi X-Received: by 2002:a05:6a20:3c93:b0:9d:efbe:a113 with SMTP id b19-20020a056a203c9300b0009defbea113mr64016277pzj.35.1672837742927; Wed, 04 Jan 2023 05:09:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672837742; cv=none; d=google.com; s=arc-20160816; b=EcBVs1FS4KuWcrqTnxUL6rNGn3A5RolXpo2SXE89YizqULeanVnTcMgLU+POfNQ4n+ lk96jJJXMXJp8sWrpRiCrwPEUtpVMEB2nPnkBwfSBW3cmZrAa+gKEJjp+WDAPsYeaYj2 bBCmXHZyUn8wlheygfkyTDybYl7Q2v2eSjc0yEmZY4pyfjjOrTesfvNE4YQmPeHLdKM2 ERj+0JLgFhpijpYxuyvxKSdcyjgi77+DZJ4HoGpCA2Nb+OScp8kEVpsQahd06kgyg23O dYLM175uVUuJ66XoPajMkiPUZ7zrrWj9j7L/9VpJo/r+FcJFXCjAd+RoxRL/hqBnTlCl DbYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=20osE87v4GBOai7gBIglQxiyjkyEc1FMCkAq8l9tyG4=; b=0Oufb/OGDu69U80Dpv5XyYJMoYzHHT0PrQ2lY08pX5utlcMpV+zcapo/Yusi8txxPR V7dF8oz/Ro+tPNafKOfyV377QwdiBhqCDjf35YqJi0jcZ2uO4KN1Kv/B1JlBj91Nany4 ENjN6VWDFRvs0MC/t9ymOrVXOZbINJeDuGXq4072j1NU1d6b6lJln9ROVY0cHkwKtzv/ DRormQstcEU14+YjFBzPKvdV4rwTWwNGf5cln0RY+n7LmXti4zzcKlNZnMd63Zx1dnff VkPqRNxsZb5OJp4StXepylGfssKquBx1715xucJMrvtX+2t9VbxO45P/9yz9v8qIkZtH m32Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cKbaUosI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b24-20020a631b18000000b0047caad28cdbsi34528942pgb.621.2023.01.04.05.08.50; Wed, 04 Jan 2023 05:09:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cKbaUosI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239295AbjADNHZ (ORCPT + 99 others); Wed, 4 Jan 2023 08:07:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239173AbjADNGh (ORCPT ); Wed, 4 Jan 2023 08:06:37 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7418B3753E for ; Wed, 4 Jan 2023 05:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672837581; x=1704373581; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+FAqxiLeKTjC5EQBIkZoPJaAUfpQlzWcuzFJW+dcWDQ=; b=cKbaUosIVxQJlhUfHm+bLYaylBqQpBfnuiraFRM7tox6eUL9HaXWu4nN i7bvH30DzYWHo9VcOKWUUeU8gg5pT8HesyRGra7enjT9JciSSCGwnsqSB H7AuKg7iuaMR/ekauiNYlo5S0LZkRtSvpp8VyDJN6Cx2VCg9EuyZevNzs CwggdyNSBVwo8+CiXz7fbFIZjLz+LN9X3/reTog1CTBBKIvzcjfEf0Wvs AQHpVDSzkjKgu1reXHSkT+Z/CSTAJfQS1Ug7WIWfOd98p9giye4OtoXLY fXAaV5FjT8ji0UqeLFTF1EMIlqOTV1TF0g9eDm8XccY1GLSZDaAssftgw w==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="320639913" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="320639913" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 05:06:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="797529095" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="797529095" Received: from allen-box.sh.intel.com ([10.239.159.48]) by fmsmga001.fm.intel.com with ESMTP; 04 Jan 2023 05:06:14 -0800 From: Lu Baolu To: Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Kevin Tian , Will Deacon , Robin Murphy , Jean-Philippe Brucker Cc: Suravee Suthikulpanit , Hector Martin , Sven Peter , Rob Clark , Marek Szyprowski , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Yong Wu , Matthias Brugger , Heiko Stuebner , Matthew Rosato , Orson Zhai , Baolin Wang , Chunyan Zhang , Chen-Yu Tsai , Thierry Reding , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Lu Baolu Subject: [PATCH v4 09/19] iommu/sun50i: Remove detach_dev callback Date: Wed, 4 Jan 2023 20:57:15 +0800 Message-Id: <20230104125725.271850-10-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230104125725.271850-1-baolu.lu@linux.intel.com> References: <20230104125725.271850-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754097508807387874?= X-GMAIL-MSGID: =?utf-8?q?1754097508807387874?= The IOMMU driver supports default domain, so the detach_dev op will never be called. Remove it to avoid dead code. Reviewed-by: Jason Gunthorpe Signed-off-by: Lu Baolu --- drivers/iommu/sun50i-iommu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c index 5b585eace3d4..2d993d0cea7d 100644 --- a/drivers/iommu/sun50i-iommu.c +++ b/drivers/iommu/sun50i-iommu.c @@ -834,7 +834,6 @@ static const struct iommu_ops sun50i_iommu_ops = { .probe_device = sun50i_iommu_probe_device, .default_domain_ops = &(const struct iommu_domain_ops) { .attach_dev = sun50i_iommu_attach_device, - .detach_dev = sun50i_iommu_detach_device, .flush_iotlb_all = sun50i_iommu_flush_iotlb_all, .iotlb_sync_map = sun50i_iommu_iotlb_sync_map, .iotlb_sync = sun50i_iommu_iotlb_sync,