From patchwork Wed Jan 4 08:14:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 38779 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp5029233wrt; Wed, 4 Jan 2023 00:23:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/yzGrfSIoWeN61dhW/Mr9ROUPO5IQk+psGVGXocWwmkB9/6SpLZO7xAQBf4uQKW3UHq18 X-Received: by 2002:a05:6a00:be9:b0:580:f5a8:2e2b with SMTP id x41-20020a056a000be900b00580f5a82e2bmr39156142pfu.8.1672820597987; Wed, 04 Jan 2023 00:23:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672820597; cv=none; d=google.com; s=arc-20160816; b=drRg76v6xNFobyoR+/CY5EuONmWkAArbh3sB0OxuWCvpdABN2aN+zwRziVCh4VmdIF 8HuEisjCW/hTXy+uFb0mCWXuIxWkmPe8V/NEoTRs4EuEHkvf6NcNWmGGdnh2fHo1LR/i owlzlZ5relBy60px+QwHeA4jslEy0M3Z+MlCh0A2ZQ7k7bIQ12fq50XfP6SISV28RS6p OkvwvMIF1Xx0GsbTgunmULGY+VnEvnwEv3DE0KryNLuELOx8pACS8K5r5s0uAE/0SIMS ZEe3jjD6bBTCuNbwFqP0nqUNe4737o8JLo1PdlAiuE1mb7Y13YkAe08KB/bz5DIvz+tn l/Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=w/04hUj4xs2kUGhGVqnYdX4sziWnoObx5V1B9hl5JqQ=; b=VQetAs5qcdG20M2pGo9Yw82fBXgbUQWsvLrQNYMeBHQJNGwgGBN8aPEzUqhwpUQXsp 4Fn3xcu/XbLaSHZMwlWD6GC4JpQ8vqgGU2h5ukRUtbdWFMGZPeUvVP9UHAusEWuI8J54 rM92sF2mkoiASmlJmTR1GYyFTTfWF+Hvo2hsv/BuK03U8/Oarz2A7Pf7GBsH2WFWd9yY v6KID8bF563wAEfZAs1ddpBPIe4T0XMsYbPBJgfvGERhW955+lRKBaG5jxuWfIo5aQdt fvNsx4hmv2KtgFmIKBwOPil2xRLiM6kLW+SxJoWJvXwFQRhX8LLLAn57p828drupldub XnCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=k8HeThod; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a056a000cc700b00582b3c894b2si4857690pfv.341.2023.01.04.00.23.06; Wed, 04 Jan 2023 00:23:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=k8HeThod; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233204AbjADIO7 (ORCPT + 99 others); Wed, 4 Jan 2023 03:14:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbjADIO5 (ORCPT ); Wed, 4 Jan 2023 03:14:57 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F54EDEAC for ; Wed, 4 Jan 2023 00:14:56 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id jn22so35133801plb.13 for ; Wed, 04 Jan 2023 00:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=w/04hUj4xs2kUGhGVqnYdX4sziWnoObx5V1B9hl5JqQ=; b=k8HeThodh9qWBuxngqyacfo4g5+HB73+0h0H85Qmckf/9uMZvGJL9gngLx3ZIff0dM r03BcCuQi6K9FFuixjlzx+WJbZxyI3lexAq5fyBABaPPpvke8UYXKmjJGAGvwGYbfAQN LUxtzEgxVofHfiChEV/lGguxf/xdMXymcBsx0vB68i6JagguiWdsOuIaKiNXrU04TFY0 Ot3ozNrBGw1aEqfVZbFHDIXrdZfs5nz3ct+8NhrcF4wgofXPj8meUKZTOY64I6ArPIAm mGPQ5fG2sg+YdNrGF0D+CkkKKhrtOP6M4u2J9kiaT882Oo2rRoRitFgRzpCDdY3Jnwf9 rByQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w/04hUj4xs2kUGhGVqnYdX4sziWnoObx5V1B9hl5JqQ=; b=W9TCdp/V/Ocj7rDLhJC3ib1JTQ3qIGty3hpRQaPvr36u0SyqMXKVIyy5wcVp4gwB7s 4ASx5U8Sdy8W2yCEI0Z6EKv4EJzNr3ihWmqmewN3cTw9tqtoswjuOSqc/VfuCqCwYEud FlsdXMx6k/uYxl0droehPByqWGS6kPyhocCtYZmau5ovFfhSvEynfA+MwJjY4UZ5++FW wGz1fosjreglCbXK7qqQVc5eM9m+rXor2lHoxqoGgrL6po1gjeKSqTcoeosV9+XyPJB7 AY/2xrVW4b2MI5Sr4//HgQFi+EexEIXlmnLpKvSpbuhkFQXv6wN7ijwwMNuIHrbyYopO ngww== X-Gm-Message-State: AFqh2koBs80goJ+DvxRENMSrxVVAvrQuKuw9bUSgHYIIGHCnaF8AYIBY GrsqZnXjDbd95Bp8ITHEW/FcO+sgFFh5tQs6 X-Received: by 2002:a17:903:110d:b0:192:8b0e:98e1 with SMTP id n13-20020a170903110d00b001928b0e98e1mr37809520plh.54.1672820095871; Wed, 04 Jan 2023 00:14:55 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id g12-20020a1709026b4c00b00186a2dd3ffdsm23420819plt.15.2023.01.04.00.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:14:55 -0800 (PST) From: Miaoqian Lin To: Richard Weinberger , Anton Ivanov , Johannes Berg , Miaoqian Lin , Wolfram Sang , "David S. Miller" , Jakub Kicinski , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] um: vector: Fix memory leak in vector_config Date: Wed, 4 Jan 2023 12:14:05 +0400 Message-Id: <20230104081408.4074275-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754079531602197582?= X-GMAIL-MSGID: =?utf-8?q?1754079531602197582?= kstrdup() return newly allocated copy of the string. Call kfree() to release the memory when uml_parse_vector_ifspec() fails. Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver") Signed-off-by: Miaoqian Lin Acked-By: Anton Ivanov Reviewed-by: Geert Uytterhoeven --- changes in v2: - only call kfree() when uml_parse_vector_ifspec() fails. --- arch/um/drivers/vector_kern.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index ded7c47d2fbe..131b7cb29576 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c @@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out) if (parsed == NULL) { *error_out = "vector_config failed to parse parameters"; + kfree(params); return -EINVAL; }