| Message ID | 20230103145219.40226-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4660947wrt;
Tue, 3 Jan 2023 06:57:38 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXt1OKBIlUu6qn8NWBakNfgMTpuEou/Ckh25uSdM+6xd3zQiJeFlkCzSpThQzfp0j1zDZedU
X-Received: by 2002:a05:6402:1caa:b0:46c:2c94:d30a with SMTP id
cz10-20020a0564021caa00b0046c2c94d30amr35619497edb.31.1672757858250;
Tue, 03 Jan 2023 06:57:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1672757858; cv=none;
d=google.com; s=arc-20160816;
b=pB3xOJJ/8DMGbMrL7UVgIiXDBTf22To1Wt4X7F2rnqthvnAWwQVaFXsEjB+zBX+FNH
bdLHfHOxbrW+NmpeuU6XL1LRrNSABwCY/4QqZmfvcX04lo4x95o1AG2galXTwhuNXH5q
1rFL+5ZPPH1zu2lyvS1WSWboosFAWscqlbY9Z0FUnapZBG4urRBcyR1G7fvzAooWJmp2
GNweVOU1omHLslRq1ByLhSaUxONBbY8rwyFvAgdCdWFGKvNzl5NL1vfryMx3Lz7lwtw9
tdqIBJuVGaHlRSJh4djGdLOtLWFc4pP6RgfKWiGAN3Q4kwtiODF/rB6TgAvUHHnJLlSH
FrAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=DDgah90w1QrL6+0GKsgkkj4gxbU/yorOLVFJZWRsyf4=;
b=RJR0BnLQntBF0XDnvGcRZMA/5Ka++60E/UE1M/gYRt72QfR2a8wOUh4pjA9aaf9Kzl
B74cpajKS0AOIxlNfU6nlh9Q0KwZlv86xeFaBXVgiyO0cY0Sm9XFoLsSfzAQiqTaK9Zi
U/LotAWZyvlrqYyQVf5LI3AtVagrQiP0U4Zjs/BW9S3gJSYfMvFBUKy0ywEJ/pJ2KI25
XGEU8kTrpPgfVosggDYpzRIwEj6sayGZ7KxLoXBVEPO3peSQLVaIqUxMmTgRFhmhDFNB
EJ6UjIEmZqRyhwjPIcE0zWGNMNJ9vknje2WyrTI/kVi9ePrA1t9+u5iEv4k+uZTM3QYM
GpIA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=nsHL1qcm;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
r6-20020a05640251c600b004617facf124si28497426edd.253.2023.01.03.06.57.14;
Tue, 03 Jan 2023 06:57:38 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=nsHL1qcm;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S238075AbjACOwK (ORCPT <rfc822;tmhikaru@gmail.com> + 99 others);
Tue, 3 Jan 2023 09:52:10 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58528 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S237665AbjACOvx (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 3 Jan 2023 09:51:53 -0500
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41444F580;
Tue, 3 Jan 2023 06:51:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1672757513; x=1704293513;
h=from:to:cc:subject:date:message-id:mime-version:
content-transfer-encoding;
bh=CJNxDWf0SDtHR1aktd5x50aZoSIoYakJYJ7HaKKk2NI=;
b=nsHL1qcmTzhRqCU9XOPH7zaThnO6PR6gS6pH9WhhQfnT9x21FYFA7mx1
ISoQJ8loKIhp5lWR582FbbhN9DZKJYfJYM1htwuncK1IlK3TKB9V73UAV
5TU25E/KOM2O+m+7PX2BAEoIMtsBOyf//vH2RyAGlDpFaKJV51HNEOCuc
O5iqZpfd4/cip2mRzgSdihGenNcZvEo4/Q1h5tVb7svcWHeuhH9vxKQdY
hEt9sQvZHclKdvqHn9uYAtIR3sRvqlVBJv3sTZvPsGnjZ6BlCm/El0HT0
RxCWUTnfelPLBQ/geucanwlLG8G6h6hau6yvs8LtPhltDw1ypDsVwjJo2
g==;
X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="302047054"
X-IronPort-AV: E=Sophos;i="5.96,297,1665471600";
d="scan'208";a="302047054"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
03 Jan 2023 06:51:52 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="685422749"
X-IronPort-AV: E=Sophos;i="5.96,297,1665471600";
d="scan'208";a="685422749"
Received: from black.fi.intel.com ([10.237.72.28])
by orsmga008.jf.intel.com with ESMTP; 03 Jan 2023 06:51:50 -0800
Received: by black.fi.intel.com (Postfix, from userid 1003)
id C328CF4; Tue, 3 Jan 2023 16:52:22 +0200 (EET)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sylvain Petinot <sylvain.petinot@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 1/1] media: i2c: st-vgxy61: Use asm intead of asm-generic
Date: Tue, 3 Jan 2023 16:52:19 +0200
Message-Id: <20230103145219.40226-1-andriy.shevchenko@linux.intel.com>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1754013743500281817?=
X-GMAIL-MSGID: =?utf-8?q?1754013743500281817?=
|
| Series |
[v1,1/1] media: i2c: st-vgxy61: Use asm intead of asm-generic
|
|
Commit Message
Andy Shevchenko
Jan. 3, 2023, 2:52 p.m. UTC
There is no point to specify asm-generic for the unaligned.h.
Drop the 'generic' suffix and move the inclusion to be after
the non-media linux/* ones.
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/i2c/st-vgxy61.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
Hi Andy, Thank you for your patch. On 1/3/23 15:52, Andy Shevchenko wrote: > There is no point to specify asm-generic for the unaligned.h. > Drop the 'generic' suffix and move the inclusion to be after > the non-media linux/* ones. > > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/media/i2c/st-vgxy61.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/st-vgxy61.c > index 826baf4e064d..5dcabee6677d 100644 > --- a/drivers/media/i2c/st-vgxy61.c > +++ b/drivers/media/i2c/st-vgxy61.c > @@ -5,7 +5,6 @@ > * Copyright (C) 2022 STMicroelectronics SA > */ > > -#include <asm-generic/unaligned.h> > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/gpio/consumer.h> > @@ -15,6 +14,9 @@ > #include <linux/pm_runtime.h> > #include <linux/regulator/consumer.h> > #include <linux/units.h> > + > +#include <asm/unaligned.h> > + Any particular reason not to keep the alphabetical sort ? > #include <media/mipi-csi2.h> > #include <media/v4l2-async.h> > #include <media/v4l2-ctrls.h>
On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote: > On 1/3/23 15:52, Andy Shevchenko wrote: ... > > -#include <asm-generic/unaligned.h> > > #include <linux/clk.h> > > #include <linux/delay.h> > > #include <linux/gpio/consumer.h> > > @@ -15,6 +14,9 @@ > > #include <linux/pm_runtime.h> > > #include <linux/regulator/consumer.h> > > #include <linux/units.h> > > + > > +#include <asm/unaligned.h> > Any particular reason not to keep the alphabetical sort ? It's kept in an order in each of the groups of headers. The main rule here is to go from most generic headers to the particular ones. asm/* are definitely more particular than linux/* ones. > > #include <media/mipi-csi2.h> > > #include <media/v4l2-async.h> > > #include <media/v4l2-ctrls.h>
On 1/4/23 11:20, Andy Shevchenko wrote: > On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote: >> On 1/3/23 15:52, Andy Shevchenko wrote: > > ... > >>> -#include <asm-generic/unaligned.h> >>> #include <linux/clk.h> >>> #include <linux/delay.h> >>> #include <linux/gpio/consumer.h> >>> @@ -15,6 +14,9 @@ >>> #include <linux/pm_runtime.h> >>> #include <linux/regulator/consumer.h> >>> #include <linux/units.h> >>> + >>> +#include <asm/unaligned.h> > >> Any particular reason not to keep the alphabetical sort ? > > It's kept in an order in each of the groups of headers. > > The main rule here is to go from most generic headers to the particular ones. > asm/* are definitely more particular than linux/* ones. > Thank you for your explanation. Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> >>> #include <media/mipi-csi2.h> >>> #include <media/v4l2-async.h> >>> #include <media/v4l2-ctrls.h> >
diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/st-vgxy61.c index 826baf4e064d..5dcabee6677d 100644 --- a/drivers/media/i2c/st-vgxy61.c +++ b/drivers/media/i2c/st-vgxy61.c @@ -5,7 +5,6 @@ * Copyright (C) 2022 STMicroelectronics SA */ -#include <asm-generic/unaligned.h> #include <linux/clk.h> #include <linux/delay.h> #include <linux/gpio/consumer.h> @@ -15,6 +14,9 @@ #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> #include <linux/units.h> + +#include <asm/unaligned.h> + #include <media/mipi-csi2.h> #include <media/v4l2-async.h> #include <media/v4l2-ctrls.h>