From patchwork Mon Jan 2 20:30:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38193 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4305302wrt; Mon, 2 Jan 2023 12:31:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXsVyBYpx/Phz7/tVMen0ZZQK9CBisfuflwft5WyVgpGSRMU2n0FX4rcVuIbZAyEHrYNYcDK X-Received: by 2002:aa7:dd13:0:b0:463:ba73:9121 with SMTP id i19-20020aa7dd13000000b00463ba739121mr7102936edv.1.1672691510147; Mon, 02 Jan 2023 12:31:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672691510; cv=none; d=google.com; s=arc-20160816; b=PVPhPIp7xqzp7iBLxUCGuti0vIrfmlCbJOrZgsRVtLFvBqMq8eVJdhnStKRqZzOrJv ZJ0eK8KxQ1jqB5PYPtnGGGXfzdSWd3E/wMep0X9NpEdMjNRMIW/XpvehxjcH1BBNffEu y1WIwueMkTjDwCWhQoVu6YZL7v5CV/iB4J7OYsa3+ygmHpwx2x86ZmvinvzOejByXKMD ZOAJsaFQoB3oNfU7dcXd878Gdh87AtzN5raZCtEkb3nl+fXlaCfGY55z60FG2tSsNTfG wGEjB10Uidec9k1wd96oU5Duv/msCWGj//k0sfyqlT5en3d3ITzf60AG0XRLdCZmc6Nl VqlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qWI0/xBggTJaySrsUyYwB3Jm3IdrRv1BE6l40OXBfNM=; b=tl1i+m90LhG1vVrm2HG3G4oam/h6a4xwb22dBeRVD9tSUw61EiyVa7l221iTRFga97 YdAyjjz/uRo6l+kJhK5bi9aPXL+YOVa/TXW3R+2TbfHG3lmQgfCtQm+cKL6BZ6awb+4X M1KjeobHwcHHaJg2IPPJrACZ8K0BtEkMip4mCp6A6eyIQHBmklMZa4MlhzQwsnbkb+/4 EAcAQZNehGwaaPyhWWQ+OC2Em2QUj57O0Xgjzu+6z9xn2+RA9TSxZ371Ptc8NC9q3ENE j1m5TFH4+avACV26HqCdI0TqOpBMTTewNau+tiAeUiowWa4PviCS/UoL+4AX0PRWd3Ya cc7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QWc6GMDA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q24-20020aa7d458000000b004676034f552si22399855edr.45.2023.01.02.12.31.25; Mon, 02 Jan 2023 12:31:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QWc6GMDA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236117AbjABUa5 (ORCPT + 99 others); Mon, 2 Jan 2023 15:30:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234878AbjABUaQ (ORCPT ); Mon, 2 Jan 2023 15:30:16 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2898CB850 for ; Mon, 2 Jan 2023 12:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672691412; x=1704227412; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CFo7ISntdmpoVi76v1LxoXR/BugA3bqZ0RVMplT5JSw=; b=QWc6GMDAk0UB+xZIvCvaOUFT7wj4IMqs2iwyU/gL8vRnDGjO/eyovmBI hytVSkFB6GF6Szuc4VN0ubAfRrZmHRgE9bMeKn50QXkwA7V2k7Wu8X+zD gnvXsAFyNRLK/iqqGSjuV6tO6G5aC9mu4U2iB6hdFlSb8dY4YQkGBiVVN xbv1iDmGecnju36HstRSiVFptbpkwdLpoXn7rl7G3/RvORmhiJ01pdTAC Xjxhu6mwYtTgaD7wyeucsO0cGmLENzig33ytBe/U/AGizfNSDHqFY5okb g0MbRnHCEyiqFKyQ7utyATqF3FRjNOafoFi+Cb/6zlOTo/C8MHMNlDy7h w==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="301224155" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="301224155" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 12:30:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="796962523" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="796962523" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 02 Jan 2023 12:30:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E3A3219E; Mon, 2 Jan 2023 22:30:40 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai Subject: [PATCH v1 5/5] ASoC: Intel: sof-wm8804: Replace open coded acpi_dev_put() Date: Mon, 2 Jan 2023 22:30:37 +0200 Message-Id: <20230102203037.16120-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> References: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753944172988183084?= X-GMAIL-MSGID: =?utf-8?q?1753944172988183084?= Instead of calling put_device(&adev->dev) where adev is a pointer to an ACPI device, use specific call, i.e. acpi_dev_put(). Also move it out of the conditional to make it more visible in case some other code will be added which may use that pointer. We need to keep a reference as long as we use the pointer. Signed-off-by: Andy Shevchenko --- sound/soc/intel/boards/sof_wm8804.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/sof_wm8804.c b/sound/soc/intel/boards/sof_wm8804.c index 54395e2ededc..fbad5a73de44 100644 --- a/sound/soc/intel/boards/sof_wm8804.c +++ b/sound/soc/intel/boards/sof_wm8804.c @@ -269,9 +269,9 @@ static int sof_wm8804_probe(struct platform_device *pdev) if (adev) { snprintf(codec_name, sizeof(codec_name), "%s%s", "i2c-", acpi_dev_name(adev)); - put_device(&adev->dev); dailink[dai_index].codecs->name = codec_name; } + acpi_dev_put(adev); snd_soc_card_set_drvdata(card, ctx);