From patchwork Mon Jan 2 20:30:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38197 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4305955wrt; Mon, 2 Jan 2023 12:34:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXs8UhPrMputGhKwUqCX2fKwS6Z3jEys6BRWKnAWsCXewTYxcN9A1so1XQLjkfgDvk+6jjko X-Received: by 2002:a05:6402:a54:b0:483:d49f:e297 with SMTP id bt20-20020a0564020a5400b00483d49fe297mr7124984edb.0.1672691648649; Mon, 02 Jan 2023 12:34:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672691648; cv=none; d=google.com; s=arc-20160816; b=ZAcjXh5ie52waZnG3p0UXL54PFfHgeey0KC8PStORkhMZhB2bOGTlZvPH5sPmIRHkT SuiZRBz/Ism+wkbRj9JdHW5DVv5rtczMuwZErG2L6BtmLzIpNwTOzdr9hZQnAAPsApuN QjFTYGRxcq1+PNMMOx74UKKwWE68y7VnLSCflnDGuyUOavZZoCmVDcWLwZNzPDI+kfRo 2pf/BRObC4y4oVo8KV7FZ/RAOsdRcykEHTocCpO+FTLEaR/gYOhRLTF8KheAJCyd9ufI InHZH1KMGdsnqlZ75MGxi+9/zKbjhQnjzoIBhtLt7ddzOpoa0z6vKZw0ntJ8C6EG/GnD 1ubw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1MMiMS1pNWRAzjy7fbRdxBNNfpNo4it8wgh3CeJo49A=; b=H5yNkh5KYpBR+/Hl+OCqEn5tKccyBowjxd+PIZZykjEZNTJ3NxLvgwNQktF5Bjkh13 ttgxM6o2TVL6ADw3uFe+Jd78LevYUBmWokxZAricTF6ahF+aj2BG5M2NRbLB3j4EJrH0 FFkeqnd/GkSxfK7CFuMf9+LVvKzrCrZbXcZKBtfIiGalG5cL2nu9pGSAkWwRgWaH9pbg rKrU9ZyiClkGL88YwwQHNBpXi7XhHvz4nY42+6POf0fNuIb9Jbmts3kI0p3kRe6shS3v nBIvWv3e98L2UAD/4UNOHU+PfgsGv7x5Wvc/Riu9387XYbUH4Ut8oE4X9XCzVVSidKJr HUew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=l5JZFs5U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y19-20020a056402441300b004763231785asi28334794eda.33.2023.01.02.12.33.44; Mon, 02 Jan 2023 12:34:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=l5JZFs5U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236454AbjABUbE (ORCPT + 99 others); Mon, 2 Jan 2023 15:31:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235022AbjABUaQ (ORCPT ); Mon, 2 Jan 2023 15:30:16 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 250DEB7FB for ; Mon, 2 Jan 2023 12:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672691416; x=1704227416; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Sj85gbp/SwC5rJk1T732yN9wn+y6PFIsoPKjxU2H1VI=; b=l5JZFs5U3+flDAeT6d0gvRr4yD45dBAMg8oA58EtaIGkdq+FPFHKrEet 3qWX2TG1NGVsGt71ahjKRnJSt6JTL4ytiYJ7M2pueWJdpLrWIfpnhj8ea ETQdkvh/gtNomnmH/n7VPw3xpdhc8BiB/hZhd6JdXcXFkj/PZ2AsyRGVP q0749Brc8Eo+1QJYiTUKSL/f1LcfRzaWeJ6/Cim9gUW+zPX3DMitnkE65 3qHxWJh3/f4UnNg0Lg9e+wMuu/gNbVL2UA+sgiv3GGl8DfZWiXNXWNj1q QZcb7klcts+zqnRyVag3x9UwebIa4eNm5rpO3RiCzSifAMkPwJNIOaqwy w==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="301224166" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="301224166" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 12:30:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="796962529" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="796962529" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 02 Jan 2023 12:30:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id DE4521CA; Mon, 2 Jan 2023 22:30:40 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai Subject: [PATCH v1 4/5] ASoC: Intel: cht_bsw_rt5672: Replace open coded acpi_dev_put() Date: Mon, 2 Jan 2023 22:30:36 +0200 Message-Id: <20230102203037.16120-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> References: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753944318412854621?= X-GMAIL-MSGID: =?utf-8?q?1753944318412854621?= Instead of calling put_device(&adev->dev) where adev is a pointer to an ACPI device, use specific call, i.e. acpi_dev_put(). Also move it out of the conditional to make it more visible in case some other code will be added which may use that pointer. We need to keep a reference as long as we use the pointer. Signed-off-by: Andy Shevchenko --- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boards/cht_bsw_rt5672.c index 49d3da8f7316..daa630a0efc1 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -473,9 +473,9 @@ static int snd_cht_mc_probe(struct platform_device *pdev) if (adev) { snprintf(drv->codec_name, sizeof(drv->codec_name), "i2c-%s", acpi_dev_name(adev)); - put_device(&adev->dev); cht_dailink[dai_index].codecs->name = drv->codec_name; } + acpi_dev_put(adev); /* Use SSP0 on Bay Trail CR devices */ if (soc_intel_is_byt() && mach->mach_params.acpi_ipc_irq_index == 0) {