From patchwork Mon Jan 2 20:30:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38198 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4306156wrt; Mon, 2 Jan 2023 12:34:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXv/NPuQosFrnPVH1RLfPlkUhmY8j2qcqbLkdGHvkhOO++TPx07nq4C9jsZA1Gindnymhu8Q X-Received: by 2002:a17:906:a1d7:b0:7b5:911c:9b0f with SMTP id bx23-20020a170906a1d700b007b5911c9b0fmr8186925ejb.7.1672691695544; Mon, 02 Jan 2023 12:34:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672691695; cv=none; d=google.com; s=arc-20160816; b=YJqsXU/wTGZJukqvlDBDTCkSOD3V93dHufGGvj0sBaaKboxcVU3s0ktWduiajM7Ml+ sxfGTTajuXyJB7tyutdhlQ5YZwideto0S4r/2EGoi7IhTZ3VvEXJqcbkuDloiR0sYaaZ alTxNqsiaMwtO7AsIgI9Gtxgh9AgcCPyp9S3GLpfvkQPxV0a6sxBGeywo+QlyXTy3/Xl nQ301u7lY3jbB6E2S/yTXzFsoVM8ZHkuaVEIujRemN+Pex5gq3NeYpQgogCu6Rp9yWQE 3jNEIfMTawoUcco8ZMZPh4LJ9A1kXnfvQyDnMpJhYM+2i4GGK/n7grt/xKptiDsRtakK l64A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=O1LKuSNOatXVBm6rkVvGZ3AxbqUBYhAr507/aQW7XA4=; b=k/KcX9cBPYk8HPMOoO0z+TNJ6MfvFc/E5hpPWKV5wo3KqJ8YsQlBNjfPJ+2LHxqWkv 82fz4k53HULaMHxM2syIfD2EjLayufqqknkEOZvTq8bI83vM9puoUCPU7PYcq44t0moO i46xP415lXQIBcBacqidC7242PanADJF2Gck0bDOvo5V0VPRK974Znb5x/weFPxwp83k 6TQluMthE7Ckek6ZztfKpoGi4R2aHSX1PhoWj5QrznDEokPNFNatmZ0XwD8ktfCUqHfy lb6PPZtvHr6zdTFqsnSd/qemVBXSxDBdvTynxPRbg9T8Ew45z9ZdgbMfVn6X7raW5kj+ u0Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mZevVdPe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h2-20020a0564020e8200b0048eafc90734si859655eda.544.2023.01.02.12.34.32; Mon, 02 Jan 2023 12:34:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mZevVdPe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236550AbjABUbO (ORCPT + 99 others); Mon, 2 Jan 2023 15:31:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234916AbjABUaQ (ORCPT ); Mon, 2 Jan 2023 15:30:16 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1075FB7F2 for ; Mon, 2 Jan 2023 12:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672691416; x=1704227416; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dLrrjgSaqjRoOiqz+AdzNR8EU6j9NIhl3046q90cLfo=; b=mZevVdPec5YW0LmYTw2EeZADMq29lqzZgO5ZXkmA0BRyrG+HkLWUktEX cR74mVGe1dMX5G94xiDOsYXqLbgigWPwE5sIV6EBQOtV5Xn5+vXwu212P wdB3VVOYOzeLAXqyG7kMQWT/Y4Hzfr4588evLY0stRjtMlER6LaIYjRVt Cch4lGEmkwaNJIpNhcMyNF0Z9X17Eqq+C7GhzLb5CaebU7brinrKRAJjm 8DD+NF+xU55sonPZPnlpAySrOUoiLvAKpmz8igyxh9Z9EsRxth1sTym2U S3J6zGu/O4RTDFiJLXJcnEGskPxm0XZmHL44L8jdCXkS+x+h9yMKnHjPl Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="301224160" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="301224160" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 12:30:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="796962531" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="796962531" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 02 Jan 2023 12:30:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id CFEE6162; Mon, 2 Jan 2023 22:30:40 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai Subject: [PATCH v1 3/5] ASoC: Intel: cht_bsw_rt5645: Replace open coded acpi_dev_put() Date: Mon, 2 Jan 2023 22:30:35 +0200 Message-Id: <20230102203037.16120-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> References: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753944367147541348?= X-GMAIL-MSGID: =?utf-8?q?1753944367147541348?= Instead of calling put_device(&adev->dev) where adev is a pointer to an ACPI device, use specific call, i.e. acpi_dev_put(). Also move it out of the conditional to make it more visible in case some other code will be added which may use that pointer. We need to keep a reference as long as we use the pointer. Signed-off-by: Andy Shevchenko --- sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c index 25a054bd4073..875bc0b3d85d 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5645.c +++ b/sound/soc/intel/boards/cht_bsw_rt5645.c @@ -581,9 +581,9 @@ static int snd_cht_mc_probe(struct platform_device *pdev) if (adev) { snprintf(cht_rt5645_codec_name, sizeof(cht_rt5645_codec_name), "i2c-%s", acpi_dev_name(adev)); - put_device(&adev->dev); cht_dailink[dai_index].codecs->name = cht_rt5645_codec_name; } + acpi_dev_put(adev); /* * swap SSP0 if bytcr is detected