From patchwork Mon Jan 2 20:30:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38194 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4305303wrt; Mon, 2 Jan 2023 12:31:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXvvboA1FueXKmJ3NKOLJ6LCRCB8pkzWWikXipQ/1obwR2bo2LaZszmwvglKHaMJ2mHM7E7w X-Received: by 2002:aa7:dd13:0:b0:479:8313:2fe6 with SMTP id i19-20020aa7dd13000000b0047983132fe6mr7372641edv.1.1672691510074; Mon, 02 Jan 2023 12:31:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672691510; cv=none; d=google.com; s=arc-20160816; b=gZSfjSubdiXPeHznA2EDGYU1wni9sBOrOUkYg8ko/Y5yPI6CD/kktvjG6pY3q8GQx0 gswmcq0SnhGrSk5K1eeH8+rFQNiksLQ4+Htl84IkC6Y0zma7NVQ0njZBBN+UHyn2zewE 5dRsTbs/ly9GLSnLlAlXskAKqwH9L9GNU0e9QhmAcnYM+05Cwg3PSQL9IQ3kbCp231Pc PDnPi9mO0I9cYdShv+FrBYJnWQUv7XGn2la58nv262v+tgDxWPt03OYURmacFLaUBve+ ypRVo4Nh3ccnaJ1LFb97tZx2MWDFWpRnQJfFpQXBba68npsgffjd2oFdj6vvtcs45ktY I2Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9sgRBnLXqh+gbOHbX6WRhzRO6Ne4nPqSZA8mdEfwCNk=; b=BJnUr6JN8tWOrr992xRUKvFWwGlIeksc/SFb6LE1Q+o1+SMLGSIUY67XBS5yUf5tCd hFKZ+0wxDMFcvIWXp92yWYobw3maxLQkY6c3pf3a03rCCrC/m2oGD7BosTNJWCtIFvIH tZUUsTdgReGBbkE2yEW12ReaZ+DwVj5bHxr2KqbLry7j6XSpafQnXO0xXHwZofF28byl sDL9SI9tIKc3dpPZlXBQh0N3eG/saGNEwJ7Rl8wImKeSEw9fgIvzdtEpTBa4Am5b/Snl 1QzE7jBpldopgRQsOOG0Bi/hzJalR/YqyekHbPST/NlmYUwL0qJZT8j6QPTU+RGNtHPO f7XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NV7CMRfi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y9-20020a056402440900b00478b85eed04si30542858eda.561.2023.01.02.12.31.25; Mon, 02 Jan 2023 12:31:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NV7CMRfi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236423AbjABUbC (ORCPT + 99 others); Mon, 2 Jan 2023 15:31:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232366AbjABUaN (ORCPT ); Mon, 2 Jan 2023 15:30:13 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D33BE1C for ; Mon, 2 Jan 2023 12:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672691412; x=1704227412; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aAfymOW/PhGFtC4itped/S1oIrcSAbEZCmbLAIqF9mc=; b=NV7CMRfi5nn1XGhrODdveXeJKeovzp5Uw4MghwfyfhaAUrTk//AbAxg2 ue5RJqxAzgXf8DAVep8Csfn9L6Pik+zeRNFFjrMfTAyZhqn7X7UpV68r/ Hd/7I8CiStFpims29zTFPjK7dp31zOuabTWRtE8aPXkhoamRtQBILMKhC AwG7DgJljlJ5UNkGeJRLnAk6nJQWdn4Olmp+ckb6Rvm1c4Lrk1n0xCEtp X4Ml6c3R6Y3bWKSvVeg9lxVk7TTA2z0vYigekKQF5uFT0omkRxOMMmfGz VngUY3L1+z0iSd3FKseHq7Yf9YQvqYCvBV1Zd6K2SnnzVKZAl6FKbk4hI g==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="322772210" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="322772210" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 12:30:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="686987612" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="686987612" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 02 Jan 2023 12:30:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C64E984; Mon, 2 Jan 2023 22:30:40 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai Subject: [PATCH v1 2/5] ASoC: Intel: bytcht_da7213: Replace open coded acpi_dev_put() Date: Mon, 2 Jan 2023 22:30:34 +0200 Message-Id: <20230102203037.16120-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> References: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753944172948937584?= X-GMAIL-MSGID: =?utf-8?q?1753944172948937584?= Instead of calling put_device(&adev->dev) where adev is a pointer to an ACPI device, use specific call, i.e. acpi_dev_put(). Also move it out of the conditional to make it more visible in case some other code will be added which may use that pointer. We need to keep a reference as long as we use the pointer. Signed-off-by: Andy Shevchenko --- sound/soc/intel/boards/bytcht_da7213.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcht_da7213.c b/sound/soc/intel/boards/bytcht_da7213.c index a0c8f1d3f8ce..a3b0cfab17b0 100644 --- a/sound/soc/intel/boards/bytcht_da7213.c +++ b/sound/soc/intel/boards/bytcht_da7213.c @@ -256,9 +256,9 @@ static int bytcht_da7213_probe(struct platform_device *pdev) if (adev) { snprintf(codec_name, sizeof(codec_name), "i2c-%s", acpi_dev_name(adev)); - put_device(&adev->dev); dailink[dai_index].codecs->name = codec_name; } + acpi_dev_put(adev); /* override platform name, if required */ platform_name = mach->mach_params.platform;