From patchwork Mon Jan 2 20:30:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38196 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4305952wrt; Mon, 2 Jan 2023 12:34:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXvv6Lq0afVheL1kPa3ap1CK4Qv0R7EllL7LjQkn9qpSxwXBwQ7EXEKwSTuwwqzg00Klcf9K X-Received: by 2002:a17:906:2859:b0:7ad:f6f3:4500 with SMTP id s25-20020a170906285900b007adf6f34500mr8973633ejc.7.1672691648158; Mon, 02 Jan 2023 12:34:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672691648; cv=none; d=google.com; s=arc-20160816; b=nWlsabc3UlD1FUrPk7ktYqt/UTeqhkq5dOO+8KkT2BjJGMZg8cQgLCJeQX33CVq1di /PBnemppzoSWgbnFXROc+hD0hxuf+UmL9IvSoFenv5NxHB30D/7udYdsZ6vBTBiN6CbB alaTcUW/gBQwunGa3S4MCuNH+04g24VmbQm5zyZwlT9+3wL/0g+gqDyA9rr3t4fIMhL/ 5v3QmJbTqs1Q+1GK86foktFybvuVWMZ9BOfKjVU7sKueNInWC6p7lyppHb3TLQtA9lOL ixcklo0KmBQaIq57IFP+A1smheY1gX3h9NR9WF8TIn7k9q8K4a9QUipkZU2p2IktSxkX gyBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wAw3YzC6rSNQ1RW+flAI5r0wJFIO7LFOT/FOfLfClSE=; b=OTwjL67rsb+7ojwMy6xR0I4CUGeHWMC43dDC0mVvXdyt/ZCGLycJAFyYLHAAXL5xua l+VpWJ9myI3fcTwxzGOqYZJ7ZTGeZT+cNC0cH9K09qfwckVg4aiQxU2/QAZDsip/eNlQ xUWeVHgzDC8zUcM1uX+7htDmn7M/0IhtEP78/PlAW96U0bbLXR0TtoWF/Hqi8HFus+rO 3hOkL2rrDU7SPSU/5/ftz2s9pxEc5EiAFch+Lrr+ZbynYyBXpZbbakvrbau8t642oPAV QH0MbskIsRW5xWeOLVnithOquYMsw7zPNpz5/9msarXFWXylfhAwQXe5vOToIxzyZ/hY SFqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eBq2D53w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs16-20020a1709072d1000b007c4f6c37193si27075431ejc.223.2023.01.02.12.33.45; Mon, 02 Jan 2023 12:34:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eBq2D53w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236482AbjABUbG (ORCPT + 99 others); Mon, 2 Jan 2023 15:31:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235165AbjABUaR (ORCPT ); Mon, 2 Jan 2023 15:30:17 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6C17BCB2 for ; Mon, 2 Jan 2023 12:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672691416; x=1704227416; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JI+WQ+s6ndDirdEdZjDMNLxkK54gtzgsBmmyNW4/rLc=; b=eBq2D53wt5s4cTasAXQg0vlZKbEDf0oiT7ZyDYNvuG8D+ASRGS8uXdCt nZG7YTcVGPYnxQt/eRqxhNpdaGpL24QXdn+7xhfeZ6+I23HPtOBis7nyT D1BK2KYi6KhEDwu7xrxTO8yaMlQF+9ZlTv2ng1gn9ryYQpP2j+vS2x6Co ZMsVpSuyUcnXyT6oKvD/GRQraPO4iXkJAUlYIwsU1t7JdfJzxA5SAZ+6I NAMgCxTIWNyCrnM97YjhdgMPojdpC8mS6BFucNaXZRxVpfEBk/hqKhZ0D nMpxiE4pCn6JLhVctMJwmEJwADuVvMccke0Eh9QgRAIVm51sqRaRf1dCy A==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="301224171" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="301224171" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 12:30:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="796962530" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="796962530" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 02 Jan 2023 12:30:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id B78B6F4; Mon, 2 Jan 2023 22:30:40 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai Subject: [PATCH v1 1/5] ASoC: Intel: bytcht_cx2072x: Replace open coded acpi_dev_put() Date: Mon, 2 Jan 2023 22:30:33 +0200 Message-Id: <20230102203037.16120-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753944317946162929?= X-GMAIL-MSGID: =?utf-8?q?1753944317946162929?= Instead of calling put_device(&adev->dev) where adev is a pointer to an ACPI device, use specific call, i.e. acpi_dev_put(). Also move it out of the conditional to make it more visible in case some other code will be added which may use that pointer. We need to keep a reference as long as we use the pointer. Signed-off-by: Andy Shevchenko Acked-by: Pierre-Louis Bossart --- sound/soc/intel/boards/bytcht_cx2072x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcht_cx2072x.c b/sound/soc/intel/boards/bytcht_cx2072x.c index 41cec67157b6..9942a2de6f7a 100644 --- a/sound/soc/intel/boards/bytcht_cx2072x.c +++ b/sound/soc/intel/boards/bytcht_cx2072x.c @@ -253,9 +253,9 @@ static int snd_byt_cht_cx2072x_probe(struct platform_device *pdev) if (adev) { snprintf(codec_name, sizeof(codec_name), "i2c-%s", acpi_dev_name(adev)); - put_device(&adev->dev); byt_cht_cx2072x_dais[dai_index].codecs->name = codec_name; } + acpi_dev_put(adev); /* override platform name, if required */ ret = snd_soc_fixup_dai_links_platform_name(&byt_cht_cx2072x_card,