From patchwork Mon Jan 2 20:30:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38192 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4305301wrt; Mon, 2 Jan 2023 12:31:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXt0gM2cyd9PxTrQJviRrmr8AGjxyBCAhjkti8ngE27rRTZGguIt2zYV6wg+e61UE1YGiUPI X-Received: by 2002:a17:906:9c8e:b0:7c1:6150:ad2b with SMTP id fj14-20020a1709069c8e00b007c16150ad2bmr9285611ejc.0.1672691509881; Mon, 02 Jan 2023 12:31:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672691509; cv=none; d=google.com; s=arc-20160816; b=xa4H2vETlN3g9T5CaPvLNspxoKQtD8vdD7W/DDWgKZl+7Aos5FpXY7pCZ3Ia48CFNe U1bl6QU9wyUMwsl6fNMR/9+l4moCPZxwV4iPqD62Tk99HhFNtTWo8m2bhbCnRre/ue5U D4OXYR+TBPce8O4AhKMsSnq6R+wxowEwnah2PO+tE9LtV98WCzfRVjnpnV0m5V/OCcal Q0egj8w9dW2Z+j4K8D/oTdwja4aWVpqLxR7ktIlzIC0Fy32A5cQN2xMQ0rrE66bvCbQN xsdMvpogobOBWuATXAy4tcddW78IlHnBDBmo4k4QvIOBbOTgagEfJI55z9wR7i+v8QlP +xMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Wk0/bnxEHUueHhjb7cEOTGijZnmko6H2F5VXSA36FHA=; b=ktVRwMNMdSEtx/wLz0D9JuAPbRoTCmnijEwKe+BKdnXWFlxb7GG5QEuUdXSmx9fw0k xNVUVSM/dOBSYVihR6hRBLhnGqfaW/GisLXlVa2e+Y5QeKqGqSBkPhJMne5X6bxko02M LS6uVr1MAEFpca/gcGC+zGcVUVe23/1ogupiFGVGGYhSaL3WaGy3vLHUBfaYV5044x10 +86cwsOeiHo/8m0ADX9TY0EdTXss7jBVLtI7U7OcSGuWsahwVy5XCLqctwaXAXQmIsxR nOqghHj9+RmoY/8TcaDFWKk1E1sJ1j7iOiw4NIf+3r1Xcjcc1G6YPxdV7UBWj+5MgJ0R xHpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RFH3Gp0V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wt8-20020a170906ee8800b007c4f9ce306esi25235068ejb.729.2023.01.02.12.31.25; Mon, 02 Jan 2023 12:31:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RFH3Gp0V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236022AbjABUaX (ORCPT + 99 others); Mon, 2 Jan 2023 15:30:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236368AbjABUaG (ORCPT ); Mon, 2 Jan 2023 15:30:06 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0353FBE1A for ; Mon, 2 Jan 2023 12:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672691403; x=1704227403; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jaaT5T3K18xgkyMdPptdmWzbRbrNy2o8GnbiBUb2YQg=; b=RFH3Gp0VtnTiD9Zs2wqVbbgn0KECLOPMWXn8EGFAmpIHs6zdDgiEWA4v hDCBMrgYr0LQgWx6aTFSXq8QoEwITWHvSzaP/anxbujPQN3H3DZBq2zB8 eHE1jvjyptzpBWWYZ47pSJHvQ6NjI4nvOkTdpqaNSfD4vuQMvzOsfFWbM +AhjpMzqOAZQUXnq/BT14PI0vJGqRUYBi0NTDNSfYzhagK6b50XmW4aaE uFa7HxBAGd4e5w3SY9Vo+MJ4KjywSfrvNMz0Dykv1aBA5BbA1oq18f8LK M9otb+oQSr7WNZunpwDTbQNha0xZcmineWFtH4L69VHPi6QnzQtyELKyR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="321602419" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="321602419" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 12:29:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="717889962" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="717889962" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 02 Jan 2023 12:29:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D6DAF1CA; Mon, 2 Jan 2023 22:30:16 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Vijendar Mukunda , Hans de Goede , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Andy Shevchenko Subject: [PATCH v1 5/6] ASoC: Intel: bytcr_wm5102: Drop reference count of ACPI device after use Date: Mon, 2 Jan 2023 22:30:13 +0200 Message-Id: <20230102203014.16041-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230102203014.16041-1-andriy.shevchenko@linux.intel.com> References: <20230102203014.16041-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753944172713656247?= X-GMAIL-MSGID: =?utf-8?q?1753944172713656247?= Theoretically the device might gone if its reference count drops to 0. This might be the case when we try to find the first physical node of the ACPI device. We need to keep reference to it until we get a result of the above mentioned call. Refactor the code to drop the reference count at the correct place. While at it, move to acpi_dev_put() as symmetrical call to the acpi_dev_get_first_match_dev(). Fixes: 9a87fc1e0619 ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102") Signed-off-by: Andy Shevchenko --- sound/soc/intel/boards/bytcr_wm5102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c index 1669eb3bd80f..c0706537f673 100644 --- a/sound/soc/intel/boards/bytcr_wm5102.c +++ b/sound/soc/intel/boards/bytcr_wm5102.c @@ -411,9 +411,9 @@ static int snd_byt_wm5102_mc_probe(struct platform_device *pdev) return -ENOENT; } snprintf(codec_name, sizeof(codec_name), "spi-%s", acpi_dev_name(adev)); - put_device(&adev->dev); codec_dev = bus_find_device_by_name(&spi_bus_type, NULL, codec_name); + acpi_dev_put(adev); if (!codec_dev) return -EPROBE_DEFER;