From patchwork Mon Jan 2 19:24:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38180 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4288595wrt; Mon, 2 Jan 2023 11:31:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXvILnjJnp0tttu7j+OcRV+2srUMebfdetjNm+6y0BbImZfzKpiydnkevMz4DIuLhKzn2KDo X-Received: by 2002:a05:6402:c95:b0:47e:33e2:6097 with SMTP id cm21-20020a0564020c9500b0047e33e26097mr7873882edb.1.1672687864862; Mon, 02 Jan 2023 11:31:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672687864; cv=none; d=google.com; s=arc-20160816; b=cwYr4oVygoBRoyYWACsfVd4CtLYJ+VEBSRFLUtUxjcTowiMPH2jqGEY1rR2C9si34f dqZP5STPCEIzpfkA8kKZjAXc5X3+Pcm2N6x2LSx+uwkntixO0ysNSzoRXLp0MmL6+3UZ fLt+OUTNsEevtkrSBonN+4ZzDjRbQZMvGltMO5fSTNp7rzD/BMafDwbLshGS7C/2M05Q 36q9BKmW4W8W2F14SuIVQGAKhFRlARnN5GAIquE35iZjEegM9z/hNtJEWlZN/A2cm2+o ZWdJjYVOsXEO+/vHJrAU1VpL59/CdAEtaj27gJAuZKA3G7u7Z974ny2Hj7/HI5S+5gM9 5otQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4QFEtiF4lNs3qTz5w2N/DVD7Ui3nKDhrs9cjmIOoyW8=; b=eQrqwDgPtIyksXoc7eyJIt9uf69znf2JUpjsoVRRyzYc/CEN6izSfqsE2Cum4qsIqI HDoDoKc16/qKDtQWBGkycHovCh4XCo/iQ1NTNtz2apxD/OCS+bnAwTCOspaTDBC9ELPA Oc106YrYtHDLz9E/1LPw5JS9SV7J5wh5m68v3b9aLlIZpwq32ME62ltWp211HNmymzNO X6tSTEcrXaMMlFcm53dXqeyFfUL2vZLsvIPtIFoPbXomB+JAI2PukXPKXHC9FxZijpLd 1LJ611yRm2cXuiANNfg2MfPhvHdn8AHGv7c4HAAoB6uQ0dnFBRBfA6HPD5AnkkdG7Cx8 be4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="cf/yVat8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j16-20020aa7ca50000000b00487b286dfd3si13386584edt.23.2023.01.02.11.30.40; Mon, 02 Jan 2023 11:31:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="cf/yVat8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236072AbjABTX7 (ORCPT + 99 others); Mon, 2 Jan 2023 14:23:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229740AbjABTXo (ORCPT ); Mon, 2 Jan 2023 14:23:44 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E11DEB7EE; Mon, 2 Jan 2023 11:23:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672687423; x=1704223423; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gu+Dt/OpMWKrwg8VxAt76Mz52M2Dfk6IjKqn21EscSM=; b=cf/yVat8r7Cw12YKdWEiFL36x91ZlTuON6WXYwtyU48GbZ6JtXUV67FP Cv6TwvUgLtxF5uWK3xXGx5qzJ8naIDbRrZCgxOPk0Zv1RQ9luGFSR0bMF RVYdc5q4szYx6D7AE0jb9FED/q7lU1FbB5qRr9WSzUx+o4EMr8txrHe25 yUhTW7jy/JDdkrWHImNsymbvGV8LC0VaKLtXmNzALSKazMp36Zltbjj8e w6NYCW1FRlNdYu3iDhUAxm3JiMR/nDKjdrWzPpffXj5Go6zf+Z92eqq7k N5AjMsx9RCM4N9dHd+6OqNHhv6De6dGrMIkAK1BkgYgxSQaqUO7E1J5ez Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="305040242" X-IronPort-AV: E=Sophos;i="5.96,294,1665471600"; d="scan'208";a="305040242" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 11:23:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="778638990" X-IronPort-AV: E=Sophos;i="5.96,294,1665471600"; d="scan'208";a="778638990" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 02 Jan 2023 11:23:41 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6438FF4; Mon, 2 Jan 2023 21:24:13 +0200 (EET) From: Andy Shevchenko To: Mika Westerberg , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , Andy Shevchenko Subject: [PATCH v1 1/1] thunderbolt: Refactor tb_acpi_add_link() Date: Mon, 2 Jan 2023 21:24:04 +0200 Message-Id: <20230102192404.88076-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753940351012282345?= X-GMAIL-MSGID: =?utf-8?q?1753940351012282345?= Convert while loop into do-while with only a single call to acpi_get_first_physical_node(). No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/thunderbolt/acpi.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/thunderbolt/acpi.c b/drivers/thunderbolt/acpi.c index 317e4f5fdb97..628225deb8fe 100644 --- a/drivers/thunderbolt/acpi.c +++ b/drivers/thunderbolt/acpi.c @@ -36,16 +36,13 @@ static acpi_status tb_acpi_add_link(acpi_handle handle, u32 level, void *data, * We need to do this because the xHCI driver might not yet be * bound so the USB3 SuperSpeed ports are not yet created. */ - dev = acpi_get_first_physical_node(adev); - while (!dev) { - adev = acpi_dev_parent(adev); - if (!adev) - break; + do { dev = acpi_get_first_physical_node(adev); - } + if (dev) + break; - if (!dev) - goto out_put; + adev = acpi_dev_parent(adev); + } while (adev); /* * Check that the device is PCIe. This is because USB3