From patchwork Mon Jan 2 17:34:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 38170 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4255369wrt; Mon, 2 Jan 2023 09:44:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXt3BolYZMDfm+Fm9B5lKsKjc8olqDPoC/GjzyW7DCdMtCRXgAh88GUxa49IEypn9edJkBUy X-Received: by 2002:a17:906:5494:b0:841:e453:af80 with SMTP id r20-20020a170906549400b00841e453af80mr9528916ejo.5.1672681480855; Mon, 02 Jan 2023 09:44:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672681480; cv=none; d=google.com; s=arc-20160816; b=mHmsOFmAqEKTzDNYTnR56t6GtUe1wHCd4mrkmlbfssxHf3Lm+dPPCT20CZrv3A22nT vkuidcvEK7Z9kVIJtoS+WeV0cuIt/RJZwyDgFABDsKVJ2ZF3pC8psOCtSP48EVPeHoKG xc3pRWUdUl0Alp0JiGdK/YryLwoj85t+CJRmrIwZq2BmtCw/EcG3UWBeuxz9zebNgZ7O Mod1hEDx5s+KEl4NZhPn6gKwXyl/WBzXGae0yCJ8AxcY3/9NeZgK+vXpl5sf+1mkhgN4 TODVF46v+AyiyfwEczkthkFYQl0U5oNITlaXx8YxsX2Sr6KWzu8CJKeh8jKmhO8j5KgC JnSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7Ie80IyTJVpY/m4Pk+67Ipglv2PCHNoBOGsnCsKQCoU=; b=PCfWpji17BoYwoWwsUzUHUGW8Mw0scPlblilA08+OLiaOrD+a3RB5buhJSBKrjivjZ bQiTGeyp59yfiX1bHVbxzNGmpPvOY9ksQ4cqxbMowG+mkfSEZNfkpn10tZcFJR8ztLWT uM994C8NWuAxLjqVNbWt1xACQuKyBaSlggn5b/4pgFGX+lmA94BDPprENoSID/hhq0DS dqKQ8LFOQZYwJ9w5J8USkrbKNmC1oYB8QJY48SUiP0uTOd4eGclAX/N6w/WrMiBixpjA /olKwu9pI76uIg98BEdrvzrI+Q3yKHIf8XVmSUMd3koRkcUWWjhIn/VQ87Rhei0AW2Ix Cwbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VpCQDURF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga22-20020a1709070c1600b007acbac0871csi25329174ejc.420.2023.01.02.09.44.17; Mon, 02 Jan 2023 09:44:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VpCQDURF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236275AbjABRee (ORCPT + 99 others); Mon, 2 Jan 2023 12:34:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234924AbjABReZ (ORCPT ); Mon, 2 Jan 2023 12:34:25 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 131A3BCA; Mon, 2 Jan 2023 09:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672680864; x=1704216864; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SCU7ycnxB3zii0W95wguPLD/q5qBT1vuhKpdekHvQos=; b=VpCQDURFf78y1snCyVGS5MtsdFHqkBZqj2RykeK89ksYwBbU+siqYXno LI++/NZ33eWgYyOx8y5F+RsIO28HnqSJg4NMJMs73LxC2iasYK1ufWaBk Ksd6NZQw54VC8FEyt27k9r4SFWKeBOjDvxowWy73xaY4ObpaeUogATPb0 Fr6DbcC3Tr+MgkPP3rU7tZH+mUG4NHi6nSG+kWt+XtbiFioDEw5xEalMX BqBGUY12OTlsz01alBHPwRnqAlLoY87VwFiEtMShfEPljFzo95HN2BlkB VsB/RJCPN9Zsi79ilGc9D7EB5qHBPoXOZiRZaw1zkDWIIMN1H+BGpvdgv w==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="322752810" X-IronPort-AV: E=Sophos;i="5.96,294,1665471600"; d="scan'208";a="322752810" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 09:34:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="686951024" X-IronPort-AV: E=Sophos;i="5.96,294,1665471600"; d="scan'208";a="686951024" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 02 Jan 2023 09:34:21 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id BB051162; Mon, 2 Jan 2023 19:34:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen Subject: [PATCH v2 2/3] iio: adc: ti-adc128s052: Drop anti-pattern of ACPI_PTR() use Date: Mon, 2 Jan 2023 19:34:49 +0200 Message-Id: <20230102173450.29882-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230102173450.29882-1-andriy.shevchenko@linux.intel.com> References: <20230102173450.29882-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753933656733213854?= X-GMAIL-MSGID: =?utf-8?q?1753933656733213854?= ACPI_PTR() is more harmful than helpful. For example, in this case if CONFIG_ACPI=n, the ID table left unused and code is obfuscated by ifdeffery. Drop anti-pattern of ACPI_PTR() use. Signed-off-by: Andy Shevchenko --- drivers/iio/adc/ti-adc128s052.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c index 4a15b6bea310..0f737e9df0fa 100644 --- a/drivers/iio/adc/ti-adc128s052.c +++ b/drivers/iio/adc/ti-adc128s052.c @@ -9,7 +9,6 @@ * https://www.ti.com/lit/ds/symlink/adc124s021.pdf */ -#include #include #include #include @@ -201,19 +200,17 @@ static const struct spi_device_id adc128_id[] = { }; MODULE_DEVICE_TABLE(spi, adc128_id); -#ifdef CONFIG_ACPI static const struct acpi_device_id adc128_acpi_match[] = { { "AANT1280", (kernel_ulong_t)&adc128_config[2] }, { } }; MODULE_DEVICE_TABLE(acpi, adc128_acpi_match); -#endif static struct spi_driver adc128_driver = { .driver = { .name = "adc128s052", .of_match_table = adc128_of_match, - .acpi_match_table = ACPI_PTR(adc128_acpi_match), + .acpi_match_table = adc128_acpi_match, }, .probe = adc128_probe, .id_table = adc128_id,