[2/4] media: dt-bindings: cedrus: Make allwinner,sram optional

Message ID 20221231164628.19688-3-samuel@sholland.org
State New
Headers
Series Allwinner D1 video engine support |

Commit Message

Samuel Holland Dec. 31, 2022, 4:46 p.m. UTC
  Allwinner SoCs can remap some bits of peripheral SRAM to a contiguous
range of addresses for use by early boot software. Usually the video
engine's SRAM is used for this purpose, so its mapping must be switched
back before the hardware can be used.

However, the D1 and related SoCs use the DSP SRAM for this purpose. As a
result, the video engine SRAM is not switchable, and there is no need
for an allwinner,sram reference in the devicetree.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 .../bindings/media/allwinner,sun4i-a10-video-engine.yaml         | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Krzysztof Kozlowski Dec. 31, 2022, 7:06 p.m. UTC | #1
On 31/12/2022 17:46, Samuel Holland wrote:
> Allwinner SoCs can remap some bits of peripheral SRAM to a contiguous
> range of addresses for use by early boot software. Usually the video
> engine's SRAM is used for this purpose, so its mapping must be switched
> back before the hardware can be used.
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Paul Kocialkowski Jan. 5, 2023, 9:57 a.m. UTC | #2
Hi Samuel,

On Sat 31 Dec 22, 10:46, Samuel Holland wrote:
> Allwinner SoCs can remap some bits of peripheral SRAM to a contiguous
> range of addresses for use by early boot software. Usually the video
> engine's SRAM is used for this purpose, so its mapping must be switched
> back before the hardware can be used.
> 
> However, the D1 and related SoCs use the DSP SRAM for this purpose. As a
> result, the video engine SRAM is not switchable, and there is no need
> for an allwinner,sram reference in the devicetree.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> ---
> 
>  .../bindings/media/allwinner,sun4i-a10-video-engine.yaml         | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> index d5be7f604e8c..74363b242fff 100644
> --- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> @@ -73,7 +73,6 @@ required:
>    - clocks
>    - clock-names
>    - resets
> -  - allwinner,sram
>  
>  additionalProperties: false
>  
> -- 
> 2.37.4
>
  

Patch

diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
index d5be7f604e8c..74363b242fff 100644
--- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
+++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
@@ -73,7 +73,6 @@  required:
   - clocks
   - clock-names
   - resets
-  - allwinner,sram
 
 additionalProperties: false