From patchwork Sat Dec 31 09:58:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 37818 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3278695wrt; Sat, 31 Dec 2022 02:09:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXuHr+a91H+K67ueTcrzOmgkWxa4t0mICUSwpnA6lDNK69XfPJ2qH0qEuv8RPYy+GdYFUDry X-Received: by 2002:aa7:9a10:0:b0:582:33b4:4c57 with SMTP id w16-20020aa79a10000000b0058233b44c57mr1307320pfj.33.1672481353775; Sat, 31 Dec 2022 02:09:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672481353; cv=none; d=google.com; s=arc-20160816; b=tQSSq0b3zPfN0652OyUHgIvrDO6cdnIfTLm7Qp+kCVSKEuLfox1cn7D3a7tVCJprhZ 0YLOUrMDF2VyGAeUgEgfWWNreWwXCxTfto9G4c818bGWAh0MFgZkAmKghfF9BGhl5PhC 2rSDMGuzHgGXq1ih2m1b0VUV6rImKRYT3UXrKKgdcLXJpb6Z33lxbSppc4FPNKazK50C bx7TELYTSZGiGksxGbouL20ixCrP71NIFSIa+F8bBW9SPjlamQ+wupRAi9iobOV91yYI b7bqYxqApvo8Jmvl/5BxwX5nZDyyd/WoMHPIFKw1cL1Sv+ak8FY37EsmrVt+/tzfMVBZ qCaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=c+mH6yo9QDzH3j2h09MnjaYAWpR4f/pKw+YySSE9cdM=; b=mRkGXaY/719eyArcVfSdfEipJQvn1jZPjqawiIwGzMpRgrnTV+b9tWiMBDYhv5wMhs tIAm20qFtIQ0+awDbu/r7R9AyGev7IsixV1ZCt2wx3N4EC7kosIRYsTH0lYo5ieuL8J4 /WN+ExpyxKOEk1+0f9zFxfl2RswWFdRKBoWrfUCzaIdDfFJOy6biFD1inkCOHuWMVitC 9q0Fzn/CvbHEEzcSirTFT+B5mDhh65pRDN5YbUYADJAOpYsQXUwuI4qG41zlRbS0pa8k 071z3XC2+9AuAQ8sem551ihACApWJHgyNDIFQQQlikoLRHkeQq4Tk4oQMqIGeJSgQHUu moQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="fRK/PdfP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n56-20020a056a000d7800b005820c13b6e6si3023704pfv.320.2022.12.31.02.09.00; Sat, 31 Dec 2022 02:09:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="fRK/PdfP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231699AbiLaJ7F (ORCPT + 99 others); Sat, 31 Dec 2022 04:59:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiLaJ7C (ORCPT ); Sat, 31 Dec 2022 04:59:02 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BC4AE0C6 for ; Sat, 31 Dec 2022 01:59:01 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id b145so11710759pfb.2 for ; Sat, 31 Dec 2022 01:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=c+mH6yo9QDzH3j2h09MnjaYAWpR4f/pKw+YySSE9cdM=; b=fRK/PdfPbHcHarX93IwTpy/Ytq/F07RTxGR6RD/gj/F9Sxo+MKI9gDZ4FA2FOxsRPq VPo4+eZzOMMydHrWh+mBvPP4NY6L9kj0/WMcG/yW10m3NaMKnsyIy7tZ+uNzqFZ8PqkN KzrLBw9BMP8p3fXse0VXng/zXsJ2JSc+nCv3MSShNjrR/Ye4wtm/al5QoRQ85eNZSz+t W7hUDVpUhmQ0VhW7mD+d5uKpxJTKPOWvPo6gFDNK2cWb9kClTn8DHNSD2e5ubcC8OPCi zxtKsaeRe8RCeEUQtrfZJLcgzxNbV3M/rTrhTFtE0OXB2lMrvNPWMfRtXtla1jhObyYF krGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c+mH6yo9QDzH3j2h09MnjaYAWpR4f/pKw+YySSE9cdM=; b=O1HROAe28jp/cqCeBjNrn7YWNE4J1VUcX3UTEJcTAQZwglE1sRRTxkwkcjW3iesCuB vSeWDa6yDsdSQWkHc8zGPcTjd979MUnLIZLhjNfW5N25bFMKcA9UIqUv2EwlKanVr3xt Cn+h0WcJNIOVsH6xZJU+nisVry1Y08KKBo3EnHnI0KSxYJVE704E9mtmS+HMO8Jnwpgz asFnK6+6p0ej5vWHtdQr3pbRKlaCwmaMdoF0ApKOwo/zn+ZWBJksM6ilzXEap4vaiiKO qjvtzfu0gQLwltFRV+vRO9X/pbhrF3a45hrb9FR5edzswPQccMZ4cOgMJkf0hrAZZQ7+ LkCw== X-Gm-Message-State: AFqh2koKU64EQys2QEqKMZ8b80QCQxs7pH6SyNhl0hR9U+I9+YVNBY4k j87VfYmmHdKkgIr9ETMyvr0= X-Received: by 2002:aa7:960d:0:b0:56c:3fba:c5ca with SMTP id q13-20020aa7960d000000b0056c3fbac5camr52384277pfg.16.1672480741039; Sat, 31 Dec 2022 01:59:01 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id i128-20020a626d86000000b005768b4f2d0dsm15128137pfc.64.2022.12.31.01.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Dec 2022 01:59:00 -0800 (PST) From: Miaoqian Lin To: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Xiaolei Wang , Lucas Stach , Miaoqian Lin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: imx8m: Fix incorrect check for of_clk_get_by_name() Date: Sat, 31 Dec 2022 13:58:48 +0400 Message-Id: <20221231095851.2573710-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753723808147744036?= X-GMAIL-MSGID: =?utf-8?q?1753723808147744036?= of_clk_get_by_name() returns error pointers instead of NULL. Use IS_ERR() checks the return value to catch errors. Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register") Signed-off-by: Miaoqian Lin --- drivers/soc/imx/soc-imx8m.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c index 28144c699b0c..32ed9dc88e45 100644 --- a/drivers/soc/imx/soc-imx8m.c +++ b/drivers/soc/imx/soc-imx8m.c @@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void) ocotp_base = of_iomap(np, 0); WARN_ON(!ocotp_base); clk = of_clk_get_by_name(np, NULL); - if (!clk) { - WARN_ON(!clk); + if (IS_ERR(clk)) { + WARN_ON(IS_ERR(clk)); return 0; }