From patchwork Fri Dec 30 18:06:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 37729 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3008317wrt; Fri, 30 Dec 2022 10:08:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXsbTmFUnFAXgU+/CXF/APrJrExjgr4lII4GoxojGUK+gceeCmwnZye0EarPpF918pYfocno X-Received: by 2002:a17:90a:1089:b0:226:3305:b072 with SMTP id c9-20020a17090a108900b002263305b072mr6088913pja.29.1672423684688; Fri, 30 Dec 2022 10:08:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672423684; cv=none; d=google.com; s=arc-20160816; b=tO7zrk3kDFuW6WyLNjJu3f6yiZaHUEz3KEmosI4Ax4ko8miYOhYxG5/T6a/pGYcwyh ngtJDQ53J2Um0vmIOE61yKkumfkwxyBFRYwbhnma4lE7T7Vj4TED1kT5NFJlm26rJx8/ xPX4Siur8iw4X9IrM+eYMR/1Iquhnqk9X2t6SRReMZFYeSOikgoQPbhQ2oVjWA8f5NdC xeuR4SlbmgfrL/zb1pJIqxbz6Gsajn7nAuRgmn0UbpRebUs5zypAlax/HC5ziSeQ5pZh 57aFML8j6Wso+42HrtxdKiZcS1xqtNmJmKNRz0Mzn728jVjjGs/MaMG2rnpqm46hs4cH cM7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=owvYwEn7S/5FDQeiC0iDlg4bP/bANVVwDFI945nRit0=; b=Ls6LB1ZbCbIMS53NMQ26MAItV897hQ5oZmdmRIzO+99ZO51aEV22iKqZjF1RgNNieb 9B6+JXW5bOUrtBu5p+A30DTqHPhtePiYU8p2nkk68UHU0D3vv+Av+jHVp02KiE/SHe0S 3xFeQTfLp505Gf0gvNUjIYe/fOMv8VqyGWZkj0DJYb/0YDVzar+b12JlNA9qCiVZ5S4d 4dvTFjggOMXlfvFWcvgKQze6KYFpXjCHABZqVcSciYvEaZ9qUjPAGS7csFLkIKPLhIkb BZkqDz2kn5PjX/0zkafDydmkW+E7Rff4dwdABJLxXlIBk8lRDIUHD3fKVS2Q9nxJwG3C EY3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v15-20020a17090a898f00b00223facc5d2csi21509492pjn.162.2022.12.30.10.07.52; Fri, 30 Dec 2022 10:08:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235430AbiL3SHQ (ORCPT + 99 others); Fri, 30 Dec 2022 13:07:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235405AbiL3SHN (ORCPT ); Fri, 30 Dec 2022 13:07:13 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31C426248 for ; Fri, 30 Dec 2022 10:07:12 -0800 (PST) Received: from dslb-188-097-208-179.188.097.pools.vodafone-ip.de ([188.97.208.179] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pBJmc-0004rR-KE; Fri, 30 Dec 2022 19:07:06 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 01/20] staging: r8188eu: make xmitframe_swencrypt a void function Date: Fri, 30 Dec 2022 19:06:27 +0100 Message-Id: <20221230180646.91008-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221230180646.91008-1-martin@kaiser.cx> References: <20221230180646.91008-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753663337545231178?= X-GMAIL-MSGID: =?utf-8?q?1753663337545231178?= xmitframe_swencrypt always returns _SUCCESS and the caller does not check the return value. We can remove the return value and make xmitframe_swencrypt a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index 34494f08c0cd..4cd457cfb791 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -761,7 +761,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr return _SUCCESS; } -static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame *pxmitframe) +static void xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame *pxmitframe) { struct pkt_attrib *pattrib = &pxmitframe->attrib; @@ -781,8 +781,6 @@ static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame *pxmi break; } } - - return _SUCCESS; } s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrib)