From patchwork Fri Dec 30 18:06:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 37745 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3009454wrt; Fri, 30 Dec 2022 10:10:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXtnY/I61//iVjvXOP7jEyyBd48SAyuBQPHLhOp25xmeXYSOJ8xi8L0CmFyPF0+rGrXF5cIM X-Received: by 2002:a05:6402:1f0b:b0:46c:f903:7ea3 with SMTP id b11-20020a0564021f0b00b0046cf9037ea3mr28272923edb.32.1672423837791; Fri, 30 Dec 2022 10:10:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672423837; cv=none; d=google.com; s=arc-20160816; b=EdGzWD95Dqcp672fW0CcVFTXeuk5r/+rIaIQl7ElMaeUpBISDkJ6hT0sw0qc6UCZl9 rMtHJt1kv/zBLQogBQgfuzi7yXbEgyKV29x1OFD2ousWDbcCkpQOwylyq8t2BWouxW5N HE16sEq3Ao8w1RFW2XfM4lpuU2gksKggglFRvJlyFy9BcN+3ymFLCKWK0ixa8cXDPLL/ drXNICFWdbzD47Qit8a7HlZtK9/mjPsv4JHufc5Io0aTCqGcFlB7vzJB0/LoSdY4+amY vxMs40Q6n2XKuRiQF2kI1FxBKJdpr4qqep+fDyfN3GVU5pJ6jE3WjkkkdVH1Hm/Sgpts TDrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=F6tARZmh3GsbYj0cvlxSR+fRM8JSuizVJOiv36imjNQ=; b=ed6Rrw79hyWrnuS699dQtjQP7ltxbEFn/v3M6dzUX9NbEe0ZhF0/LSaQDwSgqztzOQ tlC2f3uueIbv8/N9FqyZDCfDQIUXFqabjmMb2g7jC8GvKQyEOagicJFguQ3wAtf5kVr6 OGTQ+VjAD7GpmviF/nzaeTMJj7t5ymm4QEshcPcP6yoj3aSxpCL73rWCx7Y6ZrgjuB0K NquYlGHuV/bXxZQ67IR6Y1717Cr6/RIT2Dp3gLGrp29uetc0hYfGRUOrj+fVffGH2MTR v5wtFJ5dk4EGI7oEwHyIDVWDDxXmrL3WOvKXr3I/DLAbebJp6oELU8+ibdq35IIJLMYA ldiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m12-20020a056402430c00b0046b6da777ecsi19745688edc.451.2022.12.30.10.10.13; Fri, 30 Dec 2022 10:10:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235561AbiL3SIN (ORCPT + 99 others); Fri, 30 Dec 2022 13:08:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235500AbiL3SHj (ORCPT ); Fri, 30 Dec 2022 13:07:39 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF1B1C920 for ; Fri, 30 Dec 2022 10:07:25 -0800 (PST) Received: from dslb-188-097-208-179.188.097.pools.vodafone-ip.de ([188.97.208.179] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pBJmp-0004rR-Lg; Fri, 30 Dec 2022 19:07:19 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 17/20] staging: r8188eu: remove unnecessary rtw_free_xmitframe call Date: Fri, 30 Dec 2022 19:06:43 +0100 Message-Id: <20221230180646.91008-18-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221230180646.91008-1-martin@kaiser.cx> References: <20221230180646.91008-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753663498348115118?= X-GMAIL-MSGID: =?utf-8?q?1753663498348115118?= There's no need to call rtw_free_xmitframe before we dequeue the first frame. pxmitframe is always NULL at this point, rtw_free_xmitframe will do nothing in this case. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index cf9779b86b9c..d1af76cc2091 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -398,9 +398,6 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmit if (!pxmitbuf) return false; - /* 3 1. pick up first frame */ - rtw_free_xmitframe(pxmitpriv, pxmitframe); - pxmitframe = rtw_dequeue_xframe(pxmitpriv, pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry); if (!pxmitframe) { /* no more xmit frame, release xmit buffer */