From patchwork Fri Dec 30 18:06:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 37743 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3009161wrt; Fri, 30 Dec 2022 10:09:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXstoPsJpUfFbyrCN3kWkprqFjOSbapfGv7P2HpS3S+pU7E0ftRJSVJ0whWcLmaUdgzyTbVF X-Received: by 2002:a05:6a21:e385:b0:b3:4044:1503 with SMTP id cc5-20020a056a21e38500b000b340441503mr22481249pzc.52.1672423796383; Fri, 30 Dec 2022 10:09:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672423796; cv=none; d=google.com; s=arc-20160816; b=r0dEU0SXqGIbQ76vJb/e+cnQn1hBfkuCataAzZNzjw8tuBLUnXXA1wZdAjnUWYs/Ey 145+K/N+wq/q+bBHL9o/PNUz7jXZBQVTMV11mtF4nt7i87f28vcYQt3ZNuoTKR9cD+97 0TcRYBmyeirfxQV/XAbwpubOblwxbXsDKd8oDpo0h/YtfqlbcBvRZ1HCUOk6DDl1kpaT fapPM3lQ/oRcYgXSgTDZefoExnsukqdH4Rg4VdTNLooTGqixJTZc+zvw66SxkX64qCM/ qSbjWWF8V8rn5mMvVcW+ve3Q9BllDblHsjJ+xduyAGhQedpwy/cCxcOkA4MLLPE+9oFz eU3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ewRGr2JoBImK4YhcVJfakNEtOotO9smawsZFBmt5CFk=; b=LbFzBtOxauCXAhC4XZ5ZGSitqleLCLkpNAZk9Cu1ULJo9Xw/wg/bFo2ioqcM1MbpJS crVMDI+l8wgwZgFZRr8VB25sjHIonYnyzSnj7xo7eLVnULOA715HHjU6gWCJOXX5SdmZ 0BzioRE7wkyuJd6/S7d4uN4dNJKZG5Y9q60v0mjFUnly+pe5NGsEO1LTMkiEz2k+rtwD lptsb8+Np+rytJmqkKlbQzcfUFxwyqSfMCFn7Kn88IKZ+IMSnZwBXKFl5nBm7A/onLoR c1r/YMtGkqblrpm/gQ0WTkV1Ygl6bHEbEe4rdQg+3TMFjLCqbeAJs71rsos/rBReFZj8 fJ/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l191-20020a6391c8000000b004978594b6desi18800838pge.609.2022.12.30.10.09.44; Fri, 30 Dec 2022 10:09:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235548AbiL3SIJ (ORCPT + 99 others); Fri, 30 Dec 2022 13:08:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235494AbiL3SHj (ORCPT ); Fri, 30 Dec 2022 13:07:39 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3CAD1C423 for ; Fri, 30 Dec 2022 10:07:24 -0800 (PST) Received: from dslb-188-097-208-179.188.097.pools.vodafone-ip.de ([188.97.208.179] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pBJmo-0004rR-Qe; Fri, 30 Dec 2022 19:07:18 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 16/20] staging: r8188eu: tx_retevt semaphore is not used Date: Fri, 30 Dec 2022 19:06:42 +0100 Message-Id: <20221230180646.91008-17-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221230180646.91008-1-martin@kaiser.cx> References: <20221230180646.91008-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753663454720577356?= X-GMAIL-MSGID: =?utf-8?q?1753663454720577356?= Remove tx_retevt from struct xmit_priv. This semaphore is initialised but not used. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 2 -- drivers/staging/r8188eu/include/rtw_xmit.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index ca6a1f4298a4..eb47d8276eec 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -196,8 +196,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->txirp_cnt = 1; - sema_init(&pxmitpriv->tx_retevt, 0); - /* per AC pending irp */ pxmitpriv->beq_cnt = 0; pxmitpriv->bkq_cnt = 0; diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h index ef1b7123e557..719424dd8a49 100644 --- a/drivers/staging/r8188eu/include/rtw_xmit.h +++ b/drivers/staging/r8188eu/include/rtw_xmit.h @@ -280,7 +280,6 @@ struct xmit_priv { u8 wmm_para_seq[4];/* sequence for wmm ac parameter strength * from large to small. it's value is 0->vo, * 1->vi, 2->be, 3->bk. */ - struct semaphore tx_retevt;/* all tx return event; */ u8 txirp_cnt;/* */ struct tasklet_struct xmit_tasklet; /* per AC pending irp */