From patchwork Fri Dec 30 17:53:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 37727 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3003635wrt; Fri, 30 Dec 2022 09:59:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXt9cDaWKEE6tAxbg3nzn/lonoUEEYRh/wPUWDrE9Lc140wGzvgvKl9BYiQ3DU4iWbaayVmY X-Received: by 2002:a17:902:ec89:b0:18b:ed3f:c6ca with SMTP id x9-20020a170902ec8900b0018bed3fc6camr47978709plg.12.1672423161059; Fri, 30 Dec 2022 09:59:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672423161; cv=none; d=google.com; s=arc-20160816; b=EN4G4dU94/hinbekAfM7QrL14sT0qVZpkrAqv0vMnrq6AudpdXWQ+cGrYJUXpUovZo eznuMPX/tUXTnrOaIQW1I/u+wmxXa+LC7T2FPvGsDvCBJUvVgJXvY6czB6Btf0G0/r/0 U9DucNgBhjuzczJOL9vHP69BR4firCGyv+xhR/qKg3p00bxkDxMSqB3d4LM9bvyCOz4o g0ZFVtJjwKVKuKFOQ7C3IBdI4fR+5sK9my1hBgsAOPiXqJHvs0oLJfK3klvl5sA9dCHI 86x/D0qG16Li8zTvXlocguDp4RDRdZmzs2QleQNScTWN6qRgF30ydTX7PqMSocFTT5tQ ercQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5moOgHWfmG8oZCupRjDVF/yfdc0UL4D+eFK4lEJbBGg=; b=EaAchEImFl8lBgddHU6ev63gKunEC0AOmTeOSMbx5cSpaWroHCVSZC3xFaBq6jzmcT BE9oiAjFlOFajAy4qL8CokDZW6/6jGc8ijAE48CaoelDJYIJqNUYzCxbmONKf706cA2U iTyAOFMbA5Y6FLOEyIM1nLpfDA7+R7kNR0pVtBp+kO2Jm2bm79GnbzCFWtHCVz1apApT rCBjRku/tMfqfj5RnE2qjI/JyQ23r7dTUKCZCGa/DNmQV/w/ZjPsC2wcEUgFgiFaaEOg b/wzACbbQ4LL2kEwgk25ganYwVNeC4fsBUFfhd+aR3iseS7+RXmy1Q9MRE8C/Y+NsGIH g2cA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v1-20020a170902b7c100b0017336c464ecsi21334841plz.407.2022.12.30.09.59.08; Fri, 30 Dec 2022 09:59:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235247AbiL3RyO (ORCPT + 99 others); Fri, 30 Dec 2022 12:54:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235279AbiL3Rx7 (ORCPT ); Fri, 30 Dec 2022 12:53:59 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CC0E1C40B for ; Fri, 30 Dec 2022 09:53:59 -0800 (PST) Received: from dslb-188-097-208-179.188.097.pools.vodafone-ip.de ([188.97.208.179] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pBJZq-0004hN-0s; Fri, 30 Dec 2022 18:53:54 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 4/4] staging: r8188eu: remove intermediate token variable Date: Fri, 30 Dec 2022 18:53:26 +0100 Message-Id: <20221230175326.90617-5-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221230175326.90617-1-martin@kaiser.cx> References: <20221230175326.90617-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753662788717173680?= X-GMAIL-MSGID: =?utf-8?q?1753662788717173680?= Remove the token variable in on_action_public and use frame_body[2] as function parameter. This saves another few lines of code. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 310e60c4b639..dc181e491b34 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3739,15 +3739,13 @@ static void on_action_public(struct adapter *padapter, struct recv_frame *precv_ { struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data; u8 *frame_body = (u8 *)&mgmt->u; - u8 token; /* All members of the action enum start with action_code. */ if (mgmt->u.action.u.s1g.action_code == WLAN_PUB_ACTION_VENDOR_SPECIFIC) { if (!memcmp(frame_body + 2, P2P_OUI, 4)) on_action_public_p2p(precv_frame); } else { - token = frame_body[2]; - rtw_action_public_decache(precv_frame, token); + rtw_action_public_decache(precv_frame, frame_body[2]); } }