From patchwork Fri Dec 30 17:53:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 37725 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3003001wrt; Fri, 30 Dec 2022 09:56:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXtjszIHl410fcrTGFnm1PwS4HEqifigS8fpFIOXpt01iZOBRqaO754k4X8CXt1Z89Ts+711 X-Received: by 2002:a05:6402:5145:b0:475:32d2:7486 with SMTP id n5-20020a056402514500b0047532d27486mr29456918edd.31.1672423014609; Fri, 30 Dec 2022 09:56:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672423014; cv=none; d=google.com; s=arc-20160816; b=rXVDd1b8mYEUvz74dEqIJDo7BEkZO88KhtzEE/ZsCsjDV8dF+EfrWmweUjJRlINTXw Vwypt2WpIEY8YRkREPnlmKgYf7ndnJAhbJv6KXKmJljra3tOmZnRRmSXRsquauTgkGQy +cBZPBRTtYqvVrmIUu+FxBuTKEMRr3molhu1l1p1pO3BnrlUcy83BIcw+7BN/SKXZqdK N1vspArRWQ3fnoTj9kIvH40jbqbhP5vWC0Mh2VUvXbXzo2PTogM4AJNgXczmWLnpaao0 ebNGJjEz3MesZROCcSVuBmmmqXTCiXdEJIHYG++6f2+6c9pACA/IS0DqPx8B3GYSjni7 Uy/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LYdEmGJv0lxWfkAx1zB5deNY7o1DdSOweCd+DCAayc8=; b=hAF9+URG2l8bzr7m5YOliDdqaYB1iM8CphbAy+kRzzDedW65DW72xvsIUUNrDGTTd/ /2I/tSGhiGTSE5nhRChnxKAn1hO37TRWd4XXXsRjidwkRQb6Gk+xScOZFZQXkOiUGv/k /enVFUDCz9lnB6iQn9e1ylytLYKHv+dzEMOzNnaeDle/nhMfXJsWA3DM/Lu/miFJMSHZ puwKEQQroj3YIjraKHunQqZG7Hly61WOA07FA16CmyxT0TIJjPskc9R4fzxEz2iRwRNs T/8KjwCvV/ODMgpeGGjlApGhdxKENqm/MQQ+KJ92N8cVi9sYnyoddg0ZBR0HYC4FRRdI 39XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz10-20020a0564021d4a00b0047b79b99e52si677543edb.567.2022.12.30.09.56.31; Fri, 30 Dec 2022 09:56:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235397AbiL3RyJ (ORCPT + 99 others); Fri, 30 Dec 2022 12:54:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbiL3Rx7 (ORCPT ); Fri, 30 Dec 2022 12:53:59 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FFEAF1C for ; Fri, 30 Dec 2022 09:53:58 -0800 (PST) Received: from dslb-188-097-208-179.188.097.pools.vodafone-ip.de ([188.97.208.179] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pBJZp-0004hN-0t; Fri, 30 Dec 2022 18:53:53 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/4] staging: r8188eu: remove intermediate pframe pointer Date: Fri, 30 Dec 2022 18:53:25 +0100 Message-Id: <20221230175326.90617-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221230175326.90617-1-martin@kaiser.cx> References: <20221230175326.90617-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753662634893916120?= X-GMAIL-MSGID: =?utf-8?q?1753662634893916120?= The pframe pointer in on_action_public is used only in the definition of frame_body, which points to the payload of an incoming action frame. We can use mgmt to locate the action payload and remove the pframe pointer. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index 0b2f5d6c1279..310e60c4b639 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3738,8 +3738,7 @@ static unsigned int on_action_public_p2p(struct recv_frame *precv_frame) static void on_action_public(struct adapter *padapter, struct recv_frame *precv_frame) { struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data; - u8 *pframe = precv_frame->rx_data; - u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr); + u8 *frame_body = (u8 *)&mgmt->u; u8 token; /* All members of the action enum start with action_code. */