From patchwork Thu Dec 29 16:33:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 37451 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2491789wrt; Thu, 29 Dec 2022 08:47:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXuUFyPThinvoLVm/i64k61RrjTVnz21DPoimIczaZTpinbLERhLZhrLBjSPQ0lq77aA53Fn X-Received: by 2002:a17:903:44a:b0:185:441e:4d0e with SMTP id iw10-20020a170903044a00b00185441e4d0emr31151774plb.62.1672332469475; Thu, 29 Dec 2022 08:47:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672332469; cv=none; d=google.com; s=arc-20160816; b=BX/HC2m8NUqTk2JSazIt1gFBoD5E5OnT3P8q2UiydJb5bSBOACr+33S3BDfQnPenI3 VWzQrWhVI3sx4V0cgyRdaGU7ujOdjqRX8YpeEID9CcfzeYRRN3QoOFEmDX/n3pOGYz57 Kvw38ks/U2d/jS7Z+Ii50ivS9aeyRkkr9cPUI0wWb2Y5hDykMVMHSIq4gUqkbYPBMJEu X1kWYnp9884dS8qJKeF44w5rJ2NgI9/N5mR+OpnEIsVak6KgAh0vkrFiVjaXN9gH6ZFj dd0toTUARyGqQlAzoom45S1PI6Q1yDezw/5xFGtBNtPboWPvBIlyqZW8yPebgaxIT3zN UI5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=irH1XmQtG5dO1L6/FH3q43QSzL37yuS1O7l4CdF6kPc=; b=yknYHwJXsYZ+ji2JUkLeY+qRejvTjjwJDwpJBuLSpArXlyEF7Tis5Taf7GgyKLGcOB L8IqX6MyMVvtaIdSM0+FBJS5PXcj0eDd7ydHoneVAXD4ME3cTcTIvKHSx5+7I4sgvU5B wuiFRYxW1+8WMsjBIllYPYV14TmipYve+Dlreka8z5HoAEV+0nWJcA9jhsa6UCmYEujW oMdaZHL4ShL6u37kRozQnw/KNdj5RmT1lETmHYC3sSA3aa02A2rZhINHt+e62k/R7iM0 MaE9mqrrA3Ajkg/VxryOSd0Bcl+oOXxly+ORRy4ECFZ449su7qfS8raw7WgZd1utVjck gdPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WLw+oWEJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 73-20020a63004c000000b004615836deeasi19344656pga.860.2022.12.29.08.47.37; Thu, 29 Dec 2022 08:47:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WLw+oWEJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233823AbiL2Qo0 (ORCPT + 99 others); Thu, 29 Dec 2022 11:44:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233715AbiL2Qnw (ORCPT ); Thu, 29 Dec 2022 11:43:52 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF46FA199; Thu, 29 Dec 2022 08:43:51 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id bx10so17888533wrb.0; Thu, 29 Dec 2022 08:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=irH1XmQtG5dO1L6/FH3q43QSzL37yuS1O7l4CdF6kPc=; b=WLw+oWEJlXYA0Lx2/GVzVskqZ/SV256M7X8MiNX49OLu3WVCTUbNhsxBrcft4VrMqC ap27rmkhHACSaT+QjEEDZ5m25FVDD3qCU7darpBttRPgStssqlkTLjy5WBBOe0Y0zsle /ftfOdS+H/nLsyI5W5gQh9B9kr/1Tqw32CVxWKH4miGUk0vnssHw7Q27RBeQUZVgnqDr FOp3lpO1Zrs0lvfvx2zM7pn+C0yoXuiebIRV50muMunlmYGxcODKIWbk4IpImsio0Kxq oB6r0CUqah4gQlRz3/bZEYL08dAMJ9zouzjHSvOJmpn4DTfjBk95fv4J5aVwT0k6NNwr ohdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=irH1XmQtG5dO1L6/FH3q43QSzL37yuS1O7l4CdF6kPc=; b=ppBedEUBuCsOC/S7ioHLZN3JI7UpnZlBkmm0vh3hh+Nf9bQ31cO/Pf2lgH/hJCxAB4 e9R0LWiYnb0+ybdIrPrAWRnGLTkb5IdadFhkm4nbz6vmDw2BdxYUrdLqPAtzE5IHIL2S MpxWuyyxeXaNl/Y7CHZ4pqMY+swqOVzmLTx9BcmYAhZ15stzx7psuUKPDuaB6HnHCAh3 yut8wPaf0AMWbG1wij+bvbSIT1EB8WER2UIq6NuFtfrNWI0hyJYRby1Bj8QxsomsZ7Q4 e0B20QUCaYgZnpVHaIRXxoJittBWnPcuxPOVUIq8xr7eIIRq7WLdIa9K+PVYtEnKCU8f m2ZQ== X-Gm-Message-State: AFqh2kqcDrGVxz1c4DcHmP0CBqBE2CnN7ZlarbZg/zDGcUtsvYJJ+7Fn PhAFdxEECiMksh3PBby+EbU= X-Received: by 2002:a5d:534e:0:b0:277:e258:cccd with SMTP id t14-20020a5d534e000000b00277e258cccdmr10766922wrv.15.1672332230378; Thu, 29 Dec 2022 08:43:50 -0800 (PST) Received: from localhost.localdomain (host-82-55-238-56.retail.telecomitalia.it. [82.55.238.56]) by smtp.googlemail.com with ESMTPSA id t18-20020a5d42d2000000b00288a3fd9248sm4326586wrr.91.2022.12.29.08.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 08:43:50 -0800 (PST) From: Christian Marangi To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ronald Wahl , stable@vger.kernel.org Subject: [net PATCH v2 2/5] net: dsa: tag_qca: fix wrong MGMT_DATA2 size Date: Thu, 29 Dec 2022 17:33:33 +0100 Message-Id: <20221229163336.2487-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221229163336.2487-1-ansuelsmth@gmail.com> References: <20221229163336.2487-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753567691587880780?= X-GMAIL-MSGID: =?utf-8?q?1753567691587880780?= It was discovered that MGMT_DATA2 can contain up to 28 bytes of data instead of the 12 bytes written in the Documentation by accounting the limit of 16 bytes declared in Documentation subtracting the first 4 byte in the packet header. Update the define with the real world value. Tested-by: Ronald Wahl Fixes: c2ee8181fddb ("net: dsa: tag_qca: add define for handling mgmt Ethernet packet") Signed-off-by: Christian Marangi Cc: stable@vger.kernel.org # v5.18+ --- include/linux/dsa/tag_qca.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dsa/tag_qca.h b/include/linux/dsa/tag_qca.h index b1b5720d89a5..ee657452f122 100644 --- a/include/linux/dsa/tag_qca.h +++ b/include/linux/dsa/tag_qca.h @@ -45,8 +45,8 @@ struct sk_buff; QCA_HDR_MGMT_COMMAND_LEN + \ QCA_HDR_MGMT_DATA1_LEN) -#define QCA_HDR_MGMT_DATA2_LEN 12 /* Other 12 byte for the mdio data */ -#define QCA_HDR_MGMT_PADDING_LEN 34 /* Padding to reach the min Ethernet packet */ +#define QCA_HDR_MGMT_DATA2_LEN 28 /* Other 28 byte for the mdio data */ +#define QCA_HDR_MGMT_PADDING_LEN 18 /* Padding to reach the min Ethernet packet */ #define QCA_HDR_MGMT_PKT_LEN (QCA_HDR_MGMT_HEADER_LEN + \ QCA_HDR_LEN + \