From patchwork Thu Dec 29 14:22:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Micha=C5=82_Grzelak?= X-Patchwork-Id: 37408 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2429141wrt; Thu, 29 Dec 2022 06:32:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXuUhiQxleGNas9rID6vxALqm55wTRPpY7qnl/ztobQ6hO0ZBiX51k7HRiNIuRWp9UpFKyUM X-Received: by 2002:a05:6402:1486:b0:482:ab74:6432 with SMTP id e6-20020a056402148600b00482ab746432mr16899563edv.20.1672324334159; Thu, 29 Dec 2022 06:32:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672324334; cv=none; d=google.com; s=arc-20160816; b=i028mAb0GYXUXjqw1z4cBRfHweWSR2kbhL6FVaRA/yHxz9JjDvzrCmWmOqWw+WoCnJ VKT1Svmoda7Bn7VpHOqYZzVS8ZcVggNLbFCFHtlrAaYzz27M1wjNqaNkjUU+ql4kKBZp 7viVM9eyonbt1KafkFHhnW4ZeuYLzsihkPGxQ0TSpTxPX9kVzltbXBOT/PlOfb/r7nj4 pZoGA8jX32AT9Vh3OSvBQgujCgJ4udjY8cNWvXhCEGycZ295kByg10lNpso+nwScVE+8 y6SDqH3FM/+cgBM5cla6hsC9+SysGUhb2WuYe/0b+dTniH8eRU4HLNTBEW4I7Q5sYNHx kMGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1BAXkIo3rvrG/ME3mVxzJSzvIaQ3txJwSjcnNOS9ikw=; b=Fw5mhVKDKXTUqvKZfeX+MU8EFYtB98n9Cwqgtl4jvqtXJ5xsv7yYc+CKLirfNNmy38 R9E0Rvfk5qDKahnvk4RukbQpCpuKah7Zwn4Wujk8d/gPK9VfZx+d8rGA0gG5W128IfT4 5RWnZCcT3SLgq6gK9sPvpbNeGWHlmHoSn3WLHHvb3chuWWnIU5lkkONzowzMDeeGV+8y NGypm23nA+/yDbC7Scg3XG8V4fHRCrxMSDDIJQLXklipzBoN4fHPj6roFqYWz0pyUtav iwbP78sTg9IzayReZ25+yaKiiTex9Ry1Kp/gQ0Iymfdm6okXEvcpI/EZqP8fPofcQh/O ozzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@semihalf.com header.s=google header.b=V3imPe76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o19-20020a056402039300b00461d2ed78acsi14510022edv.378.2022.12.29.06.31.49; Thu, 29 Dec 2022 06:32:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@semihalf.com header.s=google header.b=V3imPe76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230369AbiL2OWz (ORCPT + 99 others); Thu, 29 Dec 2022 09:22:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233330AbiL2OWp (ORCPT ); Thu, 29 Dec 2022 09:22:45 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB2A12D14 for ; Thu, 29 Dec 2022 06:22:44 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id bp15so27663920lfb.13 for ; Thu, 29 Dec 2022 06:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1BAXkIo3rvrG/ME3mVxzJSzvIaQ3txJwSjcnNOS9ikw=; b=V3imPe76scnNaQO8xSv/lhvcpfaRJYdVYbAJZp0kmaHYOwLoigjHxmoQbTbS64oN9k 8IN/xYNg1fWk/42IJMQdIe4lnaLgBaEoRhBs8kDPYiIsCMpCLZ5Zwbin3k07C2ctBqNG an/WAR8NLBfMWscfFIcekwsb1AHF0mKLJNtDu/8p4vF+7rpZh+qrsK5ovE65crEK3JXt PoNU80576lEYsW0MlSdeIvzMuQpghcKms0nPmiANX7GUvpR5v1VOSlRMBxBxrtL53vhU GxH5/orDupZ6KbLejD5DOacisbZvUnaxoV0AfM9N6Y/uqifqBpZ8DR5CNUKUMbxpyigV SXYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1BAXkIo3rvrG/ME3mVxzJSzvIaQ3txJwSjcnNOS9ikw=; b=mNdBV/sOyAJ9bIYYptZapXc7VjXlZTZben8UJSBCVnt/3eRCxANy8Vr/FhhO69MPuY nme3FQapL9jxYnA8sun3EJzIp5yvNpc+SOam8OKoGOJwUaGDrJROzqhYG5CkF3dpg009 MJSmb0HkW3Jce8aYX6eCdbzROudubrfxxzdL/Ik6OsFZlVT3/joCnbHtw/FikTuKHp5K llowkpXLLgEVavsaQloB5JOyokN6fonU1nBPBTINnkqTc43qR3U49ATpfeb86R6wmaVl +f8hXB6SgjLEtq6wSRHVOvFcR0tAqco1befEAWhEHtGZX8FEhItXHjQB+8jN/ddR3L8x Wkfg== X-Gm-Message-State: AFqh2kqnjyPZd1icFvSGvbV3AyPAtWN6yBcrXeewvQj8JsofhE6ACjBy 2/ZgHIislb/COWSwKoAI/nN6CqDY/5m/SBVnDL4HUw== X-Received: by 2002:a19:7114:0:b0:4b6:fddb:8e43 with SMTP id m20-20020a197114000000b004b6fddb8e43mr8605040lfc.26.1672323762648; Thu, 29 Dec 2022 06:22:42 -0800 (PST) Received: from michal-H370M-DS3H.office.semihalf.net ([83.142.187.84]) by smtp.googlemail.com with ESMTPSA id e13-20020a05651236cd00b004b57a810e09sm3098819lfs.288.2022.12.29.06.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 06:22:42 -0800 (PST) From: =?utf-8?q?Micha=C5=82_Grzelak?= To: linux-kernel@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, chris.packham@alliedtelesis.co.nz, netdev@vger.kernel.org, devicetree@vger.kernel.org, upstream@semihalf.com, mw@semihalf.com, mchl.grzlk@gmail.com, =?utf-8?q?Micha=C5=82_Grzelak?= Subject: [PATCH v3] dt-bindings: net: marvell,orion-mdio: Fix examples Date: Thu, 29 Dec 2022 15:22:19 +0100 Message-Id: <20221229142219.93427-1-mig@semihalf.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753559161279766744?= X-GMAIL-MSGID: =?utf-8?q?1753559161279766744?= As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f ("dt-bindings: net: orion-mdio: Convert to JSON schema") if 'interrupts' property is present, width of 'reg' should be 0x84. Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add constraints checking whether 'interrupts' property is present and validate it against fixed values in reg. Signed-off-by: Michał Grzelak Reviewed-by: Krzysztof Kozlowski --- Changelog: v2->v3 - drop quotes and blank line v1->v2 - remove second example - add 'if:' constraint to 'allOf:' - move 'allOf:' before 'examples:' .../bindings/net/marvell,orion-mdio.yaml | 30 ++++++++++++++++--- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml index d2906b4a0f59..e35da8b01dc2 100644 --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml @@ -16,9 +16,6 @@ description: | 8k has a second unit which provides an interface with the xMDIO bus. This driver handles these interfaces. -allOf: - - $ref: "mdio.yaml#" - properties: compatible: enum: @@ -39,13 +36,38 @@ required: - compatible - reg +allOf: + - $ref: mdio.yaml# + + - if: + required: + - interrupts + + then: + properties: + reg: + items: + - items: + - $ref: /schemas/types.yaml#/definitions/cell + - const: 0x84 + + else: + properties: + reg: + items: + - items: + - $ref: /schemas/types.yaml#/definitions/cell + - enum: + - 0x4 + - 0x10 + unevaluatedProperties: false examples: - | mdio@d0072004 { compatible = "marvell,orion-mdio"; - reg = <0xd0072004 0x4>; + reg = <0xd0072004 0x84>; #address-cells = <1>; #size-cells = <0>; interrupts = <30>;