From patchwork Wed Dec 28 16:40:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 37249 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1981561wrt; Wed, 28 Dec 2022 08:45:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXuUZzElyzDNzh6kGhzL0G0elRU3YpM5DzXubGUpwfYSr6vxUNCCdoDJPiV/ezwYBoE0AKj5 X-Received: by 2002:a17:907:6e16:b0:7c1:b64:e290 with SMTP id sd22-20020a1709076e1600b007c10b64e290mr40350670ejc.45.1672245954530; Wed, 28 Dec 2022 08:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672245954; cv=none; d=google.com; s=arc-20160816; b=O9kE8gIJVMtLcC/DuyxbK/pqxw9cM4PvbbdMiYUJ0yd7tfbvm8yceDEmFYfIJ3vFnQ m5tRVEtkFsKlSJCsHxI4k5fT6Fm9LXp9b48CwKY0io4JP92t/zhVDaX355AMRP8tKAWg skttMdfxwz0zOGR9ZSBU7A5gk2NAC5eI9M/EGUZWHPvmjkAqFTu6t8QdRVeRvr9HpPkY znc9VIHbfoQXmBJeRTfJAqu7pZBx5WMvbFwHv4Exjic8+3ah9XaRYJirTdB6EguD53kF GNqrcBHzEmDWHpQnca1MmQjVKgCGZICOzJ4Q4GBnZ6TEsHqYsfcGkUf0gR7q637sTUn8 O8EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=08E5qi8vxqr6+TC+1BFlozXvA3KflPEceb13Px12www=; b=v4uaicxG/eObH+XN4dz7KL0ZsQX/DuppQGCPP2gryLukGaAou6j1yp39bopb8bAoQU kusNSWHOGtKtKSQ2j9fZr6cxbREPMNZh+PoOjp6Rx4hNxAmy2hQ9nQ0Fk8xYFd3ik82a LNvmrIThlmh9y0OIL+t8AgcOeeCWwMC+iuStqAUe8NysxnQOkhkX3uxrYk3OqyUQDZ+j onlRxADcuNZb2isDCwMNrqtNPlTyKUD9Y4gJwDFFZf4Xhr2cljBhaQJJOkbLcbutCsJs zgGLrVOvsGOAO6CpOWcow1AFIuhWvA9c/MmwDW3POu8qlDP9jxwiJoe7RgQHlX0qLQsS lOfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=EsQHDOpU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq6-20020a1709073f0600b0084c7031304dsi4316519ejc.624.2022.12.28.08.45.30; Wed, 28 Dec 2022 08:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=EsQHDOpU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235072AbiL1QpE (ORCPT + 99 others); Wed, 28 Dec 2022 11:45:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234330AbiL1Qoe (ORCPT ); Wed, 28 Dec 2022 11:44:34 -0500 Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 950B01CB1E; Wed, 28 Dec 2022 08:40:16 -0800 (PST) Received: from mwalle01.kontron.local. (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 8DBA91668; Wed, 28 Dec 2022 17:40:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1672245614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=08E5qi8vxqr6+TC+1BFlozXvA3KflPEceb13Px12www=; b=EsQHDOpU6kBEqvm03VA6xTFCCkU58UYh/I0Fh90H8YssNKXFJ4maBQ3aLntqeRTUl1ncOF fS9vO4cqQrJpnGZH0iuGbdqS1wtTKFZkNxxQNrpYV0KK5nREquONPBSmfndHHN91h6prBP jiZ5ERvUWMBSZm9KICdN4fT0yjoLEqRJq0mbAhMV6O02+WnJgaoxEQecttnIjEnQVgdK75 z5eremSsZIXxi9UnInasWCk67OW6LbgLPZoI8RdqQJ7A9BUVQWfldPvMLMgEhSRMyyKhcC T3XDjSCFbx0hpPBDrTzEd2e4wy+Zg5vLZgdGaiwwT3StFDD1815NNf19drdmPg== From: Michael Walle To: Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Walle Subject: [PATCH RFC net-next v2 2/2] net: phy: mxl-gpy: disable interrupts on GPY215 by default Date: Wed, 28 Dec 2022 17:40:08 +0100 Message-Id: <20221228164008.1653348-3-michael@walle.cc> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221228164008.1653348-1-michael@walle.cc> References: <20221228164008.1653348-1-michael@walle.cc> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753476973571847079?= X-GMAIL-MSGID: =?utf-8?q?1753476973571847079?= The interrupts on the GPY215B and GPY215C are broken and the only viable fix is to disable them altogether. There is still the possibilty to opt-in via the device tree. Signed-off-by: Michael Walle --- drivers/net/phy/mxl-gpy.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c index 147d7a5a9b35..e5972b4ef6e8 100644 --- a/drivers/net/phy/mxl-gpy.c +++ b/drivers/net/phy/mxl-gpy.c @@ -12,6 +12,7 @@ #include #include #include +#include #include /* PHY ID */ @@ -292,6 +293,10 @@ static int gpy_probe(struct phy_device *phydev) phydev->priv = priv; mutex_init(&priv->mbox_lock); + if (gpy_has_broken_mdint(phydev) && + !device_property_present(dev, "maxlinear,use-broken-interrupts")) + phydev->dev_flags |= PHY_F_NO_IRQ; + fw_version = phy_read(phydev, PHY_FWV); if (fw_version < 0) return fw_version;